Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11217/?format=api
{ "id": 11217, "url": "http://patches.dpdk.org/api/patches/11217/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1457462311-16349-3-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1457462311-16349-3-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1457462311-16349-3-git-send-email-thomas.monjalon@6wind.com", "date": "2016-03-08T18:38:30", "name": "[dpdk-dev,v3,2/3] pci: remove config of extended tag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "26c01e121600f358cb2ff82768700651fda5bf2d", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1457462311-16349-3-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/11217/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/11217/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4F87F374E;\n\tTue, 8 Mar 2016 19:40:18 +0100 (CET)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id C18292C63\n\tfor <dev@dpdk.org>; Tue, 8 Mar 2016 19:40:14 +0100 (CET)", "by mail-wm0-f52.google.com with SMTP id l68so40094029wml.1\n\tfor <dev@dpdk.org>; Tue, 08 Mar 2016 10:40:14 -0800 (PST)", "from XPS13.localdomain (171.36.101.84.rev.sfr.net. [84.101.36.171])\n\tby smtp.gmail.com with ESMTPSA id\n\td2sm2955883wjf.28.2016.03.08.10.40.13\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 08 Mar 2016 10:40:14 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=p69fvbGMLMIRaDbxxtVddG+hXsy+6S/RuoQ34Kg8EkU=;\n\tb=pVykc0rY8n/8MBHfFqqL4vUyLDbqJ0UPdJupWJsVSUy8r99kbrG4aYVoFzNIDKkiWf\n\tmiz8d/5QDxJk+gNqgfkqa5Ez583kTlUWmXr0ZRcu46QMH64BfIX4XNAVn7yfD73PDeSV\n\t62qGl38N/L66LDiFRKI30EGbB4CD0xGrY1AwKKx/VVs2qKWTS0t7XOXrLGI36DdNXkfA\n\tj4sr+/LDDw6UrQcJ8YIjOh9P9Dr33pg4vCw1P7SIO4mm7P0FMpVcK1Qz0cp73+wEdZfE\n\tmAlX9D/J5x16zLOaN0NSuMNS5X8HSWOd21wAJGZy3bJa8ftAXgkeehwOAGz1qPaEV/M/\n\tdM5g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=p69fvbGMLMIRaDbxxtVddG+hXsy+6S/RuoQ34Kg8EkU=;\n\tb=W+FUrDji3XFSclzae4+WQ6oEtwFYudbkjIXtWJlqcusutHgXZ672xOCJ6u5hNegwO8\n\tkVDqDhmO2m8rVHoskOLBK+XEq0GeTRioiNrB/aFs2zVvBD0u1/nu6XtSrfvKS/ZuF2sf\n\tGOCU4PU4ysixt+IxeCP1Fa+U42y30s/bK4nJgaFNiMbAiUzjfjCnSw6DY/GSw7ZzUEGJ\n\tPE6VVCqS3JvkdoSB6aty/SFSP+ezH5fulqWw3+PrFLLyKv6tqx7/QKaxYMGggM4ssInA\n\tb1q2MH9kRYiYvemDTHm4mnPd1TNqPtmazKbWA72vuykyEo5lzUay0lQ8wx+mbJngGgVP\n\tpLpA==", "X-Gm-Message-State": "AD7BkJLYa20mHKsaL7fwqInm+o6LeZwtB3JnYgoqFf/0HauCX5faPMuSFLXzffaz4m8/P0OI", "X-Received": "by 10.194.113.38 with SMTP id iv6mr30532505wjb.126.1457462414627;\n\tTue, 08 Mar 2016 10:40:14 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "helin.zhang@intel.com", "Date": "Tue, 8 Mar 2016 19:38:30 +0100", "Message-Id": "<1457462311-16349-3-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1457462311-16349-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1456113585-15259-1-git-send-email-helin.zhang@intel.com>\n\t<1457462311-16349-1-git-send-email-thomas.monjalon@6wind.com>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH v3 2/3] pci: remove config of extended tag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Helin Zhang <helin.zhang@intel.com>\n\nRemove pci configuration of 'extended tag' and 'max read request\nsize', as they are not required by all devices and it lets PMD to\nconfigure them if necessary.\nIn addition, 'pci_config_space_set()' is deprecated.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n config/common_base | 1 +\n doc/guides/rel_notes/deprecation.rst | 5 ++\n lib/librte_eal/common/eal_common_pci.c | 7 ---\n lib/librte_eal/common/include/rte_pci.h | 5 +-\n lib/librte_eal/linuxapp/eal/eal_pci.c | 90 +++------------------------------\n 5 files changed, 16 insertions(+), 92 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex 1af28c8..c73f71a 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -102,6 +102,7 @@ CONFIG_RTE_EAL_PMD_PATH=\"\"\n \n #\n # Special configurations in PCI Config Space for high performance\n+# They are all deprecated, and will be removed later.\n #\n CONFIG_RTE_PCI_CONFIG=n\n CONFIG_RTE_PCI_EXTENDED_TAG=\"\"\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 9930b5a..9979982 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -8,6 +8,11 @@ API and ABI deprecation notices are to be posted here.\n Deprecation Notices\n -------------------\n \n+* The EAL function pci_config_space_set is deprecated in release 16.04\n+ and will be removed from 16.07.\n+ Macros CONFIG_RTE_PCI_CONFIG, CONFIG_RTE_PCI_EXTENDED_TAG and\n+ CONFIG_RTE_PCI_MAX_READ_REQUEST_SIZE will be removed.\n+\n * The following fields have been deprecated in rte_eth_stats:\n ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,\n tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff\ndiff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex 96d5113..366fb46 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -180,13 +180,6 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d\n \t\t}\n \n \t\tif (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {\n-#ifdef RTE_PCI_CONFIG\n-\t\t\t/*\n-\t\t\t * Set PCIe config space for high performance.\n-\t\t\t * Return value can be ignored.\n-\t\t\t */\n-\t\t\tpci_config_space_set(dev);\n-#endif\n \t\t\t/* map resources for devices that use igb_uio */\n \t\t\tret = rte_eal_pci_map_device(dev);\n \t\t\tif (ret != 0)\ndiff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h\nindex 067e084..e692094 100644\n--- a/lib/librte_eal/common/include/rte_pci.h\n+++ b/lib/librte_eal/common/include/rte_pci.h\n@@ -578,14 +578,17 @@ void rte_eal_pci_ioport_write(struct rte_pci_ioport *p,\n \t\t\t const void *data, size_t len, off_t offset);\n \n #ifdef RTE_PCI_CONFIG\n+#include <rte_common.h>\n /**\n * Set special config space registers for performance purpose.\n+ * It is deprecated, as all configurations have been moved into\n+ * each PMDs respectively.\n *\n * @param dev\n * A pointer to a rte_pci_device structure describing the device\n * to use\n */\n-void pci_config_space_set(struct rte_pci_device *dev);\n+void pci_config_space_set(struct rte_pci_device *dev) __rte_deprecated;\n #endif /* RTE_PCI_CONFIG */\n \n #ifdef __cplusplus\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c\nindex 4346973..4c45452 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c\n@@ -482,92 +482,14 @@ error:\n }\n \n #ifdef RTE_PCI_CONFIG\n-static int\n-pci_config_extended_tag(struct rte_pci_device *dev)\n-{\n-\tstruct rte_pci_addr *loc = &dev->addr;\n-\tchar filename[PATH_MAX];\n-\tchar buf[BUFSIZ];\n-\tFILE *f;\n-\n-\t/* not configured, let it as is */\n-\tif (strncmp(RTE_PCI_EXTENDED_TAG, \"on\", 2) != 0 &&\n-\t\tstrncmp(RTE_PCI_EXTENDED_TAG, \"off\", 3) != 0)\n-\t\treturn 0;\n-\n-\tsnprintf(filename, sizeof(filename),\n-\t\tSYSFS_PCI_DEVICES \"/\" PCI_PRI_FMT \"/\" \"extended_tag\",\n-\t\tloc->domain, loc->bus, loc->devid, loc->function);\n-\tf = fopen(filename, \"rw+\");\n-\tif (!f)\n-\t\treturn -1;\n-\n-\tfgets(buf, sizeof(buf), f);\n-\tif (strncmp(RTE_PCI_EXTENDED_TAG, \"on\", 2) == 0) {\n-\t\t/* enable Extended Tag*/\n-\t\tif (strncmp(buf, \"on\", 2) != 0) {\n-\t\t\tfseek(f, 0, SEEK_SET);\n-\t\t\tfputs(\"on\", f);\n-\t\t}\n-\t} else {\n-\t\t/* disable Extended Tag */\n-\t\tif (strncmp(buf, \"off\", 3) != 0) {\n-\t\t\tfseek(f, 0, SEEK_SET);\n-\t\t\tfputs(\"off\", f);\n-\t\t}\n-\t}\n-\tfclose(f);\n-\n-\treturn 0;\n-}\n-\n-static int\n-pci_config_max_read_request_size(struct rte_pci_device *dev)\n-{\n-\tstruct rte_pci_addr *loc = &dev->addr;\n-\tchar filename[PATH_MAX];\n-\tchar buf[BUFSIZ], param[BUFSIZ];\n-\tFILE *f;\n-\t/* size can be 128, 256, 512, 1024, 2048, 4096 */\n-\tuint32_t max_size = RTE_PCI_MAX_READ_REQUEST_SIZE;\n-\n-\t/* not configured, let it as is */\n-\tif (!max_size)\n-\t\treturn 0;\n-\n-\tsnprintf(filename, sizeof(filename),\n-\t\tSYSFS_PCI_DEVICES \"/\" PCI_PRI_FMT \"/\" \"max_read_request_size\",\n-\t\t\tloc->domain, loc->bus, loc->devid, loc->function);\n-\tf = fopen(filename, \"rw+\");\n-\tif (!f)\n-\t\treturn -1;\n-\n-\tfgets(buf, sizeof(buf), f);\n-\tsnprintf(param, sizeof(param), \"%d\", max_size);\n-\n-\t/* check if the size to be set is the same as current */\n-\tif (strcmp(buf, param) == 0) {\n-\t\tfclose(f);\n-\t\treturn 0;\n-\t}\n-\tfseek(f, 0, SEEK_SET);\n-\tfputs(param, f);\n-\tfclose(f);\n-\n-\treturn 0;\n-}\n-\n+/*\n+ * It is deprecated, all its configurations have been moved into\n+ * each PMD respectively.\n+ */\n void\n-pci_config_space_set(struct rte_pci_device *dev)\n+pci_config_space_set(__rte_unused struct rte_pci_device *dev)\n {\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn;\n-\n-\t/* configure extended tag */\n-\tpci_config_extended_tag(dev);\n-\n-\t/* configure max read request size */\n-\tpci_config_max_read_request_size(dev);\n+\tRTE_LOG(DEBUG, EAL, \"Nothing here, as it is deprecated\\n\");\n }\n #endif\n \n", "prefixes": [ "dpdk-dev", "v3", "2/3" ] }