Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112074/?format=api
{ "id": 112074, "url": "http://patches.dpdk.org/api/patches/112074/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220530143159.13672-10-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220530143159.13672-10-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220530143159.13672-10-arkadiuszx.kusztal@intel.com", "date": "2022-05-30T14:31:56", "name": "[v3,09/12] cryptodev: clarify usage of rsa padding hash", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f8f2d624e746808f32fba750be9cea5fb1c2bf3b", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220530143159.13672-10-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23248, "url": "http://patches.dpdk.org/api/series/23248/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23248", "date": "2022-05-30T14:31:47", "name": "cryptodev: rsa, dh, ecdh changes", "version": 3, "mbox": "http://patches.dpdk.org/series/23248/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112074/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112074/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17263A0542;\n\tMon, 30 May 2022 17:40:47 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5AA8D42B8C;\n\tMon, 30 May 2022 17:39:57 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id E274842B92\n for <dev@dpdk.org>; Mon, 30 May 2022 17:39:54 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 May 2022 08:39:53 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga005.jf.intel.com with ESMTP; 30 May 2022 08:39:52 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653925195; x=1685461195;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=WxRoM74fFu7V6dvFLT6D1v3RfIQsRr9oswId6iNs49w=;\n b=IhXq3vfQdpT+KVhTU7r6qZ9tYX4zx8kEFMwXYTd8pDC5JDAzX+kKq2Fv\n yFKkrJodRo6LGy3NpOdYg//MrjPeP3EwMaUA4K7XThDYqdkRAjW9/tEUs\n 5k2Lo/ggOHgimP5cLKlSoDzWmzMvJf1lvuhOv8eN3IsKZyjm6DH60tFiC\n eemNcBKSiWpaQjYozDHf0ffPYwTlOwbxa3qLkdMXKzJG7av+d6oE1kzXN\n Py03UzwJxYnFIwFh2IPNBR4fjPpUJV9NOn9PQKekfHdneBjgVXXnveUqy\n P9uxJrseq+3LgGu2zNqSYC5hfKgrqJPbDgUELkHecwefHVLklfbLmK0yr w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10363\"; a=\"338069488\"", "E=Sophos;i=\"5.91,263,1647327600\"; d=\"scan'208\";a=\"338069488\"", "E=Sophos;i=\"5.91,263,1647327600\"; d=\"scan'208\";a=\"751678786\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH v3 09/12] cryptodev: clarify usage of rsa padding hash", "Date": "Mon, 30 May 2022 15:31:56 +0100", "Message-Id": "<20220530143159.13672-10-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220530143159.13672-1-arkadiuszx.kusztal@intel.com>", "References": "<20220530143159.13672-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Clarified usage of RSA padding hash.\nIt was not specified how to use hash for PKCS1_5\npadding. This could lead to incorrect implementation.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n lib/cryptodev/rte_crypto_asym.h | 25 ++++++++++++++++++++++---\n 1 file changed, 22 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex a215f4499d..363fbf87c7 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -395,10 +395,29 @@ struct rte_crypto_rsa_op_param {\n \t/**< RSA padding scheme to be used for transform */\n \n \tenum rte_crypto_auth_algorithm md;\n-\t/**< Hash algorithm to be used for data hash if padding\n-\t * scheme is either OAEP or PSS. Valid hash algorithms\n-\t * are:\n+\t/**<\n+\t * RSA padding hash algorithm\n+\t * Valid hash algorithms are:\n \t * MD5, SHA1, SHA224, SHA256, SHA384, SHA512\n+\t *\n+\t * When a specific padding type is selected, the following rule apply:\n+\t * - RTE_CRYPTO_RSA_PADDING_NONE:\n+\t * This field is ignored by the PMD\n+\t *\n+\t * - RTE_CRYPTO_RSA_PADDING_PKCS1_5:\n+\t * For sign operation, this field is used to determine value\n+\t * of the DigestInfo structure, therefore specifying which algorithm\n+\t * was used to create the message digest.\n+\t * For encryption/decryption, this field is ignored for this\n+\t * padding type.\n+\t *\n+\t * - RTE_CRYPTO_RSA_PADDING_OAEP\n+\t * This field shall be set with the hash algorithm used\n+\t * in the padding scheme\n+\t *\n+\t * - RTE_CRYPTO_RSA_PADDING_PSS\n+\t * This field shall be set with the hash algorithm used\n+\t * in the padding scheme (and to create the input message digest)\n \t */\n \n \tenum rte_crypto_auth_algorithm mgf1md;\n", "prefixes": [ "v3", "09/12" ] }