Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112026/?format=api
{ "id": 112026, "url": "http://patches.dpdk.org/api/patches/112026/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20220530054526.292164-1-songx.jiale@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20220530054526.292164-1-songx.jiale@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20220530054526.292164-1-songx.jiale@intel.com", "date": "2022-05-30T05:45:26", "name": "[V3] tests/userspace_ethtool: add method wait port link up and add checklist", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ebac30c04fcdf8370bfc85fdba911a3a2f7c7e64", "submitter": { "id": 2352, "url": "http://patches.dpdk.org/api/people/2352/?format=api", "name": "Jiale, SongX", "email": "songx.jiale@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20220530054526.292164-1-songx.jiale@intel.com/mbox/", "series": [ { "id": 23229, "url": "http://patches.dpdk.org/api/series/23229/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=23229", "date": "2022-05-30T05:45:26", "name": "[V3] tests/userspace_ethtool: add method wait port link up and add checklist", "version": 3, "mbox": "http://patches.dpdk.org/series/23229/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112026/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112026/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 88FFCA00C2;\n\tMon, 30 May 2022 07:45:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 830CB40A89;\n\tMon, 30 May 2022 07:45:34 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id A571F40A82\n for <dts@dpdk.org>; Mon, 30 May 2022 07:45:32 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 May 2022 22:45:30 -0700", "from unknown (HELO daily-regression-131.intel.com)\n ([10.239.251.131])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 May 2022 22:45:29 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653889532; x=1685425532;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=Tpo7btW/i4LHUTODD/q1ls+CVG/Q2IF+GMlFxm8csh4=;\n b=niKFpXuSO/ovZh7RPLKvQLbXeINk4LDjCOdqYNBvnQh54rdwHaErlxk9\n a2CNNaVOqE8Fvv7Jvv4wkOIe1MXG+xF8b8JvIOvqR4ZcPUHM7NrX7fcwf\n W0kwWKCRe8gj3Jar+2nf/9Ob8XFRvIwcnxwobDWR7YVtO9hNYQl9KouA+\n l9oNAoaAYTs/ri0+ySo8e6/paYcPFDvOWE46GQgchkCayqgz1F8LqiO22\n nl6T4ZpGvdkJYXfUXnfwqoF4FvpQSP9e0/IobgCItV6Gy6bKoYs+eSBpW\n bHeA6HHm4bWhWkQteYM5Uzc+08EjlGjFkc/4rXuOC7GARuUbNpwsDg158 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10362\"; a=\"273713773\"", "E=Sophos;i=\"5.91,262,1647327600\"; d=\"scan'208\";a=\"273713773\"", "E=Sophos;i=\"5.91,262,1647327600\"; d=\"scan'208\";a=\"605009348\"" ], "From": "Jiale Song <songx.jiale@intel.com>", "To": "dts@dpdk.org", "Cc": "Jiale Song <songx.jiale@intel.com>", "Subject": "[dts] [PATCH V3] tests/userspace_ethtool: add method wait port link\n up and add checklist", "Date": "Mon, 30 May 2022 13:45:26 +0800", "Message-Id": "<20220530054526.292164-1-songx.jiale@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=y", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "fix 4 issue:\n 1.check and wait for the port status of the tester and dut to be up and delete some unnecessary delays.\n 2.700 Series not support port disconnect by tools of linux, add 'I40E_10G-10G_BASE_T_X722'\nand 'I40E_10G-10G_BASE_T_BC'.\n 3.ensure that the dpdk app has exited and rebind the driver.\n 4.the bug of 'IGC-I225_LM' is not fixed, add to checklist.\n\nSigned-off-by: Jiale Song <songx.jiale@intel.com>\n---\n conf/test_case_checklist.json | 7 +++---\n tests/TestSuite_userspace_ethtool.py | 34 ++++++++++++++++++----------\n 2 files changed, 26 insertions(+), 15 deletions(-)", "diff": "diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json\nindex 053841ce..c106abfe 100644\n--- a/conf/test_case_checklist.json\n+++ b/conf/test_case_checklist.json\n@@ -2131,13 +2131,14 @@\n \"I40E_10G-SFP_X722\",\n \"I40E_10G-10G_BASE_T_X722\",\n \"IAVF_10G-X722_VF\",\n- \"I40E_10G-10G_BASE_T_BC\"\n+ \"I40E_10G-10G_BASE_T_BC\",\n+ \"IGC-I225_LM\"\n ],\n \"Target\": [\n \"ALL\"\n ],\n- \"Bug ID\": \"\",\n- \"Comments\": \"Know dpdk issue, DPDK-2513\"\n+ \"Bug ID\": \"DPDK-2513, DPDK-30123\",\n+ \"Comments\": \"i40e and igc not suport this case\"\n }\n ],\n \"multicast_mode\": [\ndiff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py\nindex adbba999..9f0bd8a8 100644\n--- a/tests/TestSuite_userspace_ethtool.py\n+++ b/tests/TestSuite_userspace_ethtool.py\n@@ -28,7 +28,7 @@ class TestUserspaceEthtool(TestCase):\n \"\"\"\n self.ports = self.dut.get_ports()\n self.verify(len(self.ports) >= 2, \"No ports found for \" + self.nic)\n-\n+ self.other_700_nic = [\"I40E_10G-10G_BASE_T_X722\", \"I40E_10G-10G_BASE_T_BC\"]\n # build sample app\n out = self.dut.build_dpdk_apps(\"examples/ethtool\")\n self.verify(\"Error\" not in out, \"compilation error 1\")\n@@ -263,18 +263,25 @@ class TestUserspaceEthtool(TestCase):\n portinfo[\"net_dev\"].bind_driver(portinfo[\"ori_driver\"])\n \n self.dut.send_expect(self.cmd, \"EthApp>\", 60)\n+ for port in self.ports:\n+ tester_port = self.tester.get_local_port(port)\n+ intf = self.tester.get_interface(tester_port)\n+ self.tester.is_interface_up(intf)\n # ethtool doesn't support port disconnect by tools of linux\n # only detect physical link disconnect status\n verify_pass = True\n verify_msg = \"\"\n- if not (self.is_eth_series_nic(700) or self.is_eth_series_nic(800)):\n+ if not (\n+ self.is_eth_series_nic(700)\n+ or self.other_700_nic\n+ or self.is_eth_series_nic(800)\n+ ):\n # check link status dump function\n for port in self.ports:\n tester_port = self.tester.get_local_port(port)\n intf = self.tester.get_interface(tester_port)\n self.tester.send_expect(\"ip link set dev %s down\" % intf, \"# \")\n- # wait for link stable\n- time.sleep(5)\n+ self.tester.is_interface_down(intf)\n \n out = self.dut.send_expect(\"link\", \"EthApp>\", 60)\n link_pattern = r\"Port (\\d+): (.*)\"\n@@ -299,8 +306,7 @@ class TestUserspaceEthtool(TestCase):\n tester_port = self.tester.get_local_port(port)\n intf = self.tester.get_interface(tester_port)\n self.tester.send_expect(\"ip link set dev %s up\" % intf, \"# \")\n- # wait for link stable\n- time.sleep(5)\n+ self.tester.is_interface_up(intf)\n \n # check port stats function\n pkt = Packet(pkt_type=\"UDP\")\n@@ -447,12 +453,13 @@ class TestUserspaceEthtool(TestCase):\n )\n pkt = Packet(pkt_type=\"UDP\")\n tester_port = self.tester.get_local_port(port)\n+ intf = self.tester.get_interface(tester_port)\n+ self.tester.is_interface_up(intf)\n self.verify(\n self.ethapp_check_link_status(index, \"Up\") == True,\n \"Fail to Open port{}\".format(index),\n )\n-\n- intf = self.tester.get_interface(tester_port)\n+ time.sleep(1)\n pkt.send_pkt(self.tester, tx_port=intf, count=4)\n rx_pkts, tx_pkts = self.strip_portstats(index)\n self.verify(\n@@ -532,6 +539,7 @@ class TestUserspaceEthtool(TestCase):\n pkt = Packet(pkt_type=\"UDP\")\n tester_port = self.tester.get_local_port(port)\n intf = self.tester.get_interface(tester_port)\n+ self.tester.is_interface_up(intf)\n pkt.send_pkt(self.tester, tx_port=intf, count=4)\n rx_pkts, tx_pkts = self.strip_portstats(index)\n self.verify(rx_pkts == ori_rx_pkts, \"Failed to stop port\")\n@@ -575,7 +583,6 @@ class TestUserspaceEthtool(TestCase):\n # Intel® Ethernet 800 Series should stop port before set mtu\n if self.nic in [\"ICE_25G-E810C_SFP\", \"ICE_100G-E810C_QSFP\"]:\n self.dut.send_expect(\"stop %s\" % index, \"EthApp>\")\n-\n # The mtu threshold is 2022,When it is greater than 2022, the open/stop port is required.\n if mtu > mtu_threshold:\n if self.nic in [\n@@ -592,7 +599,11 @@ class TestUserspaceEthtool(TestCase):\n if self.nic in [\"ICE_25G-E810C_SFP\", \"ICE_100G-E810C_QSFP\"]:\n self.dut.send_expect(\"open %s\" % index, \"EthApp>\")\n \n- time.sleep(5)\n+ self.tester.is_interface_up(intf)\n+ self.verify(\n+ self.ethapp_check_link_status(index, \"Up\") == True,\n+ \"Fail to Open port{}\".format(index),\n+ )\n ori_rx_pkts, _ = self.strip_portstats(index)\n pkt_size = mtu + HEADER_SIZE[\"eth\"] + offset\n pkt = Packet(pkt_type=\"UDP\", pkt_len=pkt_size)\n@@ -677,9 +688,8 @@ class TestUserspaceEthtool(TestCase):\n \"\"\"\n Run after each test case.\n \"\"\"\n- self.dut.bind_interfaces_linux(self.drivername)\n self.dut.kill_all()\n- pass\n+ self.dut.bind_interfaces_linux(self.drivername)\n \n def tear_down_all(self):\n \"\"\"\n", "prefixes": [ "V3" ] }