Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111965/?format=api
{ "id": 111965, "url": "http://patches.dpdk.org/api/patches/111965/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220527064244.10224-1-usman.tanveer@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220527064244.10224-1-usman.tanveer@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220527064244.10224-1-usman.tanveer@emumba.com", "date": "2022-05-27T06:42:44", "name": "ethtool: remove a redundant call to rte_eth_dev_stop()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "72c91de0a43d69ee7449a378779628e62936f978", "submitter": { "id": 2541, "url": "http://patches.dpdk.org/api/people/2541/?format=api", "name": "Usman Tanveer", "email": "usman.tanveer@emumba.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220527064244.10224-1-usman.tanveer@emumba.com/mbox/", "series": [ { "id": 23207, "url": "http://patches.dpdk.org/api/series/23207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23207", "date": "2022-05-27T06:42:44", "name": "ethtool: remove a redundant call to rte_eth_dev_stop()", "version": 1, "mbox": "http://patches.dpdk.org/series/23207/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111965/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/111965/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD63EA055F;\n\tFri, 27 May 2022 08:42:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5DA1C40E5A;\n\tFri, 27 May 2022 08:42:51 +0200 (CEST)", "from mail-ed1-f45.google.com (mail-ed1-f45.google.com\n [209.85.208.45]) by mails.dpdk.org (Postfix) with ESMTP id 26F8840E50\n for <dev@dpdk.org>; Fri, 27 May 2022 08:42:50 +0200 (CEST)", "by mail-ed1-f45.google.com with SMTP id v15so1844209edl.9\n for <dev@dpdk.org>; Thu, 26 May 2022 23:42:50 -0700 (PDT)", "from localhost.localdomain ([182.191.83.208])\n by smtp.gmail.com with ESMTPSA id\n a9-20020a50c309000000b00428a42815aasm1721094edb.0.2022.05.26.23.42.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 May 2022 23:42:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=JNtmd/qjJ01u7BzMnfGGGOWFO/F+yu3QDQkOgCFTkO4=;\n b=m1BL0w89ypr/i7vMknTDwWIMqb8izARiOOjd3Ep3ZJ9CKpEv5djTOwz/JdD7er3LCS\n ZxjrYGCgoOQ8YIqYPDXAKj/lLtND7n2pvxqGjO7TJouddS9sfsKwy4bhopd9UrEy0L5x\n RJ1unEaAdagODgoLwt/GgKarK6pLecw9HP+iSfHsoQyoqZpcpgSxK7p0VeEB/6UE8Duz\n WStrH72CYfEl0k6MfINAFo30Tj54tGTdLIuV+2ZCK8wBblBnCJWyrJbyKbrZl7SWWCWa\n S8dyKx8kMhRNgE2AlJpph3Qh0mOl16OyS8EC0+5+OxXWntx6kSso9bvp7hdD2WkYjIoH\n BxsQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=JNtmd/qjJ01u7BzMnfGGGOWFO/F+yu3QDQkOgCFTkO4=;\n b=kkF/MU+OtvxhwFt0kUu+To7Dh10QDtToP4GbFTUDI2roGQtCGwsUEtoTaBF7j9Xccm\n AdLmOFyVmjf94lCWXZmMibEbBPAmzmuTS2ZFilv+77eqRRfmUvMrQa0QDgAIxsGQf+Ep\n JE/esCTb0YWybNlPvgbrxWgJSW/fARHf4pUhIplIbHeBRuwZ1jx6B5xshO53cKVk3Ip/\n FkJRIAhMt7k1CJ6+TGEHee2b2lrtPqXLDuutn/LEyvwnPvEnQQQvxfXbtSPC/frH8/+c\n LeoCJTzSa5DpD3moLobta2LE14skqw+jwJ2qNU57q/Uh8DKzbn7Si4XbhdSD0oqE7q6A\n wUVA==", "X-Gm-Message-State": "AOAM5337NPnfgdNNl1etUkvBoNTwr4I9cErwuIZMrbgup8NdeUKw4xm/\n HUNjKpO7Z3OC3fGalmrJOSvxYVuGalO8Cw==", "X-Google-Smtp-Source": "\n ABdhPJwV5cMicXEhjlJqcNdaSexZlbIDp7bYxWqzTqQoCHqAVFlR/sDdnse5B2RTM3iFDu42O82REw==", "X-Received": "by 2002:a05:6402:5c9:b0:420:aac6:257b with SMTP id\n n9-20020a05640205c900b00420aac6257bmr42744487edx.128.1653633769836;\n Thu, 26 May 2022 23:42:49 -0700 (PDT)", "From": "Usman Tanveer <usman.tanveer@emumba.com>", "To": "dev@dpdk.org", "Cc": "Usman Tanveer <usman.tanveer@emumba.com>", "Subject": "[PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()", "Date": "Fri, 27 May 2022 11:42:44 +0500", "Message-Id": "<20220527064244.10224-1-usman.tanveer@emumba.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is a call to rte_eth_dev_stop() in rte_ethtool_net_open()\ndue to which user gets misleading message upon first open/start call.\nIt says that the\ndevice is already stopped, which should not be the case. This patch\nremoves rte_eth_dev_stop() from rte_ethtool_net_open().\n\nSigned-off-by: Usman Tanveer <usman.tanveer@emumba.com>\n---\n examples/ethtool/lib/rte_ethtool.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c\nindex ffaad96498..0a000d0a7b 100644\n--- a/examples/ethtool/lib/rte_ethtool.c\n+++ b/examples/ethtool/lib/rte_ethtool.c\n@@ -297,12 +297,6 @@ rte_ethtool_set_pauseparam(uint16_t port_id,\n int\n rte_ethtool_net_open(uint16_t port_id)\n {\n-\tint ret;\n-\n-\tret = rte_eth_dev_stop(port_id);\n-\tif (ret != 0)\n-\t\treturn ret;\n-\n \treturn rte_eth_dev_start(port_id);\n }\n \n", "prefixes": [] }