Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11196/?format=api
{ "id": 11196, "url": "http://patches.dpdk.org/api/patches/11196/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1457426981-22571-1-git-send-email-zhe.tao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1457426981-22571-1-git-send-email-zhe.tao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1457426981-22571-1-git-send-email-zhe.tao@intel.com", "date": "2016-03-08T08:49:41", "name": "[dpdk-dev,v2] ixgbe: fix ixgbevf RX/TX function assignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1ca5a2fad5a7aca1caf45bb0703a4871904d4333", "submitter": { "id": 276, "url": "http://patches.dpdk.org/api/people/276/?format=api", "name": "Zhe Tao", "email": "zhe.tao@intel.com" }, "delegate": { "id": 10, "url": "http://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1457426981-22571-1-git-send-email-zhe.tao@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/11196/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/11196/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 45F13377E;\n\tTue, 8 Mar 2016 09:49:53 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 4B1A3376E\n\tfor <dev@dpdk.org>; Tue, 8 Mar 2016 09:49:51 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP; 08 Mar 2016 00:49:51 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 08 Mar 2016 00:49:49 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u288nlMG006416;\n\tTue, 8 Mar 2016 16:49:47 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u288nhpN022695; Tue, 8 Mar 2016 16:49:45 +0800", "(from zhetao@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u288nhme022691; \n\tTue, 8 Mar 2016 16:49:43 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,556,1449561600\"; d=\"scan'208\";a=\"760080466\"", "From": "Zhe Tao <zhe.tao@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 8 Mar 2016 16:49:41 +0800", "Message-Id": "<1457426981-22571-1-git-send-email-zhe.tao@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1456672050-21115-1-git-send-email-zhe.tao@intel.com>", "References": "<1456672050-21115-1-git-send-email-zhe.tao@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] ixgbe: fix ixgbevf RX/TX function assignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For the secondary process of DPDK to initialize ixgbevf, it will always\nuse the simple RX function or LRO RX function, and this behavior is not\nthe same RX/TX function selection logic as it is for the primary process,\nso use the ixgbe_set_tx_function and ixgbe_set_rx_function to select the\nRX/TX function when secondary process call the init function for eth dev. \n\nFixes: abf7275bbaa2918 (ixgbe: move to drivers/net/)\n\nV2:add fixes line\n\nSigned-off-by: Zhe Tao <zhe.tao@intel.com>\n\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 3e6fe86..0f9d048 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1278,8 +1278,21 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \t * has already done this work. Only check we don't need a different\n \t * RX function */\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY){\n-\t\tif (eth_dev->data->scattered_rx)\n-\t\t\teth_dev->rx_pkt_burst = ixgbe_recv_pkts_lro_single_alloc;\n+\t\tstruct ixgbe_tx_queue *txq;\n+\t\t/* TX queue function in primary, set by last queue initialized\n+\t\t * Tx queue may not initialized by primary process\n+\t\t */\n+\t\tif (eth_dev->data->tx_queues) {\n+\t\t\ttxq = eth_dev->data->tx_queues[eth_dev->data->nb_tx_queues-1];\n+\t\t\tixgbe_set_tx_function(eth_dev, txq);\n+\t\t} else {\n+\t\t\t/* Use default TX function if we get here */\n+\t\t\tPMD_INIT_LOG(NOTICE, \"No TX queues configured yet. \"\n+\t\t\t\t\t \"Using default TX function.\");\n+\t\t}\n+\n+\t\tixgbe_set_rx_function(eth_dev);\n+\n \t\treturn 0;\n \t}\n \n", "prefixes": [ "dpdk-dev", "v2" ] }