Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111843/?format=api
{ "id": 111843, "url": "http://patches.dpdk.org/api/patches/111843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220525171231.200035-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220525171231.200035-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220525171231.200035-4-stephen@networkplumber.org", "date": "2022-05-25T17:12:30", "name": "[v3,3/3] rte_pie: fix incorrect floating point math", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5a99ca98f7d15f98d6f2c8653ad7e65f910f0498", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220525171231.200035-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 23161, "url": "http://patches.dpdk.org/api/series/23161/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23161", "date": "2022-05-25T17:12:27", "name": "introduce random floating point function", "version": 3, "mbox": "http://patches.dpdk.org/series/23161/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111843/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/111843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05C27A0555;\n\tWed, 25 May 2022 19:12:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D827E427F9;\n\tWed, 25 May 2022 19:12:41 +0200 (CEST)", "from mail-pj1-f46.google.com (mail-pj1-f46.google.com\n [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id F18DF427F9\n for <dev@dpdk.org>; Wed, 25 May 2022 19:12:40 +0200 (CEST)", "by mail-pj1-f46.google.com with SMTP id\n x2-20020a17090a1f8200b001e07a64c461so2196174pja.4\n for <dev@dpdk.org>; Wed, 25 May 2022 10:12:40 -0700 (PDT)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n s23-20020a170902b19700b001622c377c3esm6139599plr.117.2022.05.25.10.12.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 May 2022 10:12:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=6EbH89RIQ9T1r4Bv5a9z0U19T6cYdGe3OiQ5CK+/Phs=;\n b=RCr+gEb0vfpV5pjkDg5f9YBK0axPKMsiDyrxPbqPZzZc/3E6w5rTusI3yO0pK+j+Y5\n q+qiZLMBgyF4Nx/zTqRAZiHopkB+khOwXx1NfMi+SD2ny/YlPvj8sTxKaTQdaHZA9exe\n Z3LOcUgsO/4Nuj/CXw6TNYxpNSzOGjxeHavwHF3rPDojhZ0MRI5SGx6/kTsDfLoaDHUG\n IDf5DRunlLzLXZYWkcvTEjB+lJSjUwiWB/qBn3F+1+QOeYBZfFryIu5WiGdD39ZXA/Pl\n wFtApy14eHwuhkatAjF5nkiT/YU4Ub6PUuYcnPZrlhsIvohHtllSrgC8W7Q+/JeieMq1\n 37YA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=6EbH89RIQ9T1r4Bv5a9z0U19T6cYdGe3OiQ5CK+/Phs=;\n b=ZdPMGG1LHPA2l983gLkTYliCWmPCfGVZEVgrDmWPgPTbM+sD6jM7v/P8pdOpi3c2G1\n 7tfMZlvAxgPRbfekuR27MXW0dcG8Ge6Ae55tiNKtXKwJ+m1UZYGe6QRRbIZKcO0cdP21\n bstOZrtPyjToPhy2cikH0g4V1YDpScYPOgYipHdT+rB4Mk8h2/+bRwzpK9kIcmaMHjOz\n xJCB/KPV3HngxDQlXXcudyyy+IOSDFzqjGQkblFfIN9AW7+zX+fFS0ojW06XVEVzF9Us\n P3sJm3SJ7UjTyQ6V9HHq0ARszZFsimZRJ2YO/6U3l4BjHEECaVNn7mDBIgI8gw05nXQk\n 7ZBA==", "X-Gm-Message-State": "AOAM532uqGMqUcQecJRKxicEtjK+xC2+5MW8W3dZZ/N2XNcBUVK0+Aem\n lPZJz5AM5+ffX72UgujM1UTTfV33L3W9cg==", "X-Google-Smtp-Source": "\n ABdhPJzZzoJ+E7NkkZeeViJJ2+SMaYAtgtOgWLdWF7CMxZCUvINbrhIxAMpsXEnTRPz8qHg+omJfuQ==", "X-Received": "by 2002:a17:90a:a096:b0:1df:58d7:5b20 with SMTP id\n r22-20020a17090aa09600b001df58d75b20mr11462435pjp.212.1653498758772;\n Wed, 25 May 2022 10:12:38 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n wojciechx.liguzinski@intel.com,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>", "Subject": "[PATCH v3 3/3] rte_pie: fix incorrect floating point math", "Date": "Wed, 25 May 2022 10:12:30 -0700", "Message-Id": "<20220525171231.200035-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220525171231.200035-1-stephen@networkplumber.org>", "References": "<20220524184623.480646-1-stephen@networkplumber.org>\n <20220525171231.200035-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function rte_pie_drop was attempting to do a random probability\ndrop, but because of incorrect usage of fixed point divide\nit would always return 1.\n\nChange to use new rte_drand() instead.\n\nFixes: 44c730b0e379 (\"sched: add PIE based congestion management\")\nCc: wojciechx.liguzinski@intel.com\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/sched/rte_pie.h | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h\nindex 3e2c1ef46721..528f2ea878e8 100644\n--- a/lib/sched/rte_pie.h\n+++ b/lib/sched/rte_pie.h\n@@ -217,7 +217,6 @@ __rte_experimental\n _rte_pie_drop(const struct rte_pie_config *pie_cfg,\n \tstruct rte_pie *pie)\n {\n-\tuint64_t rand_value;\n \tuint64_t qdelay = pie_cfg->qdelay_ref / 2;\n \n \t/* PIE is active but the queue is not congested: return 0 */\n@@ -240,9 +239,7 @@ _rte_pie_drop(const struct rte_pie_config *pie_cfg,\n \tif (pie->accu_prob >= 8.5)\n \t\treturn 1;\n \n-\trand_value = rte_rand()/RTE_RAND_MAX;\n-\n-\tif ((double)rand_value < pie->drop_prob) {\n+\tif (rte_drand() < pie->drop_prob) {\n \t\tpie->accu_prob = 0;\n \t\treturn 1;\n \t}\n", "prefixes": [ "v3", "3/3" ] }