Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111654/?format=api
{ "id": 111654, "url": "http://patches.dpdk.org/api/patches/111654/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1653341116-50325-5-git-send-email-nicolas.chautru@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1653341116-50325-5-git-send-email-nicolas.chautru@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1653341116-50325-5-git-send-email-nicolas.chautru@intel.com", "date": "2022-05-23T21:25:15", "name": "[v4,4/5] baseband/acc100: modify validation code for ACC101", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bb478a6cbd4ec0a3b32b90755ce442f91dfa9ab1", "submitter": { "id": 1314, "url": "http://patches.dpdk.org/api/people/1314/?format=api", "name": "Chautru, Nicolas", "email": "nicolas.chautru@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1653341116-50325-5-git-send-email-nicolas.chautru@intel.com/mbox/", "series": [ { "id": 23103, "url": "http://patches.dpdk.org/api/series/23103/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23103", "date": "2022-05-23T21:25:13", "name": "drivers/baseband: PMD to support ACC100/ACC101 devices", "version": 4, "mbox": "http://patches.dpdk.org/series/23103/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111654/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111654/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6650FA00C2;\n\tMon, 23 May 2022 23:34:30 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0949B42B71;\n\tMon, 23 May 2022 23:34:09 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id D912E40E78\n for <dev@dpdk.org>; Mon, 23 May 2022 23:34:04 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 May 2022 14:33:58 -0700", "from skx-5gnr-sc12-4.sc.intel.com ([172.25.69.210])\n by fmsmga008.fm.intel.com with ESMTP; 23 May 2022 14:33:57 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653341645; x=1684877645;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=LQsoFplyZzmChXjTh5SC2vZcYgzQ6XpOTPFhvj/oNdY=;\n b=XQprDPV7W1B3yQtieisqYKuI84Zr/BgJ/+uuS80fWzyLGjIYX0La0CkK\n UbYt223WJ/qyUaQlpOUbSegy9i76L0YKFsvoQPv7sqwoXFVeiHK//2kC1\n JaK2QJqkrasIz3SykJkFBpnhhTcgLV5e91/oUBuy3X72ZjPwOKseUzSD1\n UUAMVeeHMsomg865XXeIFguauYip9Emd1c7Iv7Gs+uGtKKVXfjw10mSi4\n Vxkj6iZAUrt9mT0R/X3X56epz795oxyeff94gT5TWfqhjGJ0ft0W2DCAa\n tviU/rziIJG2gsn5o9HFWEzXgyyHZ/x6WxPw60EihnlqGaeovABqzygrY A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10356\"; a=\"272183540\"", "E=Sophos;i=\"5.91,247,1647327600\"; d=\"scan'208\";a=\"272183540\"", "E=Sophos;i=\"5.91,247,1647327600\"; d=\"scan'208\";a=\"629591641\"" ], "X-ExtLoop1": "1", "From": "Nicolas Chautru <nicolas.chautru@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "thomas@monjalon.net, ray.kinsella@intel.com, bruce.richardson@intel.com,\n hemant.agrawal@nxp.com, hernan.vargas@intel.com, david.marchand@redhat.com,\n Nicolas Chautru <nicolas.chautru@intel.com>", "Subject": "[PATCH v4 4/5] baseband/acc100: modify validation code for ACC101", "Date": "Mon, 23 May 2022 14:25:15 -0700", "Message-Id": "<1653341116-50325-5-git-send-email-nicolas.chautru@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1653341116-50325-1-git-send-email-nicolas.chautru@intel.com>", "References": "<1651083423-33202-1-git-send-email-nicolas.chautru@intel.com>\n <1653341116-50325-1-git-send-email-nicolas.chautru@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The validation requirement is different for the two\ndevices.\n\nSigned-off-by: Nicolas Chautru <nicolas.chautru@intel.com>\n---\n drivers/baseband/acc100/rte_acc100_pmd.c | 40 ++++++++++++++++++++++----------\n 1 file changed, 28 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c\nindex 5f422da..65b8fac 100644\n--- a/drivers/baseband/acc100/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc100/rte_acc100_pmd.c\n@@ -1295,6 +1295,14 @@\n \treturn (q->d->device_variant == ACC100_VARIANT);\n }\n \n+#ifdef RTE_LIBRTE_BBDEV_DEBUG\n+static inline bool\n+validate_op_required(struct acc100_queue *q)\n+{\n+\treturn is_acc100(q);\n+}\n+#endif\n+\n /* Fill in a frame control word for LDPC decoding. */\n static inline void\n acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw,\n@@ -2182,8 +2190,10 @@ static inline uint32_t hq_index(uint32_t offset)\n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n /* Validates turbo encoder parameters */\n static inline int\n-validate_enc_op(struct rte_bbdev_enc_op *op)\n+validate_enc_op(struct rte_bbdev_enc_op *op, struct acc100_queue *q)\n {\n+\tif (!validate_op_required(q))\n+\t\treturn 0;\n \tstruct rte_bbdev_op_turbo_enc *turbo_enc = &op->turbo_enc;\n \tstruct rte_bbdev_op_enc_turbo_cb_params *cb = NULL;\n \tstruct rte_bbdev_op_enc_turbo_tb_params *tb = NULL;\n@@ -2320,8 +2330,10 @@ static inline uint32_t hq_index(uint32_t offset)\n }\n /* Validates LDPC encoder parameters */\n static inline int\n-validate_ldpc_enc_op(struct rte_bbdev_enc_op *op)\n+validate_ldpc_enc_op(struct rte_bbdev_enc_op *op, struct acc100_queue *q)\n {\n+\tif (!validate_op_required(q))\n+\t\treturn 0;\n \tstruct rte_bbdev_op_ldpc_enc *ldpc_enc = &op->ldpc_enc;\n \n \tif (op->mempool == NULL) {\n@@ -2373,8 +2385,10 @@ static inline uint32_t hq_index(uint32_t offset)\n \n /* Validates LDPC decoder parameters */\n static inline int\n-validate_ldpc_dec_op(struct rte_bbdev_dec_op *op)\n+validate_ldpc_dec_op(struct rte_bbdev_dec_op *op, struct acc100_queue *q)\n {\n+\tif (!validate_op_required(q))\n+\t\treturn 0;\n \tstruct rte_bbdev_op_ldpc_dec *ldpc_dec = &op->ldpc_dec;\n \n \tif (op->mempool == NULL) {\n@@ -2429,7 +2443,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_enc_op(op) == -1) {\n+\tif (validate_enc_op(op, q) == -1) {\n \t\trte_bbdev_log(ERR, \"Turbo encoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n@@ -2483,7 +2497,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_ldpc_enc_op(ops[0]) == -1) {\n+\tif (validate_ldpc_enc_op(ops[0], q) == -1) {\n \t\trte_bbdev_log(ERR, \"LDPC encoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n@@ -2545,7 +2559,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_ldpc_enc_op(op) == -1) {\n+\tif (validate_ldpc_enc_op(op, q) == -1) {\n \t\trte_bbdev_log(ERR, \"LDPC encoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n@@ -2602,7 +2616,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_enc_op(op) == -1) {\n+\tif (validate_enc_op(op, q) == -1) {\n \t\trte_bbdev_log(ERR, \"Turbo encoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n@@ -2675,8 +2689,10 @@ static inline uint32_t hq_index(uint32_t offset)\n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n /* Validates turbo decoder parameters */\n static inline int\n-validate_dec_op(struct rte_bbdev_dec_op *op)\n+validate_dec_op(struct rte_bbdev_dec_op *op, struct acc100_queue *q)\n {\n+\tif (!validate_op_required(q))\n+\t\treturn 0;\n \tstruct rte_bbdev_op_turbo_dec *turbo_dec = &op->turbo_dec;\n \tstruct rte_bbdev_op_dec_turbo_cb_params *cb = NULL;\n \tstruct rte_bbdev_op_dec_turbo_tb_params *tb = NULL;\n@@ -2822,7 +2838,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_dec_op(op) == -1) {\n+\tif (validate_dec_op(op, q) == -1) {\n \t\trte_bbdev_log(ERR, \"Turbo decoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n@@ -3047,7 +3063,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_ldpc_dec_op(op) == -1) {\n+\tif (validate_ldpc_dec_op(op, q) == -1) {\n \t\trte_bbdev_log(ERR, \"LDPC decoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n@@ -3151,7 +3167,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_ldpc_dec_op(op) == -1) {\n+\tif (validate_ldpc_dec_op(op, q) == -1) {\n \t\trte_bbdev_log(ERR, \"LDPC decoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n@@ -3241,7 +3257,7 @@ static inline uint32_t hq_index(uint32_t offset)\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \t/* Validate op structure */\n-\tif (validate_dec_op(op) == -1) {\n+\tif (validate_dec_op(op, q) == -1) {\n \t\trte_bbdev_log(ERR, \"Turbo decoder validation failed\");\n \t\treturn -EINVAL;\n \t}\n", "prefixes": [ "v4", "4/5" ] }