Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 111606,
    "url": "http://patches.dpdk.org/api/patches/111606/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220523095954.3181-2-pbhagavatula@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220523095954.3181-2-pbhagavatula@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220523095954.3181-2-pbhagavatula@marvell.com",
    "date": "2022-05-23T09:59:54",
    "name": "[2/2] examples: use mempool cache for vector pool",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "929b5a8bb2a5674db5478ed0c60537ef173d5bf5",
    "submitter": {
        "id": 1183,
        "url": "http://patches.dpdk.org/api/people/1183/?format=api",
        "name": "Pavan Nikhilesh Bhagavatula",
        "email": "pbhagavatula@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220523095954.3181-2-pbhagavatula@marvell.com/mbox/",
    "series": [
        {
            "id": 23090,
            "url": "http://patches.dpdk.org/api/series/23090/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23090",
            "date": "2022-05-23T09:59:53",
            "name": "[1/2] app/eventdev: use mempool cache for vector pool",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/23090/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/111606/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/111606/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5324DA04FD;\n\tMon, 23 May 2022 12:00:16 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B47474161A;\n\tMon, 23 May 2022 12:00:14 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id A25EB41611\n for <dev@dpdk.org>; Mon, 23 May 2022 12:00:13 +0200 (CEST)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 24MLjCUP017461;\n Mon, 23 May 2022 03:00:12 -0700",
            "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g6ykkw9sh-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 23 May 2022 03:00:12 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 23 May 2022 03:00:10 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 23 May 2022 03:00:10 -0700",
            "from MININT-80QBFE8.corp.innovium.com (unknown [10.193.70.72])\n by maili.marvell.com (Postfix) with ESMTP id 6EA9B3F70F9;\n Mon, 23 May 2022 03:00:04 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=5oPtHkCGv/nxbwlKXP3LSFJXMighKHEiZ/ScpiFyKO0=;\n b=Lf07HuPb9mTOZ6vPDO9FQZdQk/LAxfO7ybCU40wkYA+apRGtgGXxLTMmUdK7TRZ1LiJ/\n TTrpp188n1NeSbd4oDwP/xLs8PFQUNlPlxgXAZzutXrc3C2/zI6+28ASmECTUwHbs81Q\n +oICPLE1fTfbJKbzJxf006s8AcLLM+mN74XnMu96JfMIZq+aPF95XPActNJ5KY3wMJir\n OXbAyhbn6oUywZOvGtpJmiTMqRB9bFva+dpQR/qTsy7xxwaW9e8p9tbK2nPX1o3X0f+F\n oVDXkAyOfm74rd0RWBaTs1h9OSrgQOa5NuJtyhcjpNgBUBkAdd5q/7xqPeTnuNA9IXt9 bg==",
        "From": "<pbhagavatula@marvell.com>",
        "To": "<jerinj@marvell.com>, Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal\n <gakhil@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>",
        "CC": "<dev@dpdk.org>",
        "Subject": "[PATCH 2/2] examples: use mempool cache for vector pool",
        "Date": "Mon, 23 May 2022 15:29:54 +0530",
        "Message-ID": "<20220523095954.3181-2-pbhagavatula@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20220523095954.3181-1-pbhagavatula@marvell.com>",
        "References": "<20220523095954.3181-1-pbhagavatula@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "6dARyAO2vV_VbFzE_IQs-B3slkwISq1S",
        "X-Proofpoint-ORIG-GUID": "6dARyAO2vV_VbFzE_IQs-B3slkwISq1S",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514\n definitions=2022-05-23_03,2022-05-20_02,2022-02-23_01",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nUse mempool cache for vector mempool as vectors are freed by the Tx\nroutine, also increase the minimum pool size to 512 to avoid resource\ncontention on Rx.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n examples/ipsec-secgw/event_helper.c | 8 ++++----\n examples/l2fwd-event/main.c         | 4 +++-\n examples/l3fwd/main.c               | 4 +++-\n 3 files changed, 10 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c\nindex 172ab8e716..b36f20a3fd 100644\n--- a/examples/ipsec-secgw/event_helper.c\n+++ b/examples/ipsec-secgw/event_helper.c\n@@ -820,12 +820,12 @@ eh_rx_adapter_configure(struct eventmode_conf *em_conf,\n \t\t\t\t   em_conf->ext_params.vector_size) + 1;\n \t\t\tif (per_port_pool)\n \t\t\t\tnb_elem = nb_ports * nb_elem;\n+\t\t\tnb_elem = RTE_MAX(512U, nb_elem);\n \t\t}\n-\n+\t\tnb_elem += rte_lcore_count() * 32;\n \t\tvector_pool = rte_event_vector_pool_create(\n-\t\t\t\"vector_pool\", nb_elem, 0,\n-\t\t\tem_conf->ext_params.vector_size,\n-\t\t\tsocket_id);\n+\t\t\t\"vector_pool\", nb_elem, 32,\n+\t\t\tem_conf->ext_params.vector_size, socket_id);\n \t\tif (vector_pool == NULL) {\n \t\t\tEH_LOG_ERR(\"failed to create event vector pool\");\n \t\t\treturn -ENOMEM;\ndiff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c\nindex dcc72f3f1e..44303d10c2 100644\n--- a/examples/l2fwd-event/main.c\n+++ b/examples/l2fwd-event/main.c\n@@ -678,8 +678,10 @@ main(int argc, char **argv)\n \n \t\tvec_size = rsrc->evt_vec.size;\n \t\tnb_vec = (nb_mbufs + vec_size - 1) / vec_size;\n+\t\tnb_vec = RTE_MAX(512U, nb_vec);\n+\t\tnb_vec += rte_lcore_count() * 32;\n \t\trsrc->evt_vec_pool = rte_event_vector_pool_create(\n-\t\t\t\"vector_pool\", nb_vec, 0, vec_size, rte_socket_id());\n+\t\t\t\"vector_pool\", nb_vec, 32, vec_size, rte_socket_id());\n \t\tif (rsrc->evt_vec_pool == NULL)\n \t\t\trte_panic(\"Cannot init event vector pool\\n\");\n \t}\ndiff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex a629198223..896a347db3 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -1006,9 +1006,11 @@ init_mem(uint16_t portid, unsigned int nb_mbuf)\n \n \t\t\tnb_vec = (nb_mbuf + evt_rsrc->vector_size - 1) /\n \t\t\t\t evt_rsrc->vector_size;\n+\t\t\tnb_vec = RTE_MAX(512U, nb_vec);\n+\t\t\tnb_vec += rte_lcore_count() * 32;\n \t\t\tsnprintf(s, sizeof(s), \"vector_pool_%d\", portid);\n \t\t\tvector_pool[portid] = rte_event_vector_pool_create(\n-\t\t\t\ts, nb_vec, 0, evt_rsrc->vector_size, socketid);\n+\t\t\t\ts, nb_vec, 32, evt_rsrc->vector_size, socketid);\n \t\t\tif (vector_pool[portid] == NULL)\n \t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t \"Failed to create vector pool for port %d\\n\",\n",
    "prefixes": [
        "2/2"
    ]
}