Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111501/?format=api
{ "id": 111501, "url": "http://patches.dpdk.org/api/patches/111501/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-18-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220520055445.40063-18-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220520055445.40063-18-arkadiuszx.kusztal@intel.com", "date": "2022-05-20T05:54:22", "name": "[17/40] crypto/openssl: move dh type from xform to dh op", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "f92c89a3548f88418ce521114bd956a5f9cc8561", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-18-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23057, "url": "http://patches.dpdk.org/api/series/23057/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23057", "date": "2022-05-20T05:54:05", "name": "cryptodev: rsa, dh, ecdh changes", "version": 1, "mbox": "http://patches.dpdk.org/series/23057/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111501/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111501/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33277A0503;\n\tFri, 20 May 2022 09:04:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E890742BCD;\n\tFri, 20 May 2022 09:03:17 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id B5C0B42BB6\n for <dev@dpdk.org>; Fri, 20 May 2022 09:03:14 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 May 2022 00:03:14 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:03:12 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653030195; x=1684566195;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=EIN9OEV0pUyD59FpNGtDifLvJczKeUyYgVO/xkIlh/8=;\n b=lZpokn5oKq44v9WNXs93PPKviKoEzGWmR9osIlkCjv7CRxZPabdkac8Q\n hK00P9rqVaeNZHLTSXIX7g2DXkijBP2M0plnBpDoLWvP0IOc7qN5vZxk2\n cxTdUVm8P525rNrqJLTPApA38D/cJ79TFjR0YRjcZ4EDGsPaADVXgvZUT\n jCqoJSAS5BTKHL6tB82eCcfg/sSza6zXOJIcXu2o/09R1Q7OWO1+hj8al\n H9nfE7uP08yQnReZyfalnIBW/9zYOPPVF/2PikL/EnnBdoszb15HfruBQ\n /Tp4KdaEI/KUWj0+9C+olZUp+EbtOd8VbOGSoXr4yyULkweTcKrNkgbCe w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10352\"; a=\"333140365\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"333140365\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"599058338\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH 17/40] crypto/openssl: move dh type from xform to dh op", "Date": "Fri, 20 May 2022 06:54:22 +0100", "Message-Id": "<20220520055445.40063-18-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "References": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Moved dh operation type to dh operation struct.\nThis commit reflects changes to the asymmetric crypto API.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/crypto/openssl/rte_openssl_pmd.c | 15 ++++++---------\n drivers/crypto/openssl/rte_openssl_pmd_ops.c | 1 -\n 2 files changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex 2a3930df0a..c4ac767052 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -1692,12 +1692,12 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \t\tstruct openssl_asym_session *sess)\n {\n \tstruct rte_crypto_dh_op_param *op = &cop->asym->dh;\n+\tstruct rte_crypto_asym_op *asym_op = cop->asym;\n \tDH *dh_key = sess->u.dh.dh_key;\n \tBIGNUM *priv_key = NULL;\n \tint ret = 0;\n \n-\tif (sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE)) {\n+\tif (asym_op->dh.op_type == RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE) {\n \t\t/* compute shared secret using peer public key\n \t\t * and current private key\n \t\t * shared secret = peer_key ^ priv_key mod p\n@@ -1753,10 +1753,8 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \t * if user provides private key,\n \t * then first set DH with user provided private key\n \t */\n-\tif ((sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE)) &&\n-\t\t\t!(sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE))) {\n+\tif (asym_op->dh.op_type == RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE &&\n+\t\t\top->priv_key.data) {\n \t\t/* generate public key using user-provided private key\n \t\t * pub_key = g ^ priv_key mod p\n \t\t */\n@@ -1790,7 +1788,7 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \t\treturn 0;\n \t}\n \n-\tif (sess->u.dh.key_op & (1 << RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE)) {\n+\tif (asym_op->dh.op_type == RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE) {\n \t\tconst BIGNUM *pub_key = NULL;\n \n \t\tOPENSSL_LOG(DEBUG, \"%s:%d update public key\\n\",\n@@ -1804,8 +1802,7 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \t\t\t\top->pub_key.data);\n \t}\n \n-\tif (sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE)) {\n+\tif (asym_op->dh.op_type == RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE) {\n \t\tconst BIGNUM *priv_key = NULL;\n \n \t\tOPENSSL_LOG(DEBUG, \"%s:%d updated priv key\\n\",\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\nindex a1be96bf1d..737ec5de80 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n@@ -999,7 +999,6 @@ static int openssl_set_asym_session_parameters(\n \t\t * DH Priv key generate, or both\n \t\t * public and private key generate\n \t\t */\n-\t\tasym_session->u.dh.key_op = (1 << xform->dh.type);\n \t\tasym_session->u.dh.dh_key = dh;\n \t\tasym_session->xfrm_type = RTE_CRYPTO_ASYM_XFORM_DH;\n \t\tbreak;\n", "prefixes": [ "17/40" ] }