Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111490/?format=api
{ "id": 111490, "url": "http://patches.dpdk.org/api/patches/111490/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-7-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220520055445.40063-7-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220520055445.40063-7-arkadiuszx.kusztal@intel.com", "date": "2022-05-20T05:54:11", "name": "[06/40] cryptodev: separate key exchange operation enum", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2f7a8de9047823b83011777a68b2b55198163c23", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-7-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23057, "url": "http://patches.dpdk.org/api/series/23057/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23057", "date": "2022-05-20T05:54:05", "name": "cryptodev: rsa, dh, ecdh changes", "version": 1, "mbox": "http://patches.dpdk.org/series/23057/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111490/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111490/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EDB4AA0503;\n\tFri, 20 May 2022 09:03:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8E90B42B9B;\n\tFri, 20 May 2022 09:02:50 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id CAFB542B99\n for <dev@dpdk.org>; Fri, 20 May 2022 09:02:48 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 May 2022 00:02:48 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:02:46 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653030169; x=1684566169;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=0MVxKTbGRv+3wcNuXw0UmjZxfMdKGmU8a4u8/Af0uUA=;\n b=g2I896QgicZb8Dmfj1Fa49Mc1v76UXe2wcireLxwdBd6ZEH893ISEM4T\n osrAsp7LMOUe5XSv+iKgfp2IycU7rIyc1ZTu4QE4jaGzvviXYA+1uFpEw\n KtCZeEWiup5lfGSiHgwk/f5jq84qg5JydhqWAjzL4ZNY7NwOjPKadEfdT\n N3svgaf/7Wd6SqVPantWyTwSblR6vcJccanyUiBe1kG0tCgcKVrj0kHcg\n nwOSFQKLeh6QQZ4SH07GbVcM8JqJitbjuI+aPkUwezL3AKrzTMiaITzX8\n FDgPwE6d7VTL3NU6LrCrCOwgbKHMGA3H2u9T9NA9JYWI3pDCRLXUJxyod A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10352\"; a=\"333140237\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"333140237\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"599058120\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH 06/40] cryptodev: separate key exchange operation enum", "Date": "Fri, 20 May 2022 06:54:11 +0100", "Message-Id": "<20220520055445.40063-7-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "References": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- separated key exchange enum.\nKey exchange and asymmetric crypto operations like signatures,\nencryption/decryption should not share same operation enum as\nits use cases are unrelated and mutually exclusive.\nTherefore op_type was separate into:\n1) operation type\n2) key exchange operation type\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n lib/cryptodev/rte_crypto_asym.h | 24 +++++++++++++++++-------\n lib/cryptodev/rte_cryptodev.c | 14 ++++++++++----\n 2 files changed, 27 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex 0251e8caae..0fc9f49b87 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -33,6 +33,10 @@ struct rte_cryptodev_asym_session;\n extern const char *\n rte_crypto_asym_xform_strings[];\n \n+/** asym key exchange operation type name strings */\n+extern const char *\n+rte_crypto_asym_ke_strings[];\n+\n /** asym operations type name strings */\n extern const char *\n rte_crypto_asym_op_strings[];\n@@ -94,12 +98,18 @@ enum rte_crypto_asym_op_type {\n \t/**< Signature Generation operation */\n \tRTE_CRYPTO_ASYM_OP_VERIFY,\n \t/**< Signature Verification operation */\n-\tRTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE,\n-\t/**< DH Private Key generation operation */\n-\tRTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE,\n-\t/**< DH Public Key generation operation */\n-\tRTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE\n-\t/**< DH Shared Secret compute operation */\n+};\n+\n+/**\n+ * Asymmetric crypto key exchange operation type\n+ */\n+enum rte_crypto_asym_ke_type {\n+\tRTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE,\n+\t/**< Private Key generation operation */\n+\tRTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE,\n+\t/**< Public Key generation operation */\n+\tRTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE\n+\t/**< Shared Secret compute operation */\n };\n \n /**\n@@ -239,7 +249,7 @@ struct rte_crypto_modinv_xform {\n *\n */\n struct rte_crypto_dh_xform {\n-\tenum rte_crypto_asym_op_type type;\n+\tenum rte_crypto_asym_ke_type type;\n \t/**< Setup xform for key generate or shared secret compute */\n \trte_crypto_uint p;\n \t/**< Prime modulus data */\ndiff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex 691625bd04..af58f49d07 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -176,10 +176,16 @@ const char *rte_crypto_asym_op_strings[] = {\n \t[RTE_CRYPTO_ASYM_OP_ENCRYPT]\t= \"encrypt\",\n \t[RTE_CRYPTO_ASYM_OP_DECRYPT]\t= \"decrypt\",\n \t[RTE_CRYPTO_ASYM_OP_SIGN]\t= \"sign\",\n-\t[RTE_CRYPTO_ASYM_OP_VERIFY]\t= \"verify\",\n-\t[RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE]\t= \"priv_key_generate\",\n-\t[RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE] = \"pub_key_generate\",\n-\t[RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE] = \"sharedsecret_compute\",\n+\t[RTE_CRYPTO_ASYM_OP_VERIFY]\t= \"verify\"\n+};\n+\n+/**\n+ * Asymmetric crypto key exchange operation strings identifiers.\n+ */\n+const char *rte_crypto_asym_ke_strings[] = {\n+\t[RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE] = \"priv_key_generate\",\n+\t[RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE] = \"pub_key_generate\",\n+\t[RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE] = \"sharedsecret_compute\"\n };\n \n /**\n", "prefixes": [ "06/40" ] }