Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111300/?format=api
{ "id": 111300, "url": "http://patches.dpdk.org/api/patches/111300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220518101657.1230416-6-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220518101657.1230416-6-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220518101657.1230416-6-david.marchand@redhat.com", "date": "2022-05-18T10:16:50", "name": "[05/12] net/enetfec: fix build with GCC 12", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1733883622c79d7abaf5036649233605de3612ff", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220518101657.1230416-6-david.marchand@redhat.com/mbox/", "series": [ { "id": 22993, "url": "http://patches.dpdk.org/api/series/22993/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22993", "date": "2022-05-18T10:16:45", "name": "Fix compilation with gcc 12", "version": 1, "mbox": "http://patches.dpdk.org/series/22993/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111300/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/111300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F0240A0503;\n\tWed, 18 May 2022 12:17:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C84F342B7C;\n\tWed, 18 May 2022 12:17:47 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id D461242B7C\n for <dev@dpdk.org>; Wed, 18 May 2022 12:17:46 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-562-yuv1_gaeNdCs6b96toT1-Q-1; Wed, 18 May 2022 06:17:45 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFB541C06901;\n Wed, 18 May 2022 10:17:44 +0000 (UTC)", "from fchome.home (unknown [10.40.195.61])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 4C4CB401E98;\n Wed, 18 May 2022 10:17:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1652869066;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=kYkte8g+iQLXO5VsFitqTI3owdfv6sMTeeMCZFnmLGY=;\n b=gIySbALkSQmn4laDqimM9oz+Ej4WS8867yhGZ8svpm5XHMdVPGvLM0AMC8PLuBYYgNbbUg\n e8EkTliEvrCL2YAOz5aGR9evlMdR83hZJwoJvV+wscfDnnJ/6NCYBcZ0rtq+q5fuHpygzq\n DnVjHi1kZjhhN1FG0sDfWh0htWxrXxA=", "X-MC-Unique": "yuv1_gaeNdCs6b96toT1-Q-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@xilinx.com, stable@dpdk.org,\n Apeksha Gupta <apeksha.gupta@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>", "Subject": "[PATCH 05/12] net/enetfec: fix build with GCC 12", "Date": "Wed, 18 May 2022 12:16:50 +0200", "Message-Id": "<20220518101657.1230416-6-david.marchand@redhat.com>", "In-Reply-To": "<20220518101657.1230416-1-david.marchand@redhat.com>", "References": "<20220518101657.1230416-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.10", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "GCC 12 raises the following warning:\n\n../drivers/net/enetfec/enet_ethdev.c: In function\n ‘enetfec_rx_queue_setup’:\n../drivers/net/enetfec/enet_ethdev.c:473:9: error: array\n subscript 1 is\n above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’}\n [-Werror=array-bounds]\n 473 | rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]),\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 474 | (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx));\n | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nIn file included from ../drivers/net/enetfec/enet_ethdev.c:9:\n../drivers/net/enetfec/enet_ethdev.h:113:33: note: while referencing\n ‘bd_addr_p_r’\n 113 | uint32_t bd_addr_p_r[ENETFEC_MAX_Q];\n | ^~~~~~~~~~~\n\nThis driver properly announces that it only supports 1 rxq.\nSilence this warning by adding an explicit check on the queue id.\n\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/enetfec/enet_ethdev.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/enet_ethdev.c\nindex 714f8ac7ec..c938e58204 100644\n--- a/drivers/net/enetfec/enet_ethdev.c\n+++ b/drivers/net/enetfec/enet_ethdev.c\n@@ -2,9 +2,12 @@\n * Copyright 2020-2021 NXP\n */\n \n+#include <inttypes.h>\n+\n #include <ethdev_vdev.h>\n #include <ethdev_driver.h>\n #include <rte_io.h>\n+\n #include \"enet_pmd_logs.h\"\n #include \"enet_ethdev.h\"\n #include \"enet_regs.h\"\n@@ -454,6 +457,12 @@ enetfec_rx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (queue_idx >= ENETFEC_MAX_Q) {\n+\t\tENETFEC_PMD_ERR(\"Invalid queue id %\" PRIu16 \", max %d\\n\",\n+\t\t\tqueue_idx, ENETFEC_MAX_Q);\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* allocate receive queue */\n \trxq = rte_zmalloc(NULL, sizeof(*rxq), RTE_CACHE_LINE_SIZE);\n \tif (rxq == NULL) {\n", "prefixes": [ "05/12" ] }