Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111299/?format=api
{ "id": 111299, "url": "http://patches.dpdk.org/api/patches/111299/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220518101657.1230416-5-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220518101657.1230416-5-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220518101657.1230416-5-david.marchand@redhat.com", "date": "2022-05-18T10:16:49", "name": "[04/12] net/ena: fix build with GCC 12", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2b11d5e9fdc887f437f8c1d2c94bc5eeb60fc082", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220518101657.1230416-5-david.marchand@redhat.com/mbox/", "series": [ { "id": 22993, "url": "http://patches.dpdk.org/api/series/22993/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22993", "date": "2022-05-18T10:16:45", "name": "Fix compilation with gcc 12", "version": 1, "mbox": "http://patches.dpdk.org/series/22993/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111299/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/111299/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DD786A0503;\n\tWed, 18 May 2022 12:17:43 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D189C42B7E;\n\tWed, 18 May 2022 12:17:43 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 726FE42B7C\n for <dev@dpdk.org>; Wed, 18 May 2022 12:17:42 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-494-svzbCtz4O2yYhEn8YWXHGg-1; Wed, 18 May 2022 06:17:39 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7115A3C16193;\n Wed, 18 May 2022 10:17:38 +0000 (UTC)", "from fchome.home (unknown [10.40.195.61])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 6EF76492C14;\n Wed, 18 May 2022 10:17:34 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1652869062;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=SpBsPtfJXg7uFYb7ZVgI2WwOY7y/aEYXx7lzo3SrJ9w=;\n b=J+YQXtkaH5fgM7ZyjcvJoqbm1rv/QIFblhgY4GziuPy9xknR9RSvhAhMsfzlYX6I9YJNG7\n TJNM1VvXBocYwbOqCtj3gOi72OY/QgR71bi46P0k+gJCzi6xKAKSMoLCe+HdwFOK7jYsMo\n COfNzYQzobe9xIs35mbLg/LPFIDe8XM=", "X-MC-Unique": "svzbCtz4O2yYhEn8YWXHGg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@xilinx.com, stable@dpdk.org,\n Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,\n Shai Brandes <shaibran@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,\n Igor Chauskin <igorch@amazon.com>", "Subject": "[PATCH 04/12] net/ena: fix build with GCC 12", "Date": "Wed, 18 May 2022 12:16:49 +0200", "Message-Id": "<20220518101657.1230416-5-david.marchand@redhat.com>", "In-Reply-To": "<20220518101657.1230416-1-david.marchand@redhat.com>", "References": "<20220518101657.1230416-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.10", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "GCC 12 raises the following warning:\n\nIn file included from ../lib/mempool/rte_mempool.h:46,\n from ../lib/mbuf/rte_mbuf.h:38,\n from ../lib/net/rte_ether.h:22,\n from ../drivers/net/ena/ena_ethdev.h:10,\n from ../drivers/net/ena/ena_rss.c:6:\n../drivers/net/ena/ena_rss.c: In function ‘ena_rss_key_fill’:\n../lib/eal/x86/include/rte_memcpy.h:370:9: warning: array subscript 64 is\n outside array bounds of ‘uint8_t[40]’ {aka ‘unsigned char[40]’}\n [-Warray-bounds]\n 370 | rte_mov32((uint8_t *)dst + 2 * 32, (const uint8_t *)src + 2 * 32);\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n../drivers/net/ena/ena_rss.c:51:24: note: while referencing ‘default_key’\n 51 | static uint8_t default_key[ENA_HASH_KEY_SIZE];\n | ^~~~~~~~~~~\n\nThis is a false positive because the copied size is checked against\nENA_HASH_KEY_SIZE in a (build) assert.\nSilence this warning by calling memcpy with the minimal size.\n\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/ena/ena_rss.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c\nindex b6c4f76e38..b682d01c20 100644\n--- a/drivers/net/ena/ena_rss.c\n+++ b/drivers/net/ena/ena_rss.c\n@@ -51,15 +51,14 @@ void ena_rss_key_fill(void *key, size_t size)\n \tstatic uint8_t default_key[ENA_HASH_KEY_SIZE];\n \tsize_t i;\n \n-\tRTE_ASSERT(size <= ENA_HASH_KEY_SIZE);\n-\n \tif (!key_generated) {\n-\t\tfor (i = 0; i < ENA_HASH_KEY_SIZE; ++i)\n+\t\tfor (i = 0; i < RTE_DIM(default_key); ++i)\n \t\t\tdefault_key[i] = rte_rand() & 0xff;\n \t\tkey_generated = true;\n \t}\n \n-\trte_memcpy(key, default_key, size);\n+\tRTE_ASSERT(size <= sizeof(default_key));\n+\trte_memcpy(key, default_key, RTE_MIN(size, sizeof(default_key)));\n }\n \n int ena_rss_reta_update(struct rte_eth_dev *dev,\n", "prefixes": [ "04/12" ] }