Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111298/?format=api
{ "id": 111298, "url": "http://patches.dpdk.org/api/patches/111298/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220518101657.1230416-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220518101657.1230416-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220518101657.1230416-4-david.marchand@redhat.com", "date": "2022-05-18T10:16:48", "name": "[03/12] crypto/ipsec_mb: fix build with GCC 12", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94ac1d98f2a41010e0bf3a7190effd8de848d373", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220518101657.1230416-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 22993, "url": "http://patches.dpdk.org/api/series/22993/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22993", "date": "2022-05-18T10:16:45", "name": "Fix compilation with gcc 12", "version": 1, "mbox": "http://patches.dpdk.org/series/22993/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111298/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111298/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 607B4A0503;\n\tWed, 18 May 2022 12:17:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C44FA42B74;\n\tWed, 18 May 2022 12:17:34 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id A88EF42B76\n for <dev@dpdk.org>; Wed, 18 May 2022 12:17:33 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-471-Dhp7OabkPsauPVd39VhtWg-1; Wed, 18 May 2022 06:17:31 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6EB24100BAA1;\n Wed, 18 May 2022 10:17:31 +0000 (UTC)", "from fchome.home (unknown [10.40.195.61])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 373EB492C14;\n Wed, 18 May 2022 10:17:28 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1652869053;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xedkle9ETY5HnDA6EV9aXPh13s7Qm6ZQYYFcxVq9Ynk=;\n b=GIGtjMuYtfQcIKSVHX3XGh5Km0kT0SAyq1NFJXddVTYb9SKzxMqhRtHx1Fgy+Gc1jAubKq\n 6JC90dLZIgqpk6KFv6LdASGrok18mAasEEESFIn1duMZJVg6DUSR+bb8/+teWneRykh+u7\n AQPotgAp6dxtTGZPFquOhltM34z9VN8=", "X-MC-Unique": "Dhp7OabkPsauPVd39VhtWg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@xilinx.com, stable@dpdk.org,\n Fan Zhang <roy.fan.zhang@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n Deepak Kumar Jain <deepak.k.jain@intel.com>", "Subject": "[PATCH 03/12] crypto/ipsec_mb: fix build with GCC 12", "Date": "Wed, 18 May 2022 12:16:48 +0200", "Message-Id": "<20220518101657.1230416-4-david.marchand@redhat.com>", "In-Reply-To": "<20220518101657.1230416-1-david.marchand@redhat.com>", "References": "<20220518101657.1230416-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.10", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "GCC 12 raises the following warning:\n\nIn function ‘__rte_ring_enqueue_elems_64’,\n inlined from ‘__rte_ring_enqueue_elems’ at\n ../lib/ring/rte_ring_elem_pvt.h:130:3,\n inlined from ‘__rte_ring_do_hts_enqueue_elem’ at\n ../lib/ring/rte_ring_hts_elem_pvt.h:196:3,\n inlined from ‘rte_ring_mp_hts_enqueue_burst_elem’ at\n ../lib/ring/rte_ring_hts.h:110:9,\n inlined from ‘rte_ring_enqueue_burst_elem’ at\n ../lib/ring/rte_ring_elem.h:577:10,\n inlined from ‘rte_ring_enqueue_burst’ at\n ../lib/ring/rte_ring.h:738:9,\n inlined from ‘process_op_bit’ at\n ../drivers/crypto/ipsec_mb/pmd_snow3g.c:425:16,\n inlined from ‘snow3g_pmd_dequeue_burst’ at\n ../drivers/crypto/ipsec_mb/pmd_snow3g.c:484:20:\n../lib/ring/rte_ring_elem_pvt.h:68:44: error: array subscript 1 is\n outside array bounds of ‘struct rte_crypto_op[0]’\n [-Werror=array-bounds]\n 68 | ring[idx + 1] = obj[i + 1];\n | ~~~^~~~~~~\n../drivers/crypto/ipsec_mb/pmd_snow3g.c: In function\n ‘snow3g_pmd_dequeue_burst’:\n../drivers/crypto/ipsec_mb/pmd_snow3g.c:434:1: note:\n at offset 8 into object ‘op’ of size 8\n 434 | snow3g_pmd_dequeue_burst(void *queue_pair,\n | ^~~~~~~~~~~~~~~~~~~~~~~~\n\nValidate that one (exactly) op has been processed or return early.\n\nFixes: b537abdbee74 (\"crypto/snow3g: support bit-level operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/crypto/ipsec_mb/pmd_snow3g.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c b/drivers/crypto/ipsec_mb/pmd_snow3g.c\nindex ebc9a0b562..9a85f46721 100644\n--- a/drivers/crypto/ipsec_mb/pmd_snow3g.c\n+++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c\n@@ -422,12 +422,13 @@ process_op_bit(struct rte_crypto_op *op, struct snow3g_session *session,\n \t\top->sym->session = NULL;\n \t}\n \n-\tenqueued_op = rte_ring_enqueue_burst(qp->ingress_queue,\n-\t\t\t(void **)&op, processed_op, NULL);\n+\tif (unlikely(processed_op != 1))\n+\t\treturn 0;\n+\tenqueued_op = rte_ring_enqueue(qp->ingress_queue, op);\n \tqp->stats.enqueued_count += enqueued_op;\n \t*accumulated_enqueued_ops += enqueued_op;\n \n-\treturn enqueued_op;\n+\treturn 1;\n }\n \n static uint16_t\n", "prefixes": [ "03/12" ] }