Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111189/?format=api
{ "id": 111189, "url": "http://patches.dpdk.org/api/patches/111189/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/33fe903b38d712388230cfa58ee3a64987771918.1652722314.git.sthotton@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<33fe903b38d712388230cfa58ee3a64987771918.1652722314.git.sthotton@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/33fe903b38d712388230cfa58ee3a64987771918.1652722314.git.sthotton@marvell.com", "date": "2022-05-16T17:35:47", "name": "[v4,1/5] eventdev: support to set queue attributes at runtime", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba86c5d7ca17a0ab25b734812d594fec9f74c97d", "submitter": { "id": 2049, "url": "http://patches.dpdk.org/api/people/2049/?format=api", "name": "Shijith Thotton", "email": "sthotton@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/33fe903b38d712388230cfa58ee3a64987771918.1652722314.git.sthotton@marvell.com/mbox/", "series": [ { "id": 22956, "url": "http://patches.dpdk.org/api/series/22956/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22956", "date": "2022-05-16T17:35:46", "name": "Extend and set event queue attributes at runtime", "version": 4, "mbox": "http://patches.dpdk.org/series/22956/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111189/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/111189/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 51474A00BE;\n\tMon, 16 May 2022 19:39:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3F0AD40A7A;\n\tMon, 16 May 2022 19:39:27 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id DD6D44068B\n for <dev@dpdk.org>; Mon, 16 May 2022 19:39:25 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 24GB6vIw012720;\n Mon, 16 May 2022 10:37:23 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g2bxsqytr-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 16 May 2022 10:37:22 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 16 May 2022 10:37:20 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 16 May 2022 10:37:20 -0700", "from localhost.localdomain (unknown [10.28.34.29])\n by maili.marvell.com (Postfix) with ESMTP id 65ED13F70CF;\n Mon, 16 May 2022 10:37:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=0wR4lBXb1r2DEULglOhQr95WATJSJ2FcEqaywGw+L0I=;\n b=J5yQuzEjrszAWXMK5jOmGux/XmCoFdqJYA28X5kTVXOjWQcQfR84iUPdZCfwHO7kdt28\n JeWcn0EBdTEUexk86C/gKvxGeTCOQfQHhIyPh0CNHnmo0nyPKH+1joDy69zAqcvopFdx\n FF7IVC5A4A6o3kgLB6z8cJK4SDfFE/9JjtJbngBrBFExcMms3kxxaItjs0lm6ZXmEX5J\n Ii8kjEhEvWwHtyfamKjsp8Q2IIsvA0TwSGBEI4vUsPnTXohctiLvPIZbvRIiXRbfQjHx\n SWe4b3kapQAIFxss8xGeyqJwuq919XCjR2Sh6V8gfPsxAjHLW2tOlptvasloJX5fwTRn 5Q==", "From": "Shijith Thotton <sthotton@marvell.com>", "To": "<dev@dpdk.org>, <jerinj@marvell.com>", "CC": "Shijith Thotton <sthotton@marvell.com>, <pbhagavatula@marvell.com>,\n <harry.van.haaren@intel.com>, <mattias.ronnblom@ericsson.com>,\n <mdr@ashroe.eu>", "Subject": "[PATCH v4 1/5] eventdev: support to set queue attributes at runtime", "Date": "Mon, 16 May 2022 23:05:47 +0530", "Message-ID": "\n <33fe903b38d712388230cfa58ee3a64987771918.1652722314.git.sthotton@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1652722314.git.sthotton@marvell.com>", "References": "<cover.1652607951.git.sthotton@marvell.com>\n <cover.1652722314.git.sthotton@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "i-cBrDFAMxiMq1QKFIdaxitZkVulfJzS", "X-Proofpoint-GUID": "i-cBrDFAMxiMq1QKFIdaxitZkVulfJzS", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514\n definitions=2022-05-16_15,2022-05-16_02,2022-02-23_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added a new eventdev API rte_event_queue_attr_set(), to set event queue\nattributes at runtime from the values set during initialization using\nrte_event_queue_setup(). PMD's supporting this feature should expose the\ncapability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR.\n\nSigned-off-by: Shijith Thotton <sthotton@marvell.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\n doc/guides/eventdevs/features/default.ini | 1 +\n doc/guides/rel_notes/release_22_07.rst | 5 ++++\n lib/eventdev/eventdev_pmd.h | 22 ++++++++++++++++\n lib/eventdev/rte_eventdev.c | 26 ++++++++++++++++++\n lib/eventdev/rte_eventdev.h | 32 ++++++++++++++++++++++-\n lib/eventdev/version.map | 3 +++\n 6 files changed, 88 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/eventdevs/features/default.ini b/doc/guides/eventdevs/features/default.ini\nindex 2ea233463a..00360f60c6 100644\n--- a/doc/guides/eventdevs/features/default.ini\n+++ b/doc/guides/eventdevs/features/default.ini\n@@ -17,6 +17,7 @@ runtime_port_link =\n multiple_queue_port =\n carry_flow_id =\n maintenance_free =\n+runtime_queue_attr =\n \n ;\n ; Features of a default Ethernet Rx adapter.\ndiff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst\nindex 88d6e96cc1..a7a912d665 100644\n--- a/doc/guides/rel_notes/release_22_07.rst\n+++ b/doc/guides/rel_notes/release_22_07.rst\n@@ -65,6 +65,11 @@ New Features\n * Added support for promiscuous mode on Windows.\n * Added support for MTU on Windows.\n \n+* **Added support for setting queue attributes at runtime in eventdev.**\n+\n+ Added new API ``rte_event_queue_attr_set()``, to set event queue attributes\n+ at runtime.\n+\n \n Removed Items\n -------------\ndiff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h\nindex ce469d47a6..3b85d9f7a5 100644\n--- a/lib/eventdev/eventdev_pmd.h\n+++ b/lib/eventdev/eventdev_pmd.h\n@@ -341,6 +341,26 @@ typedef int (*eventdev_queue_setup_t)(struct rte_eventdev *dev,\n typedef void (*eventdev_queue_release_t)(struct rte_eventdev *dev,\n \t\tuint8_t queue_id);\n \n+/**\n+ * Set an event queue attribute at runtime.\n+ *\n+ * @param dev\n+ * Event device pointer\n+ * @param queue_id\n+ * Event queue index\n+ * @param attr_id\n+ * Event queue attribute id\n+ * @param attr_value\n+ * Event queue attribute value\n+ *\n+ * @return\n+ * - 0: Success.\n+ * - <0: Error code on failure.\n+ */\n+typedef int (*eventdev_queue_attr_set_t)(struct rte_eventdev *dev,\n+\t\t\t\t\t uint8_t queue_id, uint32_t attr_id,\n+\t\t\t\t\t uint64_t attr_value);\n+\n /**\n * Retrieve the default event port configuration.\n *\n@@ -1211,6 +1231,8 @@ struct eventdev_ops {\n \t/**< Set up an event queue. */\n \teventdev_queue_release_t queue_release;\n \t/**< Release an event queue. */\n+\teventdev_queue_attr_set_t queue_attr_set;\n+\t/**< Set an event queue attribute. */\n \n \teventdev_port_default_conf_get_t port_def_conf;\n \t/**< Get default port configuration. */\ndiff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c\nindex 532a253553..a31e99be02 100644\n--- a/lib/eventdev/rte_eventdev.c\n+++ b/lib/eventdev/rte_eventdev.c\n@@ -844,6 +844,32 @@ rte_event_queue_attr_get(uint8_t dev_id, uint8_t queue_id, uint32_t attr_id,\n \treturn 0;\n }\n \n+int\n+rte_event_queue_attr_set(uint8_t dev_id, uint8_t queue_id, uint32_t attr_id,\n+\t\t\t uint64_t attr_value)\n+{\n+\tstruct rte_eventdev *dev;\n+\n+\tRTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);\n+\tdev = &rte_eventdevs[dev_id];\n+\tif (!is_valid_queue(dev, queue_id)) {\n+\t\tRTE_EDEV_LOG_ERR(\"Invalid queue_id=%\" PRIu8, queue_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (!(dev->data->event_dev_cap &\n+\t RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR)) {\n+\t\tRTE_EDEV_LOG_ERR(\n+\t\t\t\"Device %\" PRIu8 \"does not support changing queue attributes at runtime\",\n+\t\t\tdev_id);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_attr_set, -ENOTSUP);\n+\treturn (*dev->dev_ops->queue_attr_set)(dev, queue_id, attr_id,\n+\t\t\t\t\t attr_value);\n+}\n+\n int\n rte_event_port_link(uint8_t dev_id, uint8_t port_id,\n \t\t const uint8_t queues[], const uint8_t priorities[],\ndiff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h\nindex 42a5660169..a79b1397eb 100644\n--- a/lib/eventdev/rte_eventdev.h\n+++ b/lib/eventdev/rte_eventdev.h\n@@ -225,7 +225,7 @@ struct rte_event;\n /**< Event scheduling prioritization is based on the priority associated with\n * each event queue.\n *\n- * @see rte_event_queue_setup()\n+ * @see rte_event_queue_setup(), rte_event_queue_attr_set()\n */\n #define RTE_EVENT_DEV_CAP_EVENT_QOS (1ULL << 1)\n /**< Event scheduling prioritization is based on the priority associated with\n@@ -307,6 +307,13 @@ struct rte_event;\n * global pool, or process signaling related to load balancing.\n */\n \n+#define RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR (1ULL << 11)\n+/**< Event device is capable of changing the queue attributes at runtime i.e\n+ * after rte_event_queue_setup() or rte_event_start() call sequence. If this\n+ * flag is not set, eventdev queue attributes can only be configured during\n+ * rte_event_queue_setup().\n+ */\n+\n /* Event device priority levels */\n #define RTE_EVENT_DEV_PRIORITY_HIGHEST 0\n /**< Highest priority expressed across eventdev subsystem\n@@ -702,6 +709,29 @@ int\n rte_event_queue_attr_get(uint8_t dev_id, uint8_t queue_id, uint32_t attr_id,\n \t\t\tuint32_t *attr_value);\n \n+/**\n+ * Set an event queue attribute.\n+ *\n+ * @param dev_id\n+ * Eventdev id\n+ * @param queue_id\n+ * Eventdev queue id\n+ * @param attr_id\n+ * The attribute ID to set\n+ * @param attr_value\n+ * The attribute value to set\n+ *\n+ * @return\n+ * - 0: Successfully set attribute.\n+ * - -EINVAL: invalid device, queue or attr_id.\n+ * - -ENOTSUP: device does not support setting the event attribute.\n+ * - <0: failed to set event queue attribute\n+ */\n+__rte_experimental\n+int\n+rte_event_queue_attr_set(uint8_t dev_id, uint8_t queue_id, uint32_t attr_id,\n+\t\t\t uint64_t attr_value);\n+\n /* Event port specific APIs */\n \n /* Event port configuration bitmap flags */\ndiff --git a/lib/eventdev/version.map b/lib/eventdev/version.map\nindex cd5dada07f..c581b75c18 100644\n--- a/lib/eventdev/version.map\n+++ b/lib/eventdev/version.map\n@@ -108,6 +108,9 @@ EXPERIMENTAL {\n \n \t# added in 22.03\n \trte_event_eth_rx_adapter_event_port_get;\n+\n+\t# added in 22.07\n+\trte_event_queue_attr_set;\n };\n \n INTERNAL {\n", "prefixes": [ "v4", "1/5" ] }