Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111100/?format=api
{ "id": 111100, "url": "http://patches.dpdk.org/api/patches/111100/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-7-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220513025357.52275-7-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220513025357.52275-7-fengchengwen@huawei.com", "date": "2022-05-13T02:53:54", "name": "[v4,6/9] net/axgbe: adjust return value of xstats-get ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b6dc3ab9791f8bb70dda9f2e108e8a296b3d2730", "submitter": { "id": 2146, "url": "http://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-7-fengchengwen@huawei.com/mbox/", "series": [ { "id": 22920, "url": "http://patches.dpdk.org/api/series/22920/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22920", "date": "2022-05-13T02:53:48", "name": "bugfix for ethdev telemetry", "version": 4, "mbox": "http://patches.dpdk.org/series/22920/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111100/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111100/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 11225A00C3;\n\tFri, 13 May 2022 05:00:30 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 00E8642855;\n\tFri, 13 May 2022 05:00:01 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 173B740DDE\n for <dev@dpdk.org>; Fri, 13 May 2022 04:59:54 +0200 (CEST)", "from dggpeml500024.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kztd96gk2zfbWL;\n Fri, 13 May 2022 10:58:37 +0800 (CST)", "from localhost.localdomain (10.67.165.24) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Fri, 13 May 2022 10:59:52 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <ndabilpuram@marvell.com>,\n <kirankumark@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>", "CC": "<mb@smartsharesystems.com>, <stephen@networkplumber.org>, <dev@dpdk.org>", "Subject": "[PATCH v4 6/9] net/axgbe: adjust return value of xstats-get ops", "Date": "Fri, 13 May 2022 10:53:54 +0800", "Message-ID": "<20220513025357.52275-7-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220513025357.52275-1-fengchengwen@huawei.com>", "References": "<20220416010747.40714-1-fengchengwen@huawei.com>\n <20220513025357.52275-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Many user (e.g. telemetry) invokes rte_eth_xstats_get(port_id, NULL, 0)\nto retrieve the required number of elements, but currently axgbe PMD\nreturns zero when xstats is NULL.\n\nIn the previous patch, the framework defines that the required number\nof entries should be returned when n is lower than the required number\nof entries, and makes sure xstats must not be NULL when n is non-zero.\n\nThis patch removes the logic of \"return zero when xstats is NULL\", and\nadds the logic of \"return the required number of entries when n is\nlower than the required number of entries\".\n\nFixes: 9d1ef6b2e731 (\"net/axgbe: add xstats\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex 951da5cc26..e6822fa711 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -1013,18 +1013,18 @@ axgbe_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,\n \tstruct axgbe_port *pdata = dev->data->dev_private;\n \tunsigned int i;\n \n-\tif (!stats)\n-\t\treturn 0;\n+\tif (n < AXGBE_XSTATS_COUNT)\n+\t\treturn AXGBE_XSTATS_COUNT;\n \n \taxgbe_read_mmc_stats(pdata);\n \n-\tfor (i = 0; i < n && i < AXGBE_XSTATS_COUNT; i++) {\n+\tfor (i = 0; i < AXGBE_XSTATS_COUNT; i++) {\n \t\tstats[i].id = i;\n \t\tstats[i].value = *(u64 *)((uint8_t *)&pdata->mmc_stats +\n \t\t\t\taxgbe_xstats_strings[i].offset);\n \t}\n \n-\treturn i;\n+\treturn AXGBE_XSTATS_COUNT;\n }\n \n static int\n", "prefixes": [ "v4", "6/9" ] }