Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111098/?format=api
{ "id": 111098, "url": "http://patches.dpdk.org/api/patches/111098/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-4-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220513025357.52275-4-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220513025357.52275-4-fengchengwen@huawei.com", "date": "2022-05-13T02:53:51", "name": "[v4,3/9] net/hns3: adjust return value of xstats-get ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "77feeb7c8833dbbd713bb03f0da9ad6b29752310", "submitter": { "id": 2146, "url": "http://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-4-fengchengwen@huawei.com/mbox/", "series": [ { "id": 22920, "url": "http://patches.dpdk.org/api/series/22920/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22920", "date": "2022-05-13T02:53:48", "name": "bugfix for ethdev telemetry", "version": 4, "mbox": "http://patches.dpdk.org/series/22920/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111098/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111098/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AFD8AA00C3;\n\tFri, 13 May 2022 05:00:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4684142848;\n\tFri, 13 May 2022 04:59:59 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id E340942831\n for <dev@dpdk.org>; Fri, 13 May 2022 04:59:53 +0200 (CEST)", "from dggpeml500024.china.huawei.com (unknown [172.30.72.55])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Kztd95B55z1JBwg;\n Fri, 13 May 2022 10:58:37 +0800 (CST)", "from localhost.localdomain (10.67.165.24) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Fri, 13 May 2022 10:59:52 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <ndabilpuram@marvell.com>,\n <kirankumark@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>", "CC": "<mb@smartsharesystems.com>, <stephen@networkplumber.org>, <dev@dpdk.org>", "Subject": "[PATCH v4 3/9] net/hns3: adjust return value of xstats-get ops", "Date": "Fri, 13 May 2022 10:53:51 +0800", "Message-ID": "<20220513025357.52275-4-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220513025357.52275-1-fengchengwen@huawei.com>", "References": "<20220416010747.40714-1-fengchengwen@huawei.com>\n <20220513025357.52275-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Many user (e.g. telemetry) invokes rte_eth_xstats_get(port_id, NULL, 0)\nto retrieve the required number of elements, but currently hns3 PMD\nreturns zero when xstats is NULL.\n\nIn the previous patch, the framework defines that the required number\nof entries should be returned when xstats is NULL and n is zero. And\nxstats is NULL if and only if n is zero.\n\nBased on the preceding constraints, this patch removes the logic of\n\"return zero when xstats is NULL\".\n\nFixes: 8839c5e202f3 (\"net/hns3: support device stats\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/hns3/hns3_stats.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex 806720faff..ac1f0d9126 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -1020,9 +1020,13 @@ hns3_imissed_stats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n * @praram xstats\n * A pointer to a table of structure of type *rte_eth_xstat*\n * to be filled with device statistics ids and values.\n- * This parameter can be set to NULL if n is 0.\n+ * This parameter can be set to NULL if and only if n is 0.\n * @param n\n * The size of the xstats array (number of elements).\n+ * If lower than the required number of elements, the function returns the\n+ * required number of elements.\n+ * If equal to zero, the xstats parameter must be NULL, the function returns\n+ * the required number of elements.\n * @return\n * 0 on fail, count(The size of the statistics elements) on success.\n */\n@@ -1041,9 +1045,6 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \tint count;\n \tint ret;\n \n-\tif (xstats == NULL)\n-\t\treturn 0;\n-\n \tcount = hns3_xstats_calc_num(dev);\n \tif ((int)n < count)\n \t\treturn count;\n", "prefixes": [ "v4", "3/9" ] }