Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111095/?format=api
{ "id": 111095, "url": "http://patches.dpdk.org/api/patches/111095/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-3-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220513025357.52275-3-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220513025357.52275-3-fengchengwen@huawei.com", "date": "2022-05-13T02:53:50", "name": "[v4,2/9] ethdev: optimize xstats-get API's implementation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b9bdea1b72a9c1c91eae160826231f20ff8b9d6c", "submitter": { "id": 2146, "url": "http://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-3-fengchengwen@huawei.com/mbox/", "series": [ { "id": 22920, "url": "http://patches.dpdk.org/api/series/22920/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22920", "date": "2022-05-13T02:53:48", "name": "bugfix for ethdev telemetry", "version": 4, "mbox": "http://patches.dpdk.org/series/22920/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111095/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111095/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 84808A00C3;\n\tFri, 13 May 2022 04:59:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7A0AB42833;\n\tFri, 13 May 2022 04:59:56 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 86D67427F1\n for <dev@dpdk.org>; Fri, 13 May 2022 04:59:53 +0200 (CEST)", "from dggpeml500024.china.huawei.com (unknown [172.30.72.56])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kztf16VrfzgYtb;\n Fri, 13 May 2022 10:59:21 +0800 (CST)", "from localhost.localdomain (10.67.165.24) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Fri, 13 May 2022 10:59:51 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <ndabilpuram@marvell.com>,\n <kirankumark@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>", "CC": "<mb@smartsharesystems.com>, <stephen@networkplumber.org>, <dev@dpdk.org>", "Subject": "[PATCH v4 2/9] ethdev: optimize xstats-get API's implementation", "Date": "Fri, 13 May 2022 10:53:50 +0800", "Message-ID": "<20220513025357.52275-3-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220513025357.52275-1-fengchengwen@huawei.com>", "References": "<20220416010747.40714-1-fengchengwen@huawei.com>\n <20220513025357.52275-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch uses eth_dev_get_xstats_basic_count() to retrieve generic\nstatistics count.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n lib/ethdev/rte_ethdev.c | 11 ++---------\n 1 file changed, 2 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex d9661bd64f..78192c26f7 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -2967,9 +2967,8 @@ rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats,\n \tunsigned int n)\n {\n \tstruct rte_eth_dev *dev;\n-\tunsigned int count = 0, i;\n+\tunsigned int count, i;\n \tsigned int xcount = 0;\n-\tuint16_t nb_rxqs, nb_txqs;\n \tint ret;\n \n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n@@ -2977,13 +2976,7 @@ rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats,\n \t\treturn -EINVAL;\n \tdev = &rte_eth_devices[port_id];\n \n-\tnb_rxqs = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\tnb_txqs = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\n-\t/* Return generic statistics */\n-\tcount = RTE_NB_STATS;\n-\tif (dev->data->dev_flags & RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS)\n-\t\tcount += (nb_rxqs * RTE_NB_RXQ_STATS) + (nb_txqs * RTE_NB_TXQ_STATS);\n+\tcount = eth_dev_get_xstats_basic_count(dev);\n \n \t/* implemented by the driver */\n \tif (dev->dev_ops->xstats_get != NULL) {\n", "prefixes": [ "v4", "2/9" ] }