Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110963/?format=api
{ "id": 110963, "url": "http://patches.dpdk.org/api/patches/110963/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220510063118.449216-2-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220510063118.449216-2-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220510063118.449216-2-ruifeng.wang@arm.com", "date": "2022-05-10T06:31:17", "name": "[1/2] net/bnxt: use compiler atomics for stats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "16ed4b1beebb33228b30521fca9306542cd13272", "submitter": { "id": 1198, "url": "http://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220510063118.449216-2-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 22862, "url": "http://patches.dpdk.org/api/series/22862/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22862", "date": "2022-05-10T06:31:16", "name": "atomic changes", "version": 1, "mbox": "http://patches.dpdk.org/series/22862/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/110963/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/110963/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A2BC9A04FD;\n\tTue, 10 May 2022 08:31:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C495541156;\n\tTue, 10 May 2022 08:31:41 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id D63F741156\n for <dev@dpdk.org>; Tue, 10 May 2022 08:31:39 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3385F12FC;\n Mon, 9 May 2022 23:31:39 -0700 (PDT)", "from net-arm-n1amp-02.shanghai.arm.com\n (net-arm-n1amp-02.shanghai.arm.com [10.169.210.142])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 92BD43F73D;\n Mon, 9 May 2022 23:31:36 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "ajit.khaparde@broadcom.com,\n\tsomnath.kotur@broadcom.com", "Cc": "dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com,\n Ruifeng Wang <ruifeng.wang@arm.com>,\n Kathleen Capella <kathleen.capella@arm.com>", "Subject": "[PATCH 1/2] net/bnxt: use compiler atomics for stats", "Date": "Tue, 10 May 2022 14:31:17 +0800", "Message-Id": "<20220510063118.449216-2-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220510063118.449216-1-ruifeng.wang@arm.com>", "References": "<20220510063118.449216-1-ruifeng.wang@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Converted rte_atomic usages to compiler atomic built-ins.\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Kathleen Capella <kathleen.capella@arm.com>\n---\n drivers/net/bnxt/bnxt_rxq.c | 2 +-\n drivers/net/bnxt/bnxt_rxq.h | 2 +-\n drivers/net/bnxt/bnxt_rxr.c | 9 +++++----\n drivers/net/bnxt/bnxt_stats.c | 4 ++--\n 4 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex cd3bb1446f..9c93cde9b3 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -378,7 +378,7 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \t\t\t \"ring_dma_zone_reserve for rx_ring failed!\\n\");\n \t\tgoto err;\n \t}\n-\trte_atomic64_init(&rxq->rx_mbuf_alloc_fail);\n+\trxq->rx_mbuf_alloc_fail = 0;\n \n \t/* rxq 0 must not be stopped when used as async CPR */\n \tif (!BNXT_NUM_ASYNC_CPR(bp) && queue_idx == 0)\ndiff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h\nindex 0331c23810..7b52a21497 100644\n--- a/drivers/net/bnxt/bnxt_rxq.h\n+++ b/drivers/net/bnxt/bnxt_rxq.h\n@@ -40,7 +40,7 @@ struct bnxt_rx_queue {\n \tstruct bnxt_rx_ring_info\t*rx_ring;\n \tstruct bnxt_cp_ring_info\t*cp_ring;\n \tstruct rte_mbuf\t\t\tfake_mbuf;\n-\trte_atomic64_t\t\trx_mbuf_alloc_fail;\n+\tuint64_t\t\t\trx_mbuf_alloc_fail;\n \tconst struct rte_memzone *mz;\n };\n \ndiff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex 5a9cf48e67..738f2f584c 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -49,7 +49,7 @@ static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq,\n \trx_buf = &rxr->rx_buf_ring[prod];\n \tmbuf = __bnxt_alloc_rx_data(rxq->mb_pool);\n \tif (!mbuf) {\n-\t\trte_atomic64_inc(&rxq->rx_mbuf_alloc_fail);\n+\t\t__atomic_fetch_add(&rxq->rx_mbuf_alloc_fail, 1, __ATOMIC_RELAXED);\n \t\treturn -ENOMEM;\n \t}\n \n@@ -84,7 +84,7 @@ static inline int bnxt_alloc_ag_data(struct bnxt_rx_queue *rxq,\n \n \tmbuf = __bnxt_alloc_rx_data(rxq->mb_pool);\n \tif (!mbuf) {\n-\t\trte_atomic64_inc(&rxq->rx_mbuf_alloc_fail);\n+\t\t__atomic_fetch_add(&rxq->rx_mbuf_alloc_fail, 1, __ATOMIC_RELAXED);\n \t\treturn -ENOMEM;\n \t}\n \n@@ -459,7 +459,7 @@ static inline struct rte_mbuf *bnxt_tpa_end(\n \tstruct rte_mbuf *new_data = __bnxt_alloc_rx_data(rxq->mb_pool);\n \tRTE_ASSERT(new_data != NULL);\n \tif (!new_data) {\n-\t\trte_atomic64_inc(&rxq->rx_mbuf_alloc_fail);\n+\t\t__atomic_fetch_add(&rxq->rx_mbuf_alloc_fail, 1, __ATOMIC_RELAXED);\n \t\treturn NULL;\n \t}\n \ttpa_info->mbuf = new_data;\n@@ -1369,7 +1369,8 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)\n \t\t\t\trxr->tpa_info[i].mbuf =\n \t\t\t\t\t__bnxt_alloc_rx_data(rxq->mb_pool);\n \t\t\t\tif (!rxr->tpa_info[i].mbuf) {\n-\t\t\t\t\trte_atomic64_inc(&rxq->rx_mbuf_alloc_fail);\n+\t\t\t\t\t__atomic_fetch_add(&rxq->rx_mbuf_alloc_fail, 1,\n+\t\t\t\t\t\t\t__ATOMIC_RELAXED);\n \t\t\t\t\treturn -ENOMEM;\n \t\t\t\t}\n \t\t\t}\ndiff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c\nindex 208aa5616d..72169e8b35 100644\n--- a/drivers/net/bnxt/bnxt_stats.c\n+++ b/drivers/net/bnxt/bnxt_stats.c\n@@ -578,7 +578,7 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n \n \t\tbnxt_fill_rte_eth_stats(bnxt_stats, &ring_stats, i, true);\n \t\tbnxt_stats->rx_nombuf +=\n-\t\t\t\trte_atomic64_read(&rxq->rx_mbuf_alloc_fail);\n+\t\t\t\t__atomic_load_n(&rxq->rx_mbuf_alloc_fail, __ATOMIC_RELAXED);\n \t}\n \n \tnum_q_stats = RTE_MIN(bp->tx_cp_nr_rings,\n@@ -632,7 +632,7 @@ int bnxt_stats_reset_op(struct rte_eth_dev *eth_dev)\n \tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n \t\tstruct bnxt_rx_queue *rxq = bp->rx_queues[i];\n \n-\t\trte_atomic64_clear(&rxq->rx_mbuf_alloc_fail);\n+\t\trxq->rx_mbuf_alloc_fail = 0;\n \t}\n \n \tbnxt_clear_prev_stat(bp);\n", "prefixes": [ "1/2" ] }