Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110362/?format=api
{ "id": 110362, "url": "http://patches.dpdk.org/api/patches/110362/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220427145821.5987-11-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220427145821.5987-11-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220427145821.5987-11-kalesh-anakkur.purayil@broadcom.com", "date": "2022-04-27T14:58:14", "name": "[10/17] net/bnxt: fix to handle queue stop during RSS flow create", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "313bd0f784846e2304da3a106ebb70aa94b9d3e3", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220427145821.5987-11-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 22696, "url": "http://patches.dpdk.org/api/series/22696/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22696", "date": "2022-04-27T14:58:04", "name": "bnxt PMD fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/22696/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/110362/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/110362/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A470BA034C;\n\tWed, 27 Apr 2022 16:59:47 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7C07F4282B;\n\tWed, 27 Apr 2022 16:58:45 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (lpdvsmtp11.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id F13D24281C\n for <dev@dpdk.org>; Wed, 27 Apr 2022 16:58:43 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 87D40C0000E8;\n Wed, 27 Apr 2022 07:58:42 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 87D40C0000E8", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1651071523;\n bh=MXwu1lx4KJO2HBRq8OJA7Ygmx4hNS4zlwNR0q8RLnxQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pKFCg5HjHJUJrFGCkZt4NtAxAiweyN1v0uRjQTkQghcF+cijjIEbgF3TNNf8J7WJr\n fHEW8rv4M7RUtNhEvZJOI3E3uSuDI8EGnbYqGuUWfQ2r1gH0hPQFB6yltQOyF+rqz8\n XrqOGf+ksJmE/h5LSChuABsUW13wV7CbPMULzskQ=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ajit.khaparde@broadcom.com", "Subject": "[PATCH 10/17] net/bnxt: fix to handle queue stop during RSS flow\n create", "Date": "Wed, 27 Apr 2022 20:28:14 +0530", "Message-Id": "<20220427145821.5987-11-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20220427145821.5987-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20220427145821.5987-1-kalesh-anakkur.purayil@broadcom.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nThe programming of the RSS table was not taking into account if\nany of the queues in the set were stopped prior to the flow\ncreation, hence leading to a vnic RSS config cmd failure thrown by\nthe FW.\nFix by programming only the active queues in the RSS action queue\nset.\n\nFixes: 239695f754cb (\"net/bnxt: enhance RSS action support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex fc5bacf..f8e1096 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -1115,7 +1115,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,\n \t\t\t struct rte_flow_error *error)\n {\n \tconst struct rte_flow_action_rss *rss;\n-\tunsigned int rss_idx, i, j;\n+\tunsigned int rss_idx, i, j, fw_idx;\n \tuint16_t hash_type;\n \tuint64_t types;\n \tint rc;\n@@ -1232,11 +1232,21 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,\n \t\tgoto skip_rss_table;\n \n \t/* Prepare the indirection table */\n-\tfor (rss_idx = 0; rss_idx < HW_HASH_INDEX_SIZE; rss_idx++) {\n+\tfor (rss_idx = 0, fw_idx = 0; rss_idx < HW_HASH_INDEX_SIZE;\n+\t rss_idx++, fw_idx++) {\n+\t\tuint8_t *rxq_state = bp->eth_dev->data->rx_queue_state;\n \t\tstruct bnxt_rx_queue *rxq;\n \t\tuint32_t idx;\n \n-\t\tidx = rss->queue[rss_idx % rss->queue_num];\n+\t\tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n+\t\t\tidx = rss->queue[fw_idx % rss->queue_num];\n+\t\t\tif (rxq_state[idx] != RTE_ETH_QUEUE_STATE_STOPPED)\n+\t\t\t\tbreak;\n+\t\t\tfw_idx++;\n+\t\t}\n+\n+\t\tif (i == bp->rx_cp_nr_rings)\n+\t\t\treturn 0;\n \n \t\tif (BNXT_CHIP_P5(bp)) {\n \t\t\trxq = bp->rx_queues[idx];\n", "prefixes": [ "10/17" ] }