Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 110229,
    "url": "http://patches.dpdk.org/api/patches/110229/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220425092523.52338-2-lihuisong@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220425092523.52338-2-lihuisong@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220425092523.52338-2-lihuisong@huawei.com",
    "date": "2022-04-25T09:25:22",
    "name": "[V1,1/2] app/testpmd: fix supported RSS offload display",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "f5ebab5fb1f987a936e87452829c1c0c468f3736",
    "submitter": {
        "id": 2085,
        "url": "http://patches.dpdk.org/api/people/2085/?format=api",
        "name": "lihuisong (C)",
        "email": "lihuisong@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220425092523.52338-2-lihuisong@huawei.com/mbox/",
    "series": [
        {
            "id": 22657,
            "url": "http://patches.dpdk.org/api/series/22657/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22657",
            "date": "2022-04-25T09:25:23",
            "name": "fix RSS types display",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/22657/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/110229/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/110229/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3352A00BE;\n\tMon, 25 Apr 2022 11:26:29 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 96C05427FD;\n\tMon, 25 Apr 2022 11:26:19 +0200 (CEST)",
            "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 592E941132\n for <dev@dpdk.org>; Mon, 25 Apr 2022 11:26:16 +0200 (CEST)",
            "from kwepemi500012.china.huawei.com (unknown [172.30.72.57])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Kn03k5XRLz1JBgj;\n Mon, 25 Apr 2022 17:25:22 +0800 (CST)",
            "from kwepemm600004.china.huawei.com (7.193.23.242) by\n kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Mon, 25 Apr 2022 17:26:13 +0800",
            "from localhost.localdomain (10.69.192.56) by\n kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Mon, 25 Apr 2022 17:26:13 +0800"
        ],
        "From": "Huisong Li <lihuisong@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <huangdaode@huawei.com>,\n <lihuisong@huawei.com>",
        "Subject": "[PATCH V1 1/2] app/testpmd: fix supported RSS offload display",
        "Date": "Mon, 25 Apr 2022 17:25:22 +0800",
        "Message-ID": "<20220425092523.52338-2-lihuisong@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20220425092523.52338-1-lihuisong@huawei.com>",
        "References": "<20220425092523.52338-1-lihuisong@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.69.192.56]",
        "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemm600004.china.huawei.com (7.193.23.242)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "And rte_eth_dev_info.flow_type_rss_offloads is populated in terms of\nRTE_ETH_RSS_* bits. If PMD sets RTE_ETH_RSS_L3_SRC_ONLY to\ndev_info->flow_type_rss_offloads. testpmd will display \"user defined 63\"\nwhen run 'show port info 0'. Because testpmd use flowtype_to_str()\nto display the supported RSS offload of PMD. In fact, the function is\nused to display flow type in FDIR commands. This patch uses the\nRTE_ETH_RSS_* bits to display supported RSS offload of PMD.\n\nFixes: b12964f621dc (\"ethdev: unification of RSS offload types\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n app/test-pmd/config.c | 30 ++++++++++++++++--------------\n 1 file changed, 16 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex cc8e7aa138..f58da01a3a 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -669,6 +669,20 @@ print_dev_capabilities(uint64_t capabilities)\n \t}\n }\n \n+static void\n+show_rss_types(uint64_t rss_hf)\n+{\n+\tuint16_t i;\n+\n+\tfor (i = 0; rss_type_table[i].str; i++) {\n+\t\tif (rss_type_table[i].rss_type == 0)\n+\t\t\tcontinue;\n+\t\tif ((rss_hf & rss_type_table[i].rss_type) == rss_type_table[i].rss_type)\n+\t\t\tprintf(\"%s \", rss_type_table[i].str);\n+\t}\n+\tprintf(\"\\n\");\n+}\n+\n void\n port_infos_display(portid_t port_id)\n {\n@@ -773,20 +787,8 @@ port_infos_display(portid_t port_id)\n \tif (!dev_info.flow_type_rss_offloads)\n \t\tprintf(\"No RSS offload flow type is supported.\\n\");\n \telse {\n-\t\tuint16_t i;\n-\t\tchar *p;\n-\n-\t\tprintf(\"Supported RSS offload flow types:\\n\");\n-\t\tfor (i = RTE_ETH_FLOW_UNKNOWN + 1;\n-\t\t     i < sizeof(dev_info.flow_type_rss_offloads) * CHAR_BIT; i++) {\n-\t\t\tif (!(dev_info.flow_type_rss_offloads & (1ULL << i)))\n-\t\t\t\tcontinue;\n-\t\t\tp = flowtype_to_str(i);\n-\t\t\tif (p)\n-\t\t\t\tprintf(\"  %s\\n\", p);\n-\t\t\telse\n-\t\t\t\tprintf(\"  user defined %d\\n\", i);\n-\t\t}\n+\t\tprintf(\"Supported RSS offload:\\n\");\n+\t\tshow_rss_types(dev_info.flow_type_rss_offloads);\n \t}\n \n \tprintf(\"Minimum size of RX buffer: %u\\n\", dev_info.min_rx_bufsize);\n",
    "prefixes": [
        "V1",
        "1/2"
    ]
}