Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110068/?format=api
{ "id": 110068, "url": "http://patches.dpdk.org/api/patches/110068/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220422035100.3180870-10-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220422035100.3180870-10-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220422035100.3180870-10-g.singh@nxp.com", "date": "2022-04-22T03:50:56", "name": "[10/14] crypto/dpaa2_sec: fix crypto op pointer for atomic and ordered queues", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f5d523b04323de7fd6d1aedb35006c7b794af667", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220422035100.3180870-10-g.singh@nxp.com/mbox/", "series": [ { "id": 22607, "url": "http://patches.dpdk.org/api/series/22607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22607", "date": "2022-04-22T03:50:47", "name": "[01/14] crypto/dpaa2_sec: fix fle buffer leak", "version": 1, "mbox": "http://patches.dpdk.org/series/22607/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/110068/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/110068/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B61D9A0093;\n\tFri, 22 Apr 2022 05:52:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6F4574282B;\n\tFri, 22 Apr 2022 05:51:55 +0200 (CEST)", "from EUR02-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr20062.outbound.protection.outlook.com [40.107.2.62])\n by mails.dpdk.org (Postfix) with ESMTP id 97BF24281D;\n Fri, 22 Apr 2022 05:51:53 +0200 (CEST)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by DB7PR04MB4393.eurprd04.prod.outlook.com (2603:10a6:5:32::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr\n 2022 03:51:51 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022\n 03:51:51 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=BYRRRHBkdkPAnQTT6XWc1u1hVYfef6F4/r1Jree6lg80Hvibt97w0LtgX7Fo8Lc+BGDtO7irlK/TWSroHkksJNN4GC3P5DUM/xnh7TyKnd1FL+KfeGTrmYc3lo1bh6Hmu0iceushijdMS5QtapoVHsJ9y29UQXQEr931kOSnAnuxoP6aBSZDZ8NhUQ3FdxZGsS9RuaJiPoiJgJCgDtTmSJFCaHxSKTdWWWWbjunhZMz+gHFEJXoyEeq38H9tIscvaIYVOwAo07odWnws9tQoWFc0H1AGJOpB9YMUk5SsjC3ZV+oSLzG6ExPlMCiI1AUvL99z0iv84NtME8sZjXfAbg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Dz//mqu7oLsKSg/JuFhgLjf7kXvq96wFh1dYJERsBfQ=;\n b=GdYlhgdfSI1ifn2u5vbJ4JDb7Lm/CGFU2JAhGfrN0nDwJ/uGsgdQRVBJfkXndTUA+Nf9awlkO554WR2AsEW0sMtFqvFeKbzw4IZ9+hcW6iuHf3qGCfDb+95iahYUYUuBb57xgxdMQFSmdm7XRu1d29m4rG0LiPUXP5LEsKK5wxOZthNV2viaFCjSAAZTLxP1YVhWBLMsSSdgQiSiBpK0n0aWb/cbJOdOJQh5FoYs5Hn23VUyr4qxATS0eL4Dyay7DaBirLZnxEquzpuhwJiEhYCXQOtPTGmrVwyl1CmHMZPsiLxqhT/Bww+JifaYtzH0KnS0HllNDrFdZDlEzmPQzw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Dz//mqu7oLsKSg/JuFhgLjf7kXvq96wFh1dYJERsBfQ=;\n b=BWjRONWosC+xjFGjVI2V2c3yUuX/fxxDd6AqF5iLvGE/fy5b+TCFXT/Y/Cqz01/LMhBQDKDfeqg9sUZL0MxtzrIFJDiAOGmAvhI4lmGVNT/wJti3CGNMoWm5nbT35SRzK1hnvxCQT4SD21Wjizf273APUAXQQRgqaqI17NhDJm8=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "gakhil@marvell.com,\n\tdev@dpdk.org", "Cc": "Gagandeep Singh <g.singh@nxp.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 10/14] crypto/dpaa2_sec: fix crypto op pointer for atomic and\n ordered queues", "Date": "Fri, 22 Apr 2022 09:20:56 +0530", "Message-Id": "<20220422035100.3180870-10-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220422035100.3180870-1-g.singh@nxp.com>", "References": "<20220422035100.3180870-1-g.singh@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR03CA0127.apcprd03.prod.outlook.com\n (2603:1096:4:91::31) To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "21a0cd7d-0519-42b1-4759-08da24136f23", "X-MS-TrafficTypeDiagnostic": "DB7PR04MB4393:EE_", "X-Microsoft-Antispam-PRVS": "\n <DB7PR04MB43939C24B9C4955758C40DF9E1F79@DB7PR04MB4393.eurprd04.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n cF++kN0FhLW+JYHmKQBFBB1rchyR84a7674P99z/AyLYAe1UEFnc5cPxX50W8Pn+AZwtUPrt5bAtmEkf/FLJe9mz7jWCzb/W7km8EkQexZCH3jVhwgK0P8LJraaABsgKFHcbCu2LCkendJlzPeDPjXADzhCY2XZUMtscyREdLyPrG2S4lBKuZ4cPeyZaPloyenMqU/z0/Nu19zDZWH7BiT/XOgd5yqOp9EZIV2TKnHF2K7K/TW6hDZT4M+A/T28DE1sWtQqGm6PfNDek1YCi74GE3QEQjJNhby3u7vt7nQwMXYqoA++KCICXpjMeGjWH+zoQ74bRDANVxgCc5o+rv3Km9TCL+FeCHVnYJvQMJOLz+z7C6wfLLKKPD/tJxbHZSSw15l1hbKiE0Gcqq7HtcpG3nuAwyFS1VgB3D1D24XUgCEq2nJcpCE+ulz1giWRNEck4UExWF1SN+wvvkl09OHjh3Ws4DthpleRCXyU/hWJnUYrWkoPQ3RCrXknGczfgl278fk4QK/Vat4EqWD1eizaNgBFFOGUNvc9yaRwxFg8Ue+xoR/dOSv6tY589Y6DnuI3/V18Hl46gauqC577OnoNh7xUrDBPaOuq4YyP5goUsULiFLkP+qVGqeHzSDsXzhIJvzy2vjbE1GkVTWFk5RH3/J3UcgL3VDiI0PBbkpoMKkuUks+uv/xpirmPOyVSvA2rLN4sbspzMGXGgQQui7A==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(4636009)(366004)(5660300002)(36756003)(2616005)(6486002)(1076003)(8936002)(86362001)(316002)(52116002)(66946007)(26005)(6506007)(6512007)(186003)(66556008)(66476007)(83380400001)(38350700002)(38100700002)(508600001)(4326008)(55236004)(2906002)(8676002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n TlS9wHK+vC2ydte9TtnMO4lGcbwrXZLTfU+7vKpdNP4/uOspnsRmRUE3pOxXmXN7dX4QnSvNGJlyI7tIPU/WrS3979noDOhWDAzQhhD2xg7mmG8iFwwyx/ZS+Kznlyn6H58Iye3O+sq1ZnO233sQ8rJz+8syqaRdpLFTgd2So1FffsNZRXRD5YNdzX6CfSQqjNBFIOZq/Meldu1s3fsUu/LEKj4XRlPPdaXQi8hu0SJI1lbQ0eFSbaovVzvsxdmKNNjR9eto+PItXJmtDMu7lqHzyq2OAtaTahClpWMdcKPDEy2De6xHwdRX9BF8Q6Q7Iw7exCc3Z6/8tgQ/9oDxoeV9SYKHTphkWEv9bxMbOYDZ32+FlUyDn0gLNvtewUMe6MHedcnTub/dTdizRY1zlT4pm53bfGGo4ALl/DTt5C+mjKHyiVHP2Ux6FVIUweXtBE2sQtTG8ZpJUziZbGbHWaEXxxj8EdvsyJBWlO8o4orvoHwEwpzwKkQuxAO/wxnsSDi6S7E+kSTPIhCtZj38ZPqg+YTfc7nr5L2zvO4yI2s3IFUWHg7MGisHAnSWtjriMebbwbjAUsEEwYNMl+KyRQrEbyqbArgRy3KGSWRnmW8kfevMGGJgOHubJkqjrSyzTAqG+JGZ/vnQCaNzJPKn89khvlAnGd6ZiZDXoCkBPJKsEnigwSpQROaIIypDjOGg1awQvYn3KXCKHb35zzWUCIhbpQ6gQnMv1U+JdEyQqvaCDKmpKB/XG3w2yTg3iTNPcWWQMqvjNOwbGVywqsNVJSnPwgmAkAGFyNGAWtRJ9Z687UHEylBodcNJzhhfu+JcABN456ML4eVf4eiderMKoTpFcaNNHcmnX+Pp5P7AZBaZwzmWLut7ENaiAV/rB1/2TDNLLrlQta5pK4a2SufPw8alFo79XyJ2tfhIGpXij3jSFm1rK7+gqfnycryu7cWXb9/h8/+e+LnvyTh8i35zxgfXMa5Z4kx9OW4ZozlMuK4zvJrO9XpbrjWcxDn/fk5IGoIUBfKsG0RovO3sO4o4vPpleo9HEWNFNj43fjNKktg2coDP3+c/o5k5Vh5lvsKzYyJItA9r5yzbFY3UjEF3lBQwoNw2bsOtwckuck0XtfsizvtBw1z8l2PwpcoCnqmqBvRNAw2bw8h0PvemlJ3h353N7NfgfU3mqqpeqCbws8lgl8kGeNl/padSOA3EU8Im//83oSV8bsdUVJuzpKOgv/SkiXpPZuuxdElOVW1UHKH028WiyqBxGYgRRIq53mJfpT6aaB4k3i+H5wG5aODEfffichYloD/JwqlgFUV6V5i0K/QvNolpmtifbP9yzH6PvGf4CbohnBQTXh5wS0cQ+J30NFrraL/dh9QZmd6VzrlNYe2pkFWJB5/FyJcrUH8RhkOQnD2LA1Af7igYN9INTYBL17uAiG09PKxVgkkoEhvCkYQ7teZAiOzGrAbL9iXOLBl03wZDiYjevlA6x8nsQri6Mvh50UUnzik8aHLN5vJrdlCYHXukutvsEfe1nSl24/+18e6DIHosf4KZGG73YH3sgMd3SYVuZExLXWHSZe/YHcAaNShdFcizD1nkHyhRvu4z6Ig/pfMyZzPdn8gt/XmuBJL4lifpsGWBQLPSP/TIPGXYgJzUla2DiNieMviz5wwExgxyeIGOkPutmQV5av6RyEJVeQm49eC2vRiX2sUCtKO7gHq6HMvu1z3K1szZnaA7dd3UICq3PXaYQDRnfg==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 21a0cd7d-0519-42b1-4759-08da24136f23", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Apr 2022 03:51:51.6407 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n WFpSCpKShL6iKqjaWoCGGLxl7zapf97vMbT1iX0F6sfbGkj7wHiTd8jJxzhbG0bl", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR04MB4393", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Driver is filling the crypto_op variable with an invalid value\nwhich can results into segmentation fault.\n\nThis patch assigning the correct crypto_op and event buffer\npointers by extracting from FD.\n\nFixes: a77db24643b7 (\"crypto/dpaa2_sec: support atomic queues\")\nFixes: 4562de326d30 (\"crypto/dpaa2_sec: support ordered queue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 86c8df241b..9f2b384af9 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -4019,7 +4019,7 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *swp __rte_unused,\n {\n \tuint8_t dqrr_index;\n \tstruct dpaa2_sec_qp *qp;\n-\tstruct rte_crypto_op *crypto_op = (struct rte_crypto_op *)ev->event_ptr;\n+\tstruct rte_crypto_op *crypto_op;\n \t/* Prefetching mbuf */\n \trte_prefetch0((void *)(size_t)(DPAA2_GET_FD_ADDR(fd)-\n \t\trte_dpaa2_bpid_info[DPAA2_GET_FD_BPID(fd)].meta_data_size));\n@@ -4036,12 +4036,13 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *swp __rte_unused,\n \tev->queue_id = rxq->ev.queue_id;\n \tev->priority = rxq->ev.priority;\n \n-\tev->event_ptr = sec_fd_to_mbuf(fd, qp);\n+\tcrypto_op = sec_fd_to_mbuf(fd, qp);\n \tdqrr_index = qbman_get_dqrr_idx(dq);\n \t*dpaa2_seqn(crypto_op->sym->m_src) = QBMAN_ENQUEUE_FLAG_DCA | dqrr_index;\n \tDPAA2_PER_LCORE_DQRR_SIZE++;\n \tDPAA2_PER_LCORE_DQRR_HELD |= 1 << dqrr_index;\n \tDPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) = crypto_op->sym->m_src;\n+\tev->event_ptr = crypto_op;\n }\n \n static void __rte_hot\n@@ -4051,7 +4052,7 @@ dpaa2_sec_process_ordered_event(struct qbman_swp *swp,\n \t\t\t\tstruct dpaa2_queue *rxq,\n \t\t\t\tstruct rte_event *ev)\n {\n-\tstruct rte_crypto_op *crypto_op = (struct rte_crypto_op *)ev->event_ptr;\n+\tstruct rte_crypto_op *crypto_op;\n \tstruct dpaa2_sec_qp *qp;\n \n \t/* Prefetching mbuf */\n@@ -4069,7 +4070,7 @@ dpaa2_sec_process_ordered_event(struct qbman_swp *swp,\n \tev->sched_type = rxq->ev.sched_type;\n \tev->queue_id = rxq->ev.queue_id;\n \tev->priority = rxq->ev.priority;\n-\tev->event_ptr = sec_fd_to_mbuf(fd, qp);\n+\tcrypto_op = sec_fd_to_mbuf(fd, qp);\n \n \t*dpaa2_seqn(crypto_op->sym->m_src) = DPAA2_ENQUEUE_FLAG_ORP;\n \t*dpaa2_seqn(crypto_op->sym->m_src) |= qbman_result_DQ_odpid(dq) <<\n@@ -4078,6 +4079,7 @@ dpaa2_sec_process_ordered_event(struct qbman_swp *swp,\n \t\tDPAA2_EQCR_SEQNUM_SHIFT;\n \n \tqbman_swp_dqrr_consume(swp, dq);\n+\tev->event_ptr = crypto_op;\n }\n \n int\n", "prefixes": [ "10/14" ] }