Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110059/?format=api
{ "id": 110059, "url": "http://patches.dpdk.org/api/patches/110059/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220422035100.3180870-1-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220422035100.3180870-1-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220422035100.3180870-1-g.singh@nxp.com", "date": "2022-04-22T03:50:47", "name": "[01/14] crypto/dpaa2_sec: fix fle buffer leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "94b016de97a5f01be5b3a1806fba95c0e234c015", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220422035100.3180870-1-g.singh@nxp.com/mbox/", "series": [ { "id": 22607, "url": "http://patches.dpdk.org/api/series/22607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22607", "date": "2022-04-22T03:50:47", "name": "[01/14] crypto/dpaa2_sec: fix fle buffer leak", "version": 1, "mbox": "http://patches.dpdk.org/series/22607/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/110059/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/110059/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F4F9A0093;\n\tFri, 22 Apr 2022 05:51:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 16F3340042;\n\tFri, 22 Apr 2022 05:51:38 +0200 (CEST)", "from EUR02-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr20073.outbound.protection.outlook.com [40.107.2.73])\n by mails.dpdk.org (Postfix) with ESMTP id C68BF40040;\n Fri, 22 Apr 2022 05:51:36 +0200 (CEST)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by DB7PR04MB4393.eurprd04.prod.outlook.com (2603:10a6:5:32::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr\n 2022 03:51:34 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022\n 03:51:34 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=fOoWFPpgsUFQkshZDoW6bfBf5fjTZY+XTyza3JqQ8ADmYBJk4cJ/LzQFfsM5+6p32LI3J9R2k4NwfJGWtUIN12hrYQ4mR6pLTeJ+hdgTxjG3cynnt3ufSdfeakTCyh6NeAAfouqx9ScCxnuSAaiC8ymG4h2czEpph6vfPc+BJMfJseElOlKXersq3h6+20vZRM48Cg4J7DgJLfWWBAD9rvh9G2Qf6mZmmQ9FSmd+l9v4penYnk+OUJzD9IL7f8F7WSjdNgVWoW6QMC4+amCfcRcu0uYXtzXQ/M+vTCACPHye90WYIZ+Q1j+MaCLYQAujiTD6JgQZ9wlljPDy/1PVIA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=p+a7KecN5Z2EEVBEbz2aUJmdrDZ8vMxnooBIv/ddyZQ=;\n b=kXosvowix25zQYkW7mr4Rw5prVR821lukT4fAjQp+KECTLZouE6w6Jn4Dth3xPWLlFC8M7QD8fCpb6JWfmbedvmfrGL+93CBk/0xy/j4Bn4GtQjqwkLlK9+WbqlGlk+TkRLXY4UqKnjyj7p+yxlJajq/8JrUwgCi3iDV9N99Fgs4dqOG3XWi2x8GisbiQk9OL4xVrU5GYZqjMniru1qVE1g5zMpftqt+iKB5Nk+9jLDxP2yTMt36dpcmnI0eb7GWJeBcxnwrbQ7SX/cFEWCli3qnNOH/9hjpGnqWd4Wfk5TYLvPIPBU80JVUovZ58sLNAVQCoyWLjqxxXl2ZsBJ2kQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=p+a7KecN5Z2EEVBEbz2aUJmdrDZ8vMxnooBIv/ddyZQ=;\n b=N6HYhzcrSK4WGELdwZPCxiH5rU/XGzvBAfGixZA8LcApws0o5k/UqWIfuG2irbJWfamlmM9vPYlONjG8otu7Fg2kd3v1fwVRllw6gxfrLI44muLEYl6yZgHls7Sq1h+m5nIZfe7WHW9mdjgX34jHABLAcG65hqMkj5uyTXvSiEA=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "gakhil@marvell.com,\n\tdev@dpdk.org", "Cc": "Gagandeep Singh <g.singh@nxp.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 01/14] crypto/dpaa2_sec: fix fle buffer leak", "Date": "Fri, 22 Apr 2022 09:20:47 +0530", "Message-Id": "<20220422035100.3180870-1-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR03CA0127.apcprd03.prod.outlook.com\n (2603:1096:4:91::31) To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "4279f60f-8203-461b-24a2-08da241364e1", "X-MS-TrafficTypeDiagnostic": "DB7PR04MB4393:EE_", "X-Microsoft-Antispam-PRVS": "\n <DB7PR04MB43939756B9C2980CFC5851D5E1F79@DB7PR04MB4393.eurprd04.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n H20mqTMFElppTpYddWwXDCWyIbMY5NNffQgBVi5ZYsNjirmooS4mKp35GKQ61pdFenRLpVpUi3GYEiFpN3rJx938nLyeho90T21o8BhQjZQVSNtvYG4/fqlEt4iZVwaAEuEyVjwk5iq999fDofcOn0PlS2iQdfbJOk3Kv29Ev4Ly8hWfmVnpi+j1u6RXFHLc6p0DCn+LbGr+UtmPPRa/R6yCY6q22rOdGQIx8ToFKcYbirtIu+ejJE18YP/1DLLAGNPYhheVHCtfn/6XiGVgNP5BfgMQVUFQ6Yd2By//ypn7kS+XZmEK5H1XGuPITotsPbG2nwUuITCL0vMJ6aB1KlLxAi3WhdJSMsaSIOsoC59UDo5I88JHSOD9Z6mlZi/DLRXfKdSbUCAFkampdeyguiSPjfpwGPPBioqsg7xpsdlnbTCV1PWQ4H4r4BLJDeNbahDgfV/KCgP/lYxAwg8hdFvD+8CiPs/Kg6jQXKrbIEZyFgvuw3ffeCvO2HWHqhGJSASJIOK3QrzjBQl+5cD7yhzBYyU4Xa07Xyk0BlYBy310SjNed4x8Vc4KqpRNsWYaZN4tvFR85tyOOQvoktl9h/xfANT8Gv4ne8ofaaf+XmNxCXEF0IiTKlEtZPGgdXD1cqdkUCyaTKay4WcwljgIZhgPrtSKhpT5W+XRnv0Bw3Y/kgSl0q84Ec8sMNSpH6++rWmg5cyowOxPz84c7yag0g==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(4636009)(366004)(5660300002)(36756003)(2616005)(6486002)(1076003)(8936002)(86362001)(316002)(52116002)(66946007)(26005)(6506007)(6512007)(186003)(66556008)(6666004)(66476007)(83380400001)(38350700002)(38100700002)(508600001)(4326008)(55236004)(2906002)(8676002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n YIskaCMU41rj9l7ztHnf9zIpcceA5GVdrLp/PQEsVHCgu8PKDWYuaTc5pnCg5OUXVdYgVBsqXhWAZi6OWJRjLh6XavOTEfUh3+mwq0ugOP1uQY5kfX/NTh3AmaMcg7QndvAsPFUU2BZ0OAshfR2Sr6BPhjWTtTHRnw7wH0IRpLSuk01Xrw2a0j47PHEWJqy4YvCUCVSOGgrjiRN9AtweD0YbxqzVItBlbHkrNNWHOoBJ7FVhLRNrfce6CXOt95kwWV+/mlo47TZn12Qs4s0l0iG+SffKmkdiU6JivqPD0x9IDzshsdYVHJh6SAtC1t/SxSgEvwRDO6nsy6F/2zDq6eO1W38C4KFCsggrTsWRo7g0xYlHvGxDrAk4X2iOWC87BUYg6kf3+oztrJkP33wknqdVffUa1Ajapj5tyGSuGtdqjgJgVjB1EZDkCIFmfNtmn1OsLU/SAw9d10HdfJ5rniim4zUgMURFY4WI8WAvCZEOD4HqqDsJOms8/G00DB8tqgbJ2e7WGFQCt3cALXNyFQnI7BGTWaqDstSop2O8aNgVRWKfawclCjdpaH/Z8lSSk0mpDL44fEZVEk3THXiHuFZqM6q8Z++G/1QqH1zJNXujQ8n/OPz/2IlY9ew2YUR9z2/Xq4VLVlRha9Cmky5u/0FqbIpz+/RxeVqFUQXCsg27rafjFl0uRjt3R2G3CCS5qTXxZCcYHFJEcobo/4fww+7ZoxCDXgZLoibDb/QpppOnWv+lUPyI5V2ZJcPyN0jorivjwCpmwijDF9IV0fdufBWojiAWbiMZqIY90PpAXq3zEcZKe1WwxOhyC+InhVHWTBxMMCHNItvtxyL5XD8dSk7qMULQUqTwVjWBCurEUMRBd337Flk/tFA+hyoxOH+P45HLW6isf2aL4ki1tr/cOmZW4N3mqX/qkOq8JW8lyT4ZfGXpne+kz6eNW4ZqZ3SKAeHWy9iXZQgnbKarRWEUIKLzrQV0tKMbU6TTh/OxlpHoMsfGOfsbtytXZBkWMmhZ6r3L9QrWFenQSHk3ozKOWtcTVu3wLj7UqJG43fvUzU3NQnfvCtzTBrv1hhAXkTfyMsAj8kgUPG12drv/DeQC4jYP1uLFrQOlJ5pgYLsldIDiwWxsEZ2fXVl0glDdQUfMSzoBEggdgKFZKlFl3o4gwj0mlzfqfl9eHj1lpATERI5+zrN/wXRidLpuM0oH2aFXRlV2wFZbOUVeet8APdiZncVOlBNeDEya3FQxaECi84eYT4/muLUZvnTMMywTNMyMuyB2XnwbJvjAFUfb49LNkc+al9/s1/QINDVD4EjqzKOBGShGdamaQZG4Nvu7ZdqvCz5lazqJANnuXjichIiEJe5JQVwSt9ByuJvOZHlseA3AlHeiFeNOzFxfrj3Cuz5zuXeaRarJMg3LjKRL970sYOOQ1hYR8aeI0YxJ9TnRTYTXzuR6wckS0w8j8SDIwuO8vG/sseUctAtzLPpaz16u6VGiZzO2mYACHRSQyT065YHkn2OjSp+XSO9UWhHk8efFutLNLC+tlcpw1vk1K1PRMqnzuir6LBcKXUxinWxcJFBrlFeCGK1WaE7QRbeM7lbDbTc83t/k7vdimpKA2TpcNK2dsPLi6In0DrRt6B55FsxPfht+qVMl35vti69sHAGwMHoWP9t51T0mOQqgjQv5RJl9ixdyT5a1D1IfXd68Vrix4I1olDN8/ftc2WOY1vAXvSktoTysb/fuxxl5BVGKlg==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4279f60f-8203-461b-24a2-08da241364e1", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Apr 2022 03:51:34.5706 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n BQSG/eodOBFGbPtnAwAjS0KAPASMSwYL3IqByYZZ+LxmhzE6ReG76ZQ7Q/OZcUQQ", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR04MB4393", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Driver allocates a fle buffer for each packet\nbefore enqueue and free the buffer on dequeue. But in case if\nthere are enqueue failures, then code should free the fle buffers.\n\nFixes: b15cbf5b2d88 (\"crypto/dpaa2_sec: fix fle buffer leak\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 35 ++++++++++++++++++++-\n 1 file changed, 34 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex e62d04852b..03fef5e500 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2016-2021 NXP\n+ * Copyright 2016-2022 NXP\n *\n */\n \n@@ -64,6 +64,27 @@ enum dpaa2_sec_dump_levels {\n uint8_t cryptodev_driver_id;\n uint8_t dpaa2_sec_dp_dump = DPAA2_SEC_DP_ERR_DUMP;\n \n+static inline void\n+free_fle(const struct qbman_fd *fd)\n+{\n+\tstruct qbman_fle *fle;\n+\tstruct rte_crypto_op *op;\n+\tstruct ctxt_priv *priv;\n+\n+#ifdef RTE_LIB_SECURITY\n+\tif (DPAA2_FD_GET_FORMAT(fd) == qbman_fd_single)\n+\t\treturn;\n+#endif\n+\tfle = (struct qbman_fle *)DPAA2_IOVA_TO_VADDR(DPAA2_GET_FD_ADDR(fd));\n+\top = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));\n+\t/* free the fle memory */\n+\tif (likely(rte_pktmbuf_is_contiguous(op->sym->m_src))) {\n+\t\tpriv = (struct ctxt_priv *)(size_t)DPAA2_GET_FLE_CTXT(fle - 1);\n+\t\trte_mempool_put(priv->fle_pool, (void *)(fle-1));\n+\t} else\n+\t\trte_free((void *)(fle-1));\n+}\n+\n #ifdef RTE_LIB_SECURITY\n static inline int\n build_proto_compound_sg_fd(dpaa2_sec_session *sess,\n@@ -1513,6 +1534,12 @@ dpaa2_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops,\n \t\t\t\tif (retry_count > DPAA2_MAX_TX_RETRY_COUNT) {\n \t\t\t\t\tnum_tx += loop;\n \t\t\t\t\tnb_ops -= loop;\n+\t\t\t\t\tDPAA2_SEC_DP_DEBUG(\"Enqueue fail\\n\");\n+\t\t\t\t\t/* freeing the fle buffers */\n+\t\t\t\t\twhile (loop < frames_to_send) {\n+\t\t\t\t\t\tfree_fle(&fd_arr[loop]);\n+\t\t\t\t\t\tloop++;\n+\t\t\t\t\t}\n \t\t\t\t\tgoto skip_tx;\n \t\t\t\t}\n \t\t\t} else {\n@@ -1854,6 +1881,12 @@ dpaa2_sec_enqueue_burst_ordered(void *qp, struct rte_crypto_op **ops,\n \t\t\t\tif (retry_count > DPAA2_MAX_TX_RETRY_COUNT) {\n \t\t\t\t\tnum_tx += loop;\n \t\t\t\t\tnb_ops -= loop;\n+\t\t\t\t\tDPAA2_SEC_DP_DEBUG(\"Enqueue fail\\n\");\n+\t\t\t\t\t/* freeing the fle buffers */\n+\t\t\t\t\twhile (loop < frames_to_send) {\n+\t\t\t\t\t\tfree_fle(&fd_arr[loop]);\n+\t\t\t\t\t\tloop++;\n+\t\t\t\t\t}\n \t\t\t\t\tgoto skip_tx;\n \t\t\t\t}\n \t\t\t} else {\n", "prefixes": [ "01/14" ] }