Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108892/?format=api
http://patches.dpdk.org/api/patches/108892/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1648392699-60113-13-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1648392699-60113-13-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1648392699-60113-13-git-send-email-andy.pei@intel.com", "date": "2022-03-27T14:51:35", "name": "[v4,12/16] vdpa: add config space change interrupt register and handle for virtio_blk", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a94aa4526bf0052e8cd4c8b02c67f2f411375fcb", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1648392699-60113-13-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 22255, "url": "http://patches.dpdk.org/api/series/22255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22255", "date": "2022-03-27T14:51:23", "name": "add virtio_blk device support to vdpa/ifc", "version": 4, "mbox": "http://patches.dpdk.org/series/22255/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108892/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/108892/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 393A5A034C;\n\tSun, 27 Mar 2022 17:37:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1E0FB4289F;\n\tSun, 27 Mar 2022 17:36:10 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 9D62A42898\n for <dev@dpdk.org>; Sun, 27 Mar 2022 17:36:07 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2022 08:36:07 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.238])\n by orsmga008.jf.intel.com with ESMTP; 27 Mar 2022 08:36:05 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1648395367; x=1679931367;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=RpRN47JtxeCldxQ2ZS37Pc1lqLNGEQSPMI9x2X5IdVY=;\n b=K1H8//Ehp/RBAzvCxIScL9A2KuvWJKHKO84rs5h+aihp5lGy2mg4O/On\n LOPqfo+sICyDqbIQ1qxilQbnkQiVP+zhkSah7tw7/6eBA24wNHFPxMC5X\n yrPzL+Jm3Ul3YouBOESfBVENrP7hL76rbAMN6Cgds3G5i3WrqZl7iasgu\n 88K1wIRGD+RbQvBWyWodGnaJOErJVnSkQ9xB/pCu5hzMud6SKf0hU3ili\n fqUIf/v5tyHH5eGjNqzBNi/2U3XDKrvgVL02YOWoCW+Yle03JeQTwzg0r\n vRIhAptCZrtODObcm6ZbJW/dKW7aAtca0Heb1o0lqGrcWWWrSf/iM7bS2 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10299\"; a=\"259045665\"", "E=Sophos;i=\"5.90,215,1643702400\"; d=\"scan'208\";a=\"259045665\"", "E=Sophos;i=\"5.90,215,1643702400\"; d=\"scan'208\";a=\"562421580\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,\n changpeng.liu@intel.com", "Subject": "[PATCH v4 12/16] vdpa: add config space change interrupt register and\n handle for virtio_blk", "Date": "Sun, 27 Mar 2022 22:51:35 +0800", "Message-Id": "<1648392699-60113-13-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1648392699-60113-1-git-send-email-andy.pei@intel.com>", "References": "<1643093258-47258-2-git-send-email-andy.pei@intel.com>\n <1648392699-60113-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Create a thread to poll and relay config space change interrupt.\nUse VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to info qemu.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 113 ++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 113 insertions(+)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 20a0b01..826b408 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -53,7 +53,9 @@ struct ifcvf_internal {\n \tint vfio_group_fd;\n \tint vfio_dev_fd;\n \tpthread_t tid;\t/* thread for notify relay */\n+\tpthread_t intr_tid;\t/* thread for intr relay */\n \tint epfd;\n+\tint csc_fd;\n \tint vid;\n \tstruct rte_vdpa_device *vdev;\n \tuint16_t max_queues;\n@@ -608,6 +610,108 @@ struct rte_vdpa_dev_info {\n \treturn 0;\n }\n \n+static void\n+virtio_interrupt_handler(struct ifcvf_internal *internal)\n+{\n+\tint vid = internal->vid;\n+\tint ret;\n+\n+\tret = rte_vhost_slave_config_change(vid, 1);\n+\tif (ret)\n+\t\tDRV_LOG(ERR, \"failed to notify the guest about configuration space change.\");\n+\n+\treturn;\n+}\n+\n+static void *\n+intr_relay(void *arg)\n+{\n+\tstruct ifcvf_internal *internal = (struct ifcvf_internal *)arg;\n+\tstruct epoll_event csc_event;\n+\tstruct epoll_event ev;\n+\tuint64_t buf;\n+\tint nbytes;\n+\tint csc_fd, csc_val = 0;\n+\n+\tcsc_fd = epoll_create(1);\n+\tif (csc_fd < 0) {\n+\t\tDRV_LOG(ERR, \"failed to create epoll for config space change.\");\n+\t\treturn NULL;\n+\t}\n+\n+\tev.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP;\n+\tev.data.fd = rte_intr_fd_get(internal->pdev->intr_handle);\n+\tif (epoll_ctl(csc_fd, EPOLL_CTL_ADD,\n+\t\trte_intr_fd_get(internal->pdev->intr_handle), &ev) < 0) {\n+\t\tDRV_LOG(ERR, \"epoll add error: %s\", strerror(errno));\n+\t\treturn NULL;\n+\t}\n+\n+\tinternal->csc_fd = csc_fd;\n+\n+\tfor (;;) {\n+\t\tcsc_val = epoll_wait(csc_fd, &csc_event, 1, -1);\n+\t\tif (csc_val < 0) {\n+\t\t\tif (errno == EINTR)\n+\t\t\t\tcontinue;\n+\t\t\tDRV_LOG(ERR, \"epoll_wait return fail\\n\");\n+\t\t\treturn NULL;\n+\t\t} else if (csc_val == 0) {\n+\t\t\tcontinue;\n+\t\t} else {\n+\t\t\t/* csc_val > 0 */\n+\t\t\tnbytes = read(csc_event.data.fd, &buf, 8);\n+\t\t\tif (nbytes < 0) {\n+\t\t\t\tif (errno == EINTR || errno == EWOULDBLOCK)\n+\t\t\t\t\tcontinue;\n+\t\t\t\tDRV_LOG(ERR, \"Error reading from file descriptor %d: %s\\n\",\n+\t\t\t\t\tcsc_event.data.fd,\n+\t\t\t\t\tstrerror(errno));\n+\t\t\t\treturn NULL;\n+\t\t\t} else if (nbytes == 0) {\n+\t\t\t\tDRV_LOG(ERR, \"Read nothing from file descriptor %d\\n\",\n+\t\t\t\t\tcsc_event.data.fd);\n+\t\t\t\tcontinue;\n+\t\t\t} else {\n+\t\t\t\tvirtio_interrupt_handler(internal);\n+\t\t\t}\n+\t\t}\n+\t}\n+\treturn NULL;\n+}\n+\n+static int\n+setup_intr_relay(struct ifcvf_internal *internal)\n+{\n+\tint ret;\n+\n+\tret = pthread_create(&internal->intr_tid, NULL, intr_relay,\n+\t\t\t(void *)internal);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"failed to create notify relay pthread.\");\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n+unset_intr_relay(struct ifcvf_internal *internal)\n+{\n+\tvoid *status;\n+\n+\tif (internal->intr_tid) {\n+\t\tpthread_cancel(internal->intr_tid);\n+\t\tpthread_join(internal->intr_tid, &status);\n+\t}\n+\tinternal->intr_tid = 0;\n+\n+\tif (internal->csc_fd >= 0)\n+\t\tclose(internal->csc_fd);\n+\tinternal->csc_fd = -1;\n+\n+\treturn 0;\n+}\n+\n static int\n update_datapath(struct ifcvf_internal *internal)\n {\n@@ -634,10 +738,16 @@ struct rte_vdpa_dev_info {\n \t\tif (ret)\n \t\t\tgoto err;\n \n+\t\tret = setup_intr_relay(internal);\n+\t\tif (ret)\n+\t\t\tgoto err;\n+\n \t\trte_atomic32_set(&internal->running, 1);\n \t} else if (rte_atomic32_read(&internal->running) &&\n \t\t (!rte_atomic32_read(&internal->started) ||\n \t\t !rte_atomic32_read(&internal->dev_attached))) {\n+\t\tret = unset_intr_relay(internal);\n+\n \t\tret = unset_notify_relay(internal);\n \t\tif (ret)\n \t\t\tgoto err;\n@@ -958,6 +1068,9 @@ struct rte_vdpa_dev_info {\n \t\tvdpa_ifcvf_stop(internal);\n \telse if (internal->device_type == IFCVF_BLK)\n \t\tvdpa_ifcvf_blk_pause(internal);\n+\n+\tunset_intr_relay(internal);\n+\n \tvdpa_disable_vfio_intr(internal);\n \n \tret = rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, false);\n", "prefixes": [ "v4", "12/16" ] }{ "id": 108892, "url": "