Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108707/?format=api
{ "id": 108707, "url": "http://patches.dpdk.org/api/patches/108707/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220314055252.392004-1-ke1x.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220314055252.392004-1-ke1x.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220314055252.392004-1-ke1x.zhang@intel.com", "date": "2022-03-14T05:52:52", "name": "[v2] app/testpmd: fix issue with memory leaks when quit testpmd", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bfe719703c93b1ad99739f4ab7126e206a602411", "submitter": { "id": 2503, "url": "http://patches.dpdk.org/api/people/2503/?format=api", "name": "Zhang, Ke1X", "email": "ke1x.zhang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220314055252.392004-1-ke1x.zhang@intel.com/mbox/", "series": [ { "id": 22136, "url": "http://patches.dpdk.org/api/series/22136/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22136", "date": "2022-03-14T05:52:52", "name": "[v2] app/testpmd: fix issue with memory leaks when quit testpmd", "version": 2, "mbox": "http://patches.dpdk.org/series/22136/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108707/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/108707/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9AB0FA00BE;\n\tMon, 14 Mar 2022 06:59:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2ED5540DF4;\n\tMon, 14 Mar 2022 06:59:19 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 9C9CD40DDD\n for <dev@dpdk.org>; Mon, 14 Mar 2022 06:59:17 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Mar 2022 22:59:16 -0700", "from intel-corei7-64.sh.intel.com (HELO localhost.localdomain)\n ([10.239.251.104])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Mar 2022 22:59:14 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1647237557; x=1678773557;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=JN15BnLWIQurIDA0ZHau3fwTeU0jE0d0qg92n5MzSMA=;\n b=WUlEbSqy7Tr12N+kvX2hTOTeOwNFBqsV7jdqJ/KLnagjQwLKEISVusR+\n porTVdir90pVqCxfi+9hKJ1hp/UX09WQAa0seVDnwbyD5VIolHB/Ly9ri\n MJJ2w/+oZpgPknN1maqKCS1vX0x+HcIsB3oMKo+xoIKHSRkjSOJRza1WG\n PoRFVwiysoet8cWNOtW7fPcVi4jhASCmBnVF5/Xea1prVADXdY1YGJXG+\n rbzJmO4B+WCva3xnwxHjE9nadDT/AYBxrZ94ZFG9RVYHCxGqDB4QN9TYQ\n UAMML3pXVGi57JOSFMMpZj7YZiKBSApYJ/tPpq2yfT8f6VR/rxOGnJAma Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10285\"; a=\"255670691\"", "E=Sophos;i=\"5.90,179,1643702400\"; d=\"scan'208\";a=\"255670691\"", "E=Sophos;i=\"5.90,179,1643702400\"; d=\"scan'208\";a=\"539818666\"" ], "From": "Ke Zhang <ke1x.zhang@intel.com>", "To": "xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com,\n dev@dpdk.org", "Cc": "Ke Zhang <ke1x.zhang@intel.com>", "Subject": "[PATCH v2] app/testpmd: fix issue with memory leaks when quit testpmd", "Date": "Mon, 14 Mar 2022 05:52:52 +0000", "Message-Id": "<20220314055252.392004-1-ke1x.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220301020653.329263-1-ke1x.zhang@intel.com>", "References": "<20220301020653.329263-1-ke1x.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "when dpdk is compiled in ASan, there is a memory leaks after\nquit testpmd if set mcast_addr, this patch fix this issue.\n\nError info as following:\nERROR: LeakSanitizer: detected memory leaksDirect leak of\n 192 byte(s)\n0 0x7f6a2e0aeffe in __interceptor_realloc\n\t(/lib/x86_64-linux-gnu/libasan.so.5+0x10dffe)\n1 0x565361eb340f in mcast_addr_pool_extend\n\t../app/test-pmd/config.c:5162\n2 0x565361eb3556 in mcast_addr_pool_append\n\t../app/test-pmd/config.c:5180\n3 0x565361eb3aae in mcast_addr_add\n\t../app/test-pmd/config.c:5243\n\nSigned-off-by: Ke Zhang <ke1x.zhang@intel.com>\n---\n app/test-pmd/testpmd.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex fe2ce19f99..f7e18aee25 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3136,6 +3136,12 @@ close_port(portid_t pid)\n \t\t\tcontinue;\n \t\t}\n \n+\t\tif (port->mc_addr_nb != 0) {\n+\t\t\t/* free the pool of multicast addresses. */\n+\t\t\tfree(port->mc_addr_pool);\n+\t\t\tport->mc_addr_pool = NULL;\n+\t\t}\n+\n \t\tif (is_proc_primary()) {\n \t\t\tport_flow_flush(pi);\n \t\t\tport_flex_item_flush(pi);\n", "prefixes": [ "v2" ] }