Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108450/?format=api
{ "id": 108450, "url": "http://patches.dpdk.org/api/patches/108450/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220301165404.18936-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220301165404.18936-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220301165404.18936-2-david.marchand@redhat.com", "date": "2022-03-01T16:54:04", "name": "[2/2] devtools: use libabigail rule for mlx glue drivers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fd3bc8761c1b0519e7c5c0f8e9f5941d00932626", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220301165404.18936-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 21962, "url": "http://patches.dpdk.org/api/series/21962/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21962", "date": "2022-03-01T16:54:03", "name": "[1/2] devtools: remove event/dlb exception in ABI check", "version": 1, "mbox": "http://patches.dpdk.org/series/21962/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108450/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/108450/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AFB1AA034C;\n\tTue, 1 Mar 2022 17:54:26 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A1C9041177;\n\tTue, 1 Mar 2022 17:54:26 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 06C72426D2\n for <dev@dpdk.org>; Tue, 1 Mar 2022 17:54:24 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-478-zaLBfIFHOfivHYd4R8F3ow-1; Tue, 01 Mar 2022 11:54:19 -0500", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA6161091DA4;\n Tue, 1 Mar 2022 16:54:17 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.28])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 67164837BB;\n Tue, 1 Mar 2022 16:54:16 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1646153664;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oNXCCxaptl7oZ2BrqFOUgHRU3+ois22V11HkGFWPkU8=;\n b=WoEdMr2loQTlNnIh17Z44bczVci6sKsz+ES4uq50rxMyFzI+F3ovR5M90Zqb5/G6H4ctSh\n NOThbQTMXRV144/hdCuIQ6kmdcYA+r55wFwVXJ/gFsaU/Bu01/w5yQMisZfhp2PCmaHsaj\n Ii9QwZGbrOBDPITxvyELNET0PCuBVzU=", "X-MC-Unique": "zaLBfIFHOfivHYd4R8F3ow-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tRay Kinsella <mdr@ashroe.eu>", "Subject": "[PATCH 2/2] devtools: use libabigail rule for mlx glue drivers", "Date": "Tue, 1 Mar 2022 17:54:04 +0100", "Message-Id": "<20220301165404.18936-2-david.marchand@redhat.com>", "In-Reply-To": "<20220301165404.18936-1-david.marchand@redhat.com>", "References": "<20220301165404.18936-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Convert the existing exception in the ABI script into a libabigail\nsuppression rule.\n\nNote: file_name_regexp could be used to achive the same with versions of\nlibabigail < 1.7 but soname_regexp has been preferred here since it is\nalready used with a recent change on common/mlx5.\n\nWhile at it, fix indent from a recent change.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n devtools/check-abi.sh | 7 -------\n devtools/libabigail.abignore | 8 ++++++--\n 2 files changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\nindex 033f6252d0..64e148070d 100755\n--- a/devtools/check-abi.sh\n+++ b/devtools/check-abi.sh\n@@ -37,13 +37,6 @@ fi\n error=\n for dump in $(find $refdir -name \"*.dump\"); do\n \tname=$(basename $dump)\n-\t# skip glue drivers, example librte_pmd_mlx5_glue.dump\n-\t# We can't rely on a suppression rule for now:\n-\t# https://sourceware.org/bugzilla/show_bug.cgi?id=25480\n-\tif grep -qE \"\\<soname='[^']*_glue\\.so\\.[^']*'\" $dump; then\n-\t\techo \"Skipped glue library $name.\"\n-\t\tcontinue\n-\tfi\n \tif grep -qE \"\\<librte_*.*_octeontx2\" $dump; then\n \t\techo \"Skipped removed driver $name.\"\n \t\tcontinue\ndiff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore\nindex 301b3dacb8..9c921c47d4 100644\n--- a/devtools/libabigail.abignore\n+++ b/devtools/libabigail.abignore\n@@ -12,10 +12,14 @@\n [suppress_variable]\n name_regexp = _pmd_info$\n \n+; Ignore changes on soname for mlx glue internal drivers\n+[suppress_file]\n+ soname_regexp = ^librte_.*mlx.*glue\\.\n+\n ; Ignore fields inserted in place of reserved_opts of rte_security_ipsec_sa_options\n [suppress_type]\n- name = rte_security_ipsec_sa_options\n- has_data_member_inserted_between = {offset_of(reserved_opts), end}\n+ name = rte_security_ipsec_sa_options\n+ has_data_member_inserted_between = {offset_of(reserved_opts), end}\n \n ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental\n [suppress_type]\n", "prefixes": [ "2/2" ] }