Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108037/?format=api
http://patches.dpdk.org/api/patches/108037/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/tencent_864A4480E8E07EBF8FE88844C558F1E89C0A@qq.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_864A4480E8E07EBF8FE88844C558F1E89C0A@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_864A4480E8E07EBF8FE88844C558F1E89C0A@qq.com", "date": "2022-02-22T18:18:05", "name": "[07/20] net/bnx2x: add clean up for 'rxq' to avoid a memory leak", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1ea42fbcef7a07ca761e6ecf944e2a54cd0c0f54", "submitter": { "id": 2458, "url": "http://patches.dpdk.org/api/people/2458/?format=api", "name": "Weiguo Li", "email": "liwg06@foxmail.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/tencent_864A4480E8E07EBF8FE88844C558F1E89C0A@qq.com/mbox/", "series": [ { "id": 21799, "url": "http://patches.dpdk.org/api/series/21799/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21799", "date": "2022-02-22T18:17:58", "name": "fix memory leaks in error handling", "version": 1, "mbox": "http://patches.dpdk.org/series/21799/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108037/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/108037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D70DCA034E;\n\tTue, 22 Feb 2022 19:19:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D7CF04116D;\n\tTue, 22 Feb 2022 19:18:56 +0100 (CET)", "from out203-205-221-221.mail.qq.com (out203-205-221-221.mail.qq.com\n [203.205.221.221])\n by mails.dpdk.org (Postfix) with ESMTP id 58E104117A\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:18:55 +0100 (CET)", "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP\n id 49223207; Wed, 23 Feb 2022 02:18:18 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645553933;\n bh=HqIdzOC66tf+SUSFZ/B8pOEf1e68XxRDR13BoXlTK/c=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=ef0GWyNcsxyHgr3mjZEpGR5vDLk/qVhIZygcn4SbipExkuV7ve0GHZ0lfhzc22iZ/\n EQr9Qjxt7zKayWJGKENwovcr5vDGfEACngx5u7Di4a+yHWl3Tp4fOjcyMcVfpDPdU3\n hfDunZkRmEPRmPtSUYZkcIBRCeyHzLkDPOgz0emY=", "X-QQ-mid": "xmsmtpt1645553929tvlqfg5k0", "Message-ID": "<tencent_864A4480E8E07EBF8FE88844C558F1E89C0A@qq.com>", "X-QQ-XMAILINFO": "MJp4BpBFe1fJUT2+UQHG+XRlUNxL5Zljge7NTEP1a/EZOqsKmBVVfbHegP1bJE\n EHMhU92FlkcQmhDHx8u5mW40kGdvRPs1PaTafREn7IauYXkGLJBdSojXR4urBHOBC8G1LpidHa+b\n lTuYqFDwXP0UdMqx+DYC92e22K2+fHYGCH+wMQr+Rq/nZZSNZ3dLTH0tInb/gQe8aleR1s8OjS04\n D+Gd4qnZAr7J7cv1J0om6cgsv7rxoBlyNssu8nT0ba2s7NSHpYqxo9cS0Eo2YgpZWU1/HC4OXaOp\n okVkywqFXYAU2+EJ7qIa4qR56ksxla3b/Y4LUXLjvSzIS+mB/cTFSRkMJaOPXka3+qNFQqPkoeqh\n Va5ybSx9TyaJElwjWcf+T9aOy4CeMRR/W14fjx/Azj57YXcpDWBkk5OF9qlARy1IAw5L9LdQL98I\n NQLVz8rSdWPHJyfNHjVV0TH5CXI32BcHcqPuzGFUXyH89rgR/4oJxiWXTEjGwFqV7xh39B6/seUJ\n mR5tQ0Dv8ZyGlzeusEbvXWjK6aFf/VztAUHEm2gnLHxy03oZ2z8ynpxkUyuwKGepoHMwkPh7nmbW\n zK6zAv6FSLM+/Z3FFd/zC4KVQWjZvaTYHPaSIryGLxOrTfJMku5kT3JHXkcYmcjWOWPV7ON3aO4b\n vl90RDnKfZxjxRgXBAN/cem3RTjCA6HP7ItVCwjlhIzfcs3YLwBrTSkRB4y5jBU5tT/tTBk77BKl\n OoQIQT5RiZJSJEzCTDzjTvsREmFxJNiq/KJ3m8grUAypKdER0RNwvWNuCCjJrjFWQxegdlVND5Sb\n eT3Uat/Bkq3kW9jX1lGBvZZaC5XshKvrCNkPVLVPQvozq15rDrepIXFr4ti0A0Lku6u2SE9o04RA\n oL185UHd1Jo5i/xKoh/r7gMLZkHN4oaQ==", "From": "Weiguo Li <liwg06@foxmail.com>", "To": "dev@dpdk.org", "Cc": "adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,\n bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,\n hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,\n simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,\n shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,\n kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,\n declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com", "Subject": "[PATCH 07/20] net/bnx2x: add clean up for 'rxq' to avoid a memory\n leak", "Date": "Wed, 23 Feb 2022 02:18:05 +0800", "X-OQ-MSGID": "\n <fac77eab1c1164d86d3f83661ba2417ba0d7819d.1645551559.git.liwg06@foxmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1645551559.git.liwg06@foxmail.com>", "References": "<cover.1645551559.git.liwg06@foxmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This error handling miss a clean up for 'rxq' which leads to\na memory leak.\n\nFixes: 540a211084a7 (\"bnx2x: driver core\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\n drivers/net/bnx2x/bnx2x_rxtx.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c\nindex fbc0bb7698..9ad36000fb 100644\n--- a/drivers/net/bnx2x/bnx2x_rxtx.c\n+++ b/drivers/net/bnx2x/bnx2x_rxtx.c\n@@ -139,6 +139,7 @@ bnx2x_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \tdma = ring_dma_zone_reserve(dev, \"bnx2x_rcq\", queue_idx, dma_size, socket_id);\n \tif (NULL == dma) {\n \t\tPMD_RX_LOG(ERR, \"RCQ alloc failed\");\n+\t\tbnx2x_rx_queue_release(rxq);\n \t\treturn -ENOMEM;\n \t}\n \tfp->rx_comp_mapping = rxq->cq_ring_phys_addr = (uint64_t)dma->iova;\n", "prefixes": [ "07/20" ] }{ "id": 108037, "url": "