Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108028/?format=api
{ "id": 108028, "url": "http://patches.dpdk.org/api/patches/108028/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220222181146.28882-21-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222181146.28882-21-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222181146.28882-21-mk@semihalf.com", "date": "2022-02-22T18:11:45", "name": "[v2,20/21] net/ena: don't indicate bad csum for L4 csum error", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4ab6dcc05f3db5e177f5052be903eb1f2b914ab0", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220222181146.28882-21-mk@semihalf.com/mbox/", "series": [ { "id": 21798, "url": "http://patches.dpdk.org/api/series/21798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21798", "date": "2022-02-22T18:11:25", "name": "net/ena: v2.6.0 driver update", "version": 2, "mbox": "http://patches.dpdk.org/series/21798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108028/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/108028/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79466A034E;\n\tTue, 22 Feb 2022 19:14:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5DB88426E9;\n\tTue, 22 Feb 2022 19:12:42 +0100 (CET)", "from mail-ej1-f43.google.com (mail-ej1-f43.google.com\n [209.85.218.43]) by mails.dpdk.org (Postfix) with ESMTP id 15E1041184\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:12:40 +0100 (CET)", "by mail-ej1-f43.google.com with SMTP id bg10so45472037ejb.4\n for <dev@dpdk.org>; Tue, 22 Feb 2022 10:12:40 -0800 (PST)", "from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl.\n [89.79.181.52])\n by smtp.gmail.com with ESMTPSA id y21sm10610153eda.38.2022.02.22.10.12.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 22 Feb 2022 10:12:38 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=14NUlgp7/uwht08EEffkISHQVyhpeQZpdRvDSsgGcy4=;\n b=2R+AJZAfGma7fZBZysmBJjAxRkOcdofVYVvYVjIf1CnnLcRLfle6UihPzuo2IyuLZX\n 3etTb0PST6iilTw7irrDhPSxVSEC2As17vvY06ksJ6/Z99PcWRMAaV4ZnW8BLlGunX5T\n rwZVQ6SGCoxhuFzoaV4vHlGNo88GpyQRxVSL9n29zJlpLdb3ACotRSLOxHuuqQei/GK8\n B/mCuKdglrkahjbrEbZBzR2hMHli6tU4U8ANb6IBtOaE+/re4OVbfYtBM3nmXG/I8eOo\n VTFug1dOd0rEaWQr6B5DeIXgwRebZI1pUAVIyvsulhKXP6k45cVPboyWH3IG0ol9xgdL\n iIhw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=14NUlgp7/uwht08EEffkISHQVyhpeQZpdRvDSsgGcy4=;\n b=Zb2JVW3d7nktBwZ1c9oCi2FrbZW00g69qQAanmenOfl/waEc78KhgaH7Ar/so0oljq\n suQ8fL18Ulsnpqy9PR5XsC7EB5WwTyJb4bxtrpSgZspfN7SiHw7qYXW1dVa+YknpmejE\n 0E51K53Mu37yvCcIfxcwLW/tDlLF9QlIPLKPeGciTVo4GjoSiO14rITjXdQbMaHdA3bB\n hW1LnXNO0JT50u3HiDjsVtxlfFZEtJCl7Tv372Wt01E/5k23mfFl7VLYteffv0SgImYy\n fDpEAIj76WgPtaJoVsOKw60IVV80OSqgYYgaMqTCHegG/Ju80GJBbEO91jbyB2PMklye\n lSdA==", "X-Gm-Message-State": "AOAM532axv1S34fnfF14ttkLwC7Lkkb5AGNOl33cl8e395ECfQP/3dv9\n 9qKRITOzvk4iE1J+oHQsTxjslIIxmECQAA==", "X-Google-Smtp-Source": "\n ABdhPJwsGFsuBfTAJbZyBNXkPsiRyuDgMy60nSMQ5twEywMxvN9t7NMVAQ2AyXptTyNEoUsz4z9MWw==", "X-Received": "by 2002:a17:906:8681:b0:6ce:d45f:1689 with SMTP id\n g1-20020a170906868100b006ced45f1689mr19874240ejx.183.1645553559474;\n Tue, 22 Feb 2022 10:12:39 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "shaibran@amazon.com, upstream@semihalf.com,\n Michal Krawczyk <mk@semihalf.com>, stable@dpdk.org", "Subject": "[PATCH v2 20/21] net/ena: don't indicate bad csum for L4 csum error", "Date": "Tue, 22 Feb 2022 19:11:45 +0100", "Message-Id": "<20220222181146.28882-21-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220222181146.28882-1-mk@semihalf.com>", "References": "<20220222160634.24489-1-mk@semihalf.com>\n <20220222181146.28882-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some HW may invalidly set checksum error bit for the valid L4 checksum.\nTo avoid drop of the packets in that situation, do not indicate bad\nchecksum for L4 Rx csum offloads. Instead, set it as unknown, so the\napplication will re-verify this value.\n\nThe statistics counters will still work as previously.\n\nFixes: 05817057faba (\"net/ena: fix indication of bad L4 Rx checksums\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 9f29cf04ac..0861206ea4 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -583,7 +583,13 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,\n \t} else {\n \t\tif (unlikely(ena_rx_ctx->l4_csum_err)) {\n \t\t\t++rx_stats->l4_csum_bad;\n-\t\t\tol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;\n+\t\t\t/*\n+\t\t\t * For the L4 Rx checksum offload the HW may indicate\n+\t\t\t * bad checksum although it's valid. Because of that,\n+\t\t\t * we're setting the UNKNOWN flag to let the app\n+\t\t\t * re-verify the checksum.\n+\t\t\t */\n+\t\t\tol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;\n \t\t} else {\n \t\t\t++rx_stats->l4_csum_good;\n \t\t\tol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n", "prefixes": [ "v2", "20/21" ] }