Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107996/?format=api
{ "id": 107996, "url": "http://patches.dpdk.org/api/patches/107996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220222160634.24489-21-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222160634.24489-21-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222160634.24489-21-mk@semihalf.com", "date": "2022-02-22T16:06:33", "name": "[20/21] net/ena: don't indicate bad csum for L4 csum error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4ab6dcc05f3db5e177f5052be903eb1f2b914ab0", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220222160634.24489-21-mk@semihalf.com/mbox/", "series": [ { "id": 21796, "url": "http://patches.dpdk.org/api/series/21796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21796", "date": "2022-02-22T16:06:13", "name": "net/ena: v2.6.0 driver update", "version": 1, "mbox": "http://patches.dpdk.org/series/21796/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107996/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0630BA0352;\n\tTue, 22 Feb 2022 17:09:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02171426EC;\n\tTue, 22 Feb 2022 17:07:24 +0100 (CET)", "from mail-ed1-f48.google.com (mail-ed1-f48.google.com\n [209.85.208.48]) by mails.dpdk.org (Postfix) with ESMTP id C14E64116A\n for <dev@dpdk.org>; Tue, 22 Feb 2022 17:07:17 +0100 (CET)", "by mail-ed1-f48.google.com with SMTP id x5so37988953edd.11\n for <dev@dpdk.org>; Tue, 22 Feb 2022 08:07:17 -0800 (PST)", "from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl.\n [89.79.181.52])\n by smtp.gmail.com with ESMTPSA id x6sm10013477edv.109.2022.02.22.08.07.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 22 Feb 2022 08:07:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=14NUlgp7/uwht08EEffkISHQVyhpeQZpdRvDSsgGcy4=;\n b=AcIUZGq+VO/yvAcKAuUJHJhZsdch7/Oso943NP5XgMSAV8FsudjS/cnMyhOXPH66LQ\n 6+a3VkbWKkmEKbyQGrqpO49L5KfiC5DwQqyk9LORMxOhAIzNEThzagcsWcTgofabxnSf\n G7eZYjfg71uBRNLZxubzuj3J1+miJwZf+ygYHIlRf/FIj/LZcPM0KRImM61IfnTn/pbj\n NC6TeL0m33RcIaSoMOCacHhGdB0jfBR6XfoBvAAdhyiGQW2ZQDtkZmyXbNWQCijqn5GB\n HoC49nVQq4TgsRrkG7/qYmrO3B2zoRv/8VuXL+jzQK7OcebI2An1KXbdEYZRaMUFv4HZ\n iJzQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=14NUlgp7/uwht08EEffkISHQVyhpeQZpdRvDSsgGcy4=;\n b=ljbLDNlTSGekH6pF7jGHgu4eJxuki18vGeIrtieuqaqeu4+FCd6ATJlg+nY0+yNBOt\n K+VEEEzmGJFxODTCckwVglqU0ruO0wsBh2CPp9dvHpymgAIM+zLBBsfty6YdFTOf/XLV\n eBeJHisASo0DheZI+zjPh6oTEV59g5D7mYHJEDx8gAv4arH/VP5FMc8sXNoyextTH8Tg\n czMABe4eyw2nCuGPnsPhel0Z2KsSdJYSfe8esKFqPoS9FgqoqnPWkItpIxgO9LxgsE2m\n hWbTNR9aFzDQqMCiWmy3yaYPclJZ1H0+4ezIgAwgYyzjqSdlUIkiLnJMq1KwghSvWmeS\n 7DSQ==", "X-Gm-Message-State": "AOAM532dUD7KMEyeCemcz2cLPHLNh7NHg9uvV9HPZi5hOCuJNaPPvFdx\n LJpmD1M7pr9p5345x588LPQi25EMs7NoKw==", "X-Google-Smtp-Source": "\n ABdhPJwec77IkJVhMcKhcG2c2Fv51uu5+SuGWRUj6NQE+seFtJfnmV2Kw4QOfpKZ49fwDvQ88RsSBA==", "X-Received": "by 2002:aa7:cac8:0:b0:410:cc6c:6512 with SMTP id\n l8-20020aa7cac8000000b00410cc6c6512mr26698410edt.408.1645546037251;\n Tue, 22 Feb 2022 08:07:17 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "shaibran@amazon.com, upstream@semihalf.com,\n Michal Krawczyk <mk@semihalf.com>, stable@dpdk.org", "Subject": "[PATCH 20/21] net/ena: don't indicate bad csum for L4 csum error", "Date": "Tue, 22 Feb 2022 17:06:33 +0100", "Message-Id": "<20220222160634.24489-21-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220222160634.24489-1-mk@semihalf.com>", "References": "<20220222160634.24489-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some HW may invalidly set checksum error bit for the valid L4 checksum.\nTo avoid drop of the packets in that situation, do not indicate bad\nchecksum for L4 Rx csum offloads. Instead, set it as unknown, so the\napplication will re-verify this value.\n\nThe statistics counters will still work as previously.\n\nFixes: 05817057faba (\"net/ena: fix indication of bad L4 Rx checksums\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 9f29cf04ac..0861206ea4 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -583,7 +583,13 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,\n \t} else {\n \t\tif (unlikely(ena_rx_ctx->l4_csum_err)) {\n \t\t\t++rx_stats->l4_csum_bad;\n-\t\t\tol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;\n+\t\t\t/*\n+\t\t\t * For the L4 Rx checksum offload the HW may indicate\n+\t\t\t * bad checksum although it's valid. Because of that,\n+\t\t\t * we're setting the UNKNOWN flag to let the app\n+\t\t\t * re-verify the checksum.\n+\t\t\t */\n+\t\t\tol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;\n \t\t} else {\n \t\t\t++rx_stats->l4_csum_good;\n \t\t\tol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n", "prefixes": [ "20/21" ] }