Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107980/?format=api
{ "id": 107980, "url": "http://patches.dpdk.org/api/patches/107980/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220222160634.24489-5-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222160634.24489-5-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222160634.24489-5-mk@semihalf.com", "date": "2022-02-22T16:06:17", "name": "[04/21] net/ena: remove unused offloads variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0e660eefb55a6498ebd4f6bffd3b1b696e3be1f1", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220222160634.24489-5-mk@semihalf.com/mbox/", "series": [ { "id": 21796, "url": "http://patches.dpdk.org/api/series/21796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21796", "date": "2022-02-22T16:06:13", "name": "net/ena: v2.6.0 driver update", "version": 1, "mbox": "http://patches.dpdk.org/series/21796/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107980/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107980/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 40C05A0352;\n\tTue, 22 Feb 2022 17:07:18 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2819B41154;\n\tTue, 22 Feb 2022 17:06:59 +0100 (CET)", "from mail-ed1-f41.google.com (mail-ed1-f41.google.com\n [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id 5720C41148\n for <dev@dpdk.org>; Tue, 22 Feb 2022 17:06:56 +0100 (CET)", "by mail-ed1-f41.google.com with SMTP id z22so38070307edd.1\n for <dev@dpdk.org>; Tue, 22 Feb 2022 08:06:56 -0800 (PST)", "from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl.\n [89.79.181.52])\n by smtp.gmail.com with ESMTPSA id x6sm10013477edv.109.2022.02.22.08.06.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 22 Feb 2022 08:06:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=essxYOnKPPe+crKy13EzyluvIY0P3kBRk7ehFkEAhZ4=;\n b=hOQHz1kwLPn7GPUXZTFys1RXUIwSP1XDQjX7Pt96KHtRJTCk0RV/3cCMPmUIieu6Te\n z6h3M3KwSLO/LO8mQqIRQi1lZGYYoiv2ZrniEwF4tL04l7HSMLKvmCb5CFQYuOxhbjhR\n H3vIr/rrBYkBYnYq7J6diXCa570rf3iMg0KsyWn/NFFBUm7mx5rkzQnbLS5l1sSZBk/+\n IoBM1+d5JrJVaqLTpFoCF4l84TPosrQ1+dqqE8wVDb3yIMEgJob9+Jagz5bbYileclef\n X1J9Wi7vFTLo60hxXu3rBrk3kJQUfrytXgIeWc+EzbpmZtLm+QE7xIYGdg3Zyb/PaItW\n p7Gg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=essxYOnKPPe+crKy13EzyluvIY0P3kBRk7ehFkEAhZ4=;\n b=Lk3FpCzdnWzt9qJ8D1qmL+L6sp/MQeTm3usJyCKGTFgS0EGH3cr0zdtBwOaRSvQAvU\n aTG2lYOqm6RRDkfbpFbvYiUunyqZ1yL8rxTykeGhnNq8YahqbWMntokDQIVInshOV317\n LHIuNOSMtu7N8cB++lRBqgOWnWhPEZeyE5TpfSfdpBOqiHChE/SiJkcEBh6R3zoNuIFu\n FxwTtTdOg7WvpMqXnB6lldyA4Wm2+SnEk2/IhNTAxI3KQRrTLocdN4t2Bqv/rkvyhDtj\n CdBInZiCmthyDOf1Rg+N7X63mcXbylvVhKovzZ3tFW0iTrHHYWO1hjsla/YSVTIpIbmL\n B6KA==", "X-Gm-Message-State": "AOAM532JcBnZjAsin/qWWu8zCIStBSbUsLiW2H7ZlshRS8O6otalLMZq\n CIgo58sEdnBpGgjUGFioBC4fByqfHs3Png==", "X-Google-Smtp-Source": "\n ABdhPJyzgpSC45nET7TPGC2XG4GRTO9OZY8B+22FZNI5fy1gibVeYbBlBV1lkRRP9xJ3lYJWwH9T1w==", "X-Received": "by 2002:a50:fc09:0:b0:40f:e199:b266 with SMTP id\n i9-20020a50fc09000000b0040fe199b266mr26576854edr.350.1645546015742;\n Tue, 22 Feb 2022 08:06:55 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "shaibran@amazon.com, upstream@semihalf.com,\n Michal Krawczyk <mk@semihalf.com>, Artur Rojek <ar@semihalf.com>,\n Dawid Gorecki <dgr@semihalf.com>, Igor Chauskin <igorch@semihalf.com>", "Subject": "[PATCH 04/21] net/ena: remove unused offloads variables", "Date": "Tue, 22 Feb 2022 17:06:17 +0100", "Message-Id": "<20220222160634.24489-5-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220222160634.24489-1-mk@semihalf.com>", "References": "<20220222160634.24489-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Those variables are being set, but never read. As they seem to be\nleftover from the old offloads API and don't have any purpose right\nnow, they are simply being removed.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Artur Rojek <ar@semihalf.com>\nReviewed-by: Dawid Gorecki <dgr@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@semihalf.com>\nReviewed-by: Shai Brandes <shaibran@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 3 ---\n drivers/net/ena/ena_ethdev.h | 5 -----\n 2 files changed, 8 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 2de2dcf12f..de5fdb8f1d 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev)\n \t */\n \tadapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to / 2;\n \n-\tadapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads;\n-\tadapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex f47ba3fb02..4dfa604d51 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -278,11 +278,6 @@ struct ena_adapter {\n \tstruct ena_driver_stats *drv_stats;\n \tenum ena_adapter_state state;\n \n-\tuint64_t tx_supported_offloads;\n-\tuint64_t tx_selected_offloads;\n-\tuint64_t rx_supported_offloads;\n-\tuint64_t rx_selected_offloads;\n-\n \tbool link_status;\n \n \tenum ena_regs_reset_reason_types reset_reason;\n", "prefixes": [ "04/21" ] }