Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107978/?format=api
{ "id": 107978, "url": "http://patches.dpdk.org/api/patches/107978/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220222160634.24489-3-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222160634.24489-3-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222160634.24489-3-mk@semihalf.com", "date": "2022-02-22T16:06:15", "name": "[02/21] net/ena: add assertion on Tx info mbuf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6583235adee42222ea6db44c4b06d81e18acd689", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220222160634.24489-3-mk@semihalf.com/mbox/", "series": [ { "id": 21796, "url": "http://patches.dpdk.org/api/series/21796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21796", "date": "2022-02-22T16:06:13", "name": "net/ena: v2.6.0 driver update", "version": 1, "mbox": "http://patches.dpdk.org/series/21796/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107978/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC6E1A0352;\n\tTue, 22 Feb 2022 17:07:03 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 595D94114E;\n\tTue, 22 Feb 2022 17:06:56 +0100 (CET)", "from mail-ed1-f41.google.com (mail-ed1-f41.google.com\n [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id 8538041144\n for <dev@dpdk.org>; Tue, 22 Feb 2022 17:06:53 +0100 (CET)", "by mail-ed1-f41.google.com with SMTP id s14so20717238edw.0\n for <dev@dpdk.org>; Tue, 22 Feb 2022 08:06:53 -0800 (PST)", "from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl.\n [89.79.181.52])\n by smtp.gmail.com with ESMTPSA id x6sm10013477edv.109.2022.02.22.08.06.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 22 Feb 2022 08:06:52 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=;\n b=37CN8PI2wln9l+Ej6bC27GHN6/adnwzjRqC4e3MTuOPo0s2SbwYf7EGB7FiPfMn3/6\n 3Dgb3XqrgU76zQGK8KSpr28KyAI6gy+u7tbLTrlfX7T572wdSRJesR+U/iIbi/fYgWwO\n STJBvjFfa+K9O7WFXl8THozSEmNBNSLCqNMbDRZ+uL/tMPexTukL8hTHLRvY6UoIh9p2\n Qsq1gNKJ0l96fUqlT2uNUbDWEAQsV9XcxbQcZBRSLQfLcRZW2+RZT7No0kwUlcnRoWaz\n 59/coZunLLwNiOe6a9U2dKUhvxFI4Sld6/mM1U/zEtA/fDZdKOvTfVks04CsZHPFZTkg\n mSSw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=;\n b=tUfuJo49YtfcGmi0VJJCKaFZc/L2FalKWQ+bNBNPcSW+6e+BPRnNBq5FFNArGWLFF4\n NzF3Gal6bU/36tlBUHbOqPMzWUKAb57837nvBGKuwzhTK6jfajDzeYFYCyS+TxdeqHJZ\n bbZhcIyIXpy21QjcqvqTHZFnGDr5iIiVtdNpmXFSeHnWe+V5zWVXc7qf/CuwGJ2Hdn5o\n C7YkdWWg+pGyAaYqjyX124PeCr6ozuEjlo6PoqNSfZb64u2Wt+KIdS0nnKvBdkgK8mxE\n +7S0b8VAvT1r+0y8cAfqAFA47W0cN2Bo3ASY0QbcFor4W5stTqfmSod4z7ZOg5H8GLkK\n BJVA==", "X-Gm-Message-State": "AOAM532lZikwsV/rcISFfSlN6qlAP7Z9AJRvh88qDGbJYA1Wrriw3IyJ\n Y8jKkpUqepQb0z7QXzSHGJU/HdgWPp87PA==", "X-Google-Smtp-Source": "\n ABdhPJzwqdFe1WKNZSYsD7eUqO5yCVHeT6m/FAvgzd8dN1YM8IxQpor/cRoA7MtElS/jyQgzVSgbbQ==", "X-Received": "by 2002:aa7:d1d7:0:b0:410:d6cf:82b2 with SMTP id\n g23-20020aa7d1d7000000b00410d6cf82b2mr26423464edp.193.1645546012916;\n Tue, 22 Feb 2022 08:06:52 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "shaibran@amazon.com, upstream@semihalf.com,\n Michal Krawczyk <mk@semihalf.com>, Dawid Gorecki <dgr@semihalf.com>", "Subject": "[PATCH 02/21] net/ena: add assertion on Tx info mbuf", "Date": "Tue, 22 Feb 2022 17:06:15 +0100", "Message-Id": "<20220222160634.24489-3-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220222160634.24489-1-mk@semihalf.com>", "References": "<20220222160634.24489-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To make sure there is no outstanding mbuf in the reused Tx queue (due to\nunproper cleanup, or some invalid logic on Tx path), the assertion was\nadded on the Tx path.\n\nAs it's being compiled out in the release version, it won't affect\nthe IO path performance.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Dawid Gorecki <dgr@semihalf.com>\nReviewed-by: Shai Brandes <shaibran@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex deaee30664..34fb43cb00 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -2661,6 +2661,7 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf)\n \treq_id = tx_ring->empty_tx_reqs[next_to_use];\n \ttx_info = &tx_ring->tx_buffer_info[req_id];\n \ttx_info->num_of_bufs = 0;\n+\tRTE_ASSERT(tx_info->mbuf == NULL);\n \n \tena_tx_map_mbuf(tx_ring, tx_info, mbuf, &push_header, &header_len);\n \n", "prefixes": [ "02/21" ] }