Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107947/?format=api
{ "id": 107947, "url": "http://patches.dpdk.org/api/patches/107947/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220222085156.27137-13-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222085156.27137-13-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222085156.27137-13-suanmingm@nvidia.com", "date": "2022-02-22T08:51:54", "name": "[v2,12/14] net/mlx5: add mark action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d6bbd9111210ae8ae4367b916657301b711efc77", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220222085156.27137-13-suanmingm@nvidia.com/mbox/", "series": [ { "id": 21784, "url": "http://patches.dpdk.org/api/series/21784/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21784", "date": "2022-02-22T08:51:42", "name": "net/mlx5: add hardware steering", "version": 2, "mbox": "http://patches.dpdk.org/series/21784/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107947/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107947/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CCDF1A0350;\n\tTue, 22 Feb 2022 09:53:44 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B4F70411DB;\n\tTue, 22 Feb 2022 09:52:47 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2065.outbound.protection.outlook.com [40.107.220.65])\n by mails.dpdk.org (Postfix) with ESMTP id E5FB4411A4\n for <dev@dpdk.org>; Tue, 22 Feb 2022 09:52:44 +0100 (CET)", "from MWHPR19CA0023.namprd19.prod.outlook.com (2603:10b6:300:d4::33)\n by BN8PR12MB3010.namprd12.prod.outlook.com (2603:10b6:408:63::32)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Tue, 22 Feb\n 2022 08:52:42 +0000", "from CO1NAM11FT053.eop-nam11.prod.protection.outlook.com\n (2603:10b6:300:d4:cafe::bf) by MWHPR19CA0023.outlook.office365.com\n (2603:10b6:300:d4::33) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27 via Frontend\n Transport; Tue, 22 Feb 2022 08:52:42 +0000", "from mail.nvidia.com (12.22.5.236) by\n CO1NAM11FT053.mail.protection.outlook.com (10.13.175.63) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4995.15 via Frontend Transport; Tue, 22 Feb 2022 08:52:41 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com\n (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 22 Feb 2022 08:52:40 +0000", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Tue, 22 Feb 2022\n 00:52:37 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VdmwjtwbPAxU5eiRTvDU5As0shH3Q4GMVw7IWgKuuoI9QAu04cfr3zgG1+3myHxseyxNBfjtXgJ7+KP20zhQNwi3pX4rvfwpLqIBCWuYEtt9+4v1yuxZWrkO33YaCf+Pp08mOM4TYASigypJXCyMbb0rv9Bp/vNFl8b8nogO+U2jMSA1drJyDypwOOdg3RD/LMqDPJsjbvBozMyU8hVGzLfC8guGOahABpZ9yz9XIgu59g1v8tquBsPR74bnXh68/dHXFfqH2vHm4O28e57zbHcLhtVg16bZCgOYk6ybj/NWBqx7DIQMDNUPfIKyv9n2lknSj6CVenDABz7tw6YB0w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=q3cC+vZaa7ITpMtrvifjNXrikIyHhtCcCwSgN1knl7Y=;\n b=Q+XVoC2STdb5wsF1xkMaqE7LtGOcg3IM2qDJUM8LLItGELlsl2IIJkDccWC5twdECbE/rV5v4pANCiGsIbDLQmVz9c73ca5xyIH95a3VDAnrVDoX/TfVKDLH+miQpwWWrFXsg0i1ZmKxJADFxrfcMh1GLZy2KFkaP62h56XPHgqNKh0BRBkd4t5VdkxDsQZAR9LD+EOK+I5Mi3ygzXD2mvNqUINEfTHSrZJnjmqQ1WfQUYcIMpdKEW98XiTsfxR97w7CMQ4MmejhczkMFFl4pnCY04eW26ZjhUmSRpV4btTXjS7l0/SB/UWfUfj7sSYpChIUz8TquIga2g1Z9x7Ryg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass\n (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=q3cC+vZaa7ITpMtrvifjNXrikIyHhtCcCwSgN1knl7Y=;\n b=oDrsomK666c1arx1/Az1aSpmO285I4hqeVmeq7iwO3KmMT56wtxdaWYB075IQhPJ7T6VS5ztkW5I2QJN7O+3kT/cKYa0ogPniUsMI0CJ41KHw7mRdCDslx4s66gaZzFPDq4XwK6pDXM6ybixzDsRZevfYv228V3u0dGZMvnPOMj5aplpcE6oh7BhLX7NGcCXoB78ye/QcpSsJqoTfw/jRia3UnQBh0bT+V2gnwIcDqdSd3D1DFaFVIeADBLZTGT5WLd9+On0JVb052Ji9CSw1A7yfNrTmG7iTWxNqKt0GFcpb0OM53oM+f3GgnAqHKWVqL3XQ3DePi7aVD0TnFXSPA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 12.22.5.236)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 12.22.5.236 as permitted sender) receiver=protection.outlook.com;\n client-ip=12.22.5.236; helo=mail.nvidia.com;", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<rasland@nvidia.com>, <orika@nvidia.com>, <dev@dpdk.org>", "Subject": "[PATCH v2 12/14] net/mlx5: add mark action", "Date": "Tue, 22 Feb 2022 10:51:54 +0200", "Message-ID": "<20220222085156.27137-13-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "In-Reply-To": "<20220222085156.27137-1-suanmingm@nvidia.com>", "References": "<20220210162926.20436-1-suanmingm@nvidia.com>\n <20220222085156.27137-1-suanmingm@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "1e492b6e-8037-42ae-6c83-08d9f5e0afbf", "X-MS-TrafficTypeDiagnostic": "BN8PR12MB3010:EE_", "X-Microsoft-Antispam-PRVS": "\n <BN8PR12MB3010D1E76C7E9A0205C71BE0C13B9@BN8PR12MB3010.namprd12.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n fDj3Z4DdtkTfOitxNO47Ryb4rc58mnDHjubxhrjI+rLYOHAeyIkZsLuZSkqZXN0+CBkcMRsF1CXoqmhnxj2o+1Ri9JQVUJmq3xZAFbrhHwPc9O49JvT0MGYnVBwl21QqFHBKv4oeD1ruu8Axb141/9O8cxrs1TZi/JQ5MbMnXKRWDfY9a/Bxj/HRlf2WON+cq8MitkZG8QOUF06pogKeXVhh4GlAhBC8C37/5mX982lqNnsTx6DvsvQ3qr49sy7Mz2ds9Rp+N2BjmL0cLL0/EFr2UIFAupfHtrKUsAol2AhHNt7aQApWOOFywYQ1iDt8IhixvTLS5mjxa74twz6YrlkNcXkdoVdHpsMwBA8s270TyAdm3zMypav2rbFFWr0rg5KZIZbJIlUVd3fGQdWwlC0iy/BNxGw8cSZacIBec7SGkWFtj+jKP9yW4/EIiplU3zdxknqzeL2srMs38eSj1W24T+plovt65XtXBKY0Mdrk+ebZ8p1QTi3sevwAsWtraetLyhPeMMVmHz46A2HOaugTVhZlJisBpEemLabz/qB/pHz4Zyumhzdu8q4vKBkBEmLr7Ffigr5i8XoH2mw6TjLa906bsVW+19JieYVyXU4YPEdQqoTgPvfa0ZVjMMinncZcINvkN8/va/9gaGXPd5I77P1gX1i49zQsn1zIhvrVTsgvwlTrk3SnZD2SJi8EfuXMyt49XIhKbn1Zo6T+5A==", "X-Forefront-Antispam-Report": "CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE;\n SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(356005)(110136005)(426003)(55016003)(54906003)(8676002)(4326008)(316002)(70586007)(86362001)(6636002)(26005)(336012)(186003)(1076003)(81166007)(70206006)(16526019)(6286002)(2616005)(83380400001)(47076005)(40460700003)(82310400004)(508600001)(5660300002)(36860700001)(7696005)(6666004)(36756003)(2906002)(8936002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Feb 2022 08:52:41.8579 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1e492b6e-8037-42ae-6c83-08d9f5e0afbf", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT053.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN8PR12MB3010", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The mark action is covered by tag action internally. While it is added\nthe HW will add a tag to the packet. The mark value can be set as fixed\nor dynamic as the action mask indicates.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5.h | 2 +\n drivers/net/mlx5/mlx5_flow.h | 1 +\n drivers/net/mlx5/mlx5_flow_hw.c | 66 ++++++++++++++++++++++++++++++---\n 3 files changed, 63 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 43a913fcc5..e78eb5e380 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -1528,6 +1528,8 @@ struct mlx5_priv {\n \t/* HW steering global drop action. */\n \tstruct mlx5dr_action *hw_drop[MLX5_HW_ACTION_FLAG_MAX]\n \t\t\t\t [MLX5DR_TABLE_TYPE_MAX];\n+\t/* HW steering global drop action. */\n+\tstruct mlx5dr_action *hw_tag[MLX5_HW_ACTION_FLAG_MAX];\n \tstruct mlx5_indexed_pool *acts_ipool; /* Action data indexed pool. */\n #endif\n };\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex aa1709e7cb..ec759c1aa4 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -1077,6 +1077,7 @@ struct mlx5_hw_actions {\n \tstruct mlx5_hw_jump_action *jump; /* Jump action. */\n \tstruct mlx5_hrxq *tir; /* TIR action. */\n \tuint32_t acts_num:4; /* Total action number. */\n+\tuint32_t mark:1; /* Indicate the mark action. */\n \t/* Translated DR action array from action template. */\n \tstruct mlx5dr_rule_action rule_acts[MLX5_HW_MAX_ACTS];\n };\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 0d49ab0bb2..a28e3c00b3 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -37,6 +37,31 @@ static uint32_t mlx5_hw_act_flag[MLX5_HW_ACTION_FLAG_MAX]\n \t},\n };\n \n+/**\n+ * Set rxq flag.\n+ *\n+ * @param[in] dev\n+ * Pointer to the rte_eth_dev structure.\n+ * @param[in] enable\n+ * Flag to enable or not.\n+ */\n+static void\n+flow_hw_rxq_flag_set(struct rte_eth_dev *dev, bool enable)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tunsigned int i;\n+\n+\tif ((!priv->mark_enabled && !enable) ||\n+\t (priv->mark_enabled && enable))\n+\t\treturn;\n+\tfor (i = 0; i < priv->rxqs_n; ++i) {\n+\t\tstruct mlx5_rxq_ctrl *rxq_ctrl = mlx5_rxq_ctrl_get(dev, i);\n+\n+\t\trxq_ctrl->rxq.mark = enable;\n+\t}\n+\tpriv->mark_enabled = enable;\n+}\n+\n /**\n * Register destination table DR jump action.\n *\n@@ -298,6 +323,20 @@ flow_hw_actions_translate(struct rte_eth_dev *dev,\n \t\t\tacts->rule_acts[i++].action =\n \t\t\t\tpriv->hw_drop[!!attr->group][type];\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_MARK:\n+\t\t\tacts->mark = true;\n+\t\t\tif (masks->conf)\n+\t\t\t\tacts->rule_acts[i].tag.value =\n+\t\t\t\t\tmlx5_flow_mark_set\n+\t\t\t\t\t(((const struct rte_flow_action_mark *)\n+\t\t\t\t\t(masks->conf))->id);\n+\t\t\telse if (__flow_hw_act_data_general_append(priv, acts,\n+\t\t\t\tactions->type, actions - action_start, i))\n+\t\t\t\tgoto err;\n+\t\t\tacts->rule_acts[i++].action =\n+\t\t\t\tpriv->hw_tag[!!attr->group];\n+\t\t\tflow_hw_rxq_flag_set(dev, true);\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_JUMP:\n \t\t\tif (masks->conf) {\n \t\t\t\tuint32_t jump_group =\n@@ -424,6 +463,7 @@ flow_hw_actions_construct(struct rte_eth_dev *dev,\n \t}\n \tLIST_FOREACH(act_data, &hw_acts->act_list, next) {\n \t\tuint32_t jump_group;\n+\t\tuint32_t tag;\n \t\tstruct mlx5_hw_jump_action *jump;\n \t\tstruct mlx5_hrxq *hrxq;\n \n@@ -435,6 +475,12 @@ flow_hw_actions_construct(struct rte_eth_dev *dev,\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_VOID:\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_MARK:\n+\t\t\ttag = mlx5_flow_mark_set\n+\t\t\t (((const struct rte_flow_action_mark *)\n+\t\t\t (action->conf))->id);\n+\t\t\trule_acts[act_data->action_dst].tag.value = tag;\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_JUMP:\n \t\t\tjump_group = ((const struct rte_flow_action_jump *)\n \t\t\t\t\t\taction->conf)->group;\n@@ -1027,6 +1073,8 @@ flow_hw_table_destroy(struct rte_eth_dev *dev,\n \t\t__atomic_sub_fetch(&table->its[i]->refcnt,\n \t\t\t\t 1, __ATOMIC_RELAXED);\n \tfor (i = 0; i < table->nb_action_templates; i++) {\n+\t\tif (table->ats[i].acts.mark)\n+\t\t\tflow_hw_rxq_flag_set(dev, false);\n \t\t__flow_hw_action_template_destroy(dev, &table->ats[i].acts);\n \t\t__atomic_sub_fetch(&table->ats[i].action_template->refcnt,\n \t\t\t\t 1, __ATOMIC_RELAXED);\n@@ -1561,15 +1609,20 @@ flow_hw_configure(struct rte_eth_dev *dev,\n \t\t\tif (!priv->hw_drop[i][j])\n \t\t\t\tgoto err;\n \t\t}\n+\t\tpriv->hw_tag[i] = mlx5dr_action_create_tag\n+\t\t\t(priv->dr_ctx, mlx5_hw_act_flag[i][0]);\n+\t\tif (!priv->hw_tag[i])\n+\t\t\tgoto err;\n \t}\n \treturn 0;\n err:\n \tfor (i = 0; i < MLX5_HW_ACTION_FLAG_MAX; i++) {\n \t\tfor (j = 0; j < MLX5DR_TABLE_TYPE_MAX; j++) {\n-\t\t\tif (!priv->hw_drop[i][j])\n-\t\t\t\tcontinue;\n-\t\t\tmlx5dr_action_destroy(priv->hw_drop[i][j]);\n+\t\t\tif (priv->hw_drop[i][j])\n+\t\t\t\tmlx5dr_action_destroy(priv->hw_drop[i][j]);\n \t\t}\n+\t\tif (priv->hw_tag[i])\n+\t\t\tmlx5dr_action_destroy(priv->hw_tag[i]);\n \t}\n \tif (dr_ctx)\n \t\tclaim_zero(mlx5dr_context_close(dr_ctx));\n@@ -1615,10 +1668,11 @@ flow_hw_resource_release(struct rte_eth_dev *dev)\n \t}\n \tfor (i = 0; i < MLX5_HW_ACTION_FLAG_MAX; i++) {\n \t\tfor (j = 0; j < MLX5DR_TABLE_TYPE_MAX; j++) {\n-\t\t\tif (!priv->hw_drop[i][j])\n-\t\t\t\tcontinue;\n-\t\t\tmlx5dr_action_destroy(priv->hw_drop[i][j]);\n+\t\t\tif (priv->hw_drop[i][j])\n+\t\t\t\tmlx5dr_action_destroy(priv->hw_drop[i][j]);\n \t\t}\n+\t\tif (priv->hw_tag[i])\n+\t\t\tmlx5dr_action_destroy(priv->hw_tag[i]);\n \t}\n \tif (priv->acts_ipool) {\n \t\tmlx5_ipool_destroy(priv->acts_ipool);\n", "prefixes": [ "v2", "12/14" ] }