Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107854/?format=api
http://patches.dpdk.org/api/patches/107854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220220005140.78713-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220220005140.78713-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220220005140.78713-6-stephen@networkplumber.org", "date": "2022-02-20T00:51:38", "name": "[v2,5/7] test: remove unecessary NULL checks before free", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b8128ac3c3d1148e85573503f0104ca7ef0039d3", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220220005140.78713-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 21749, "url": "http://patches.dpdk.org/api/series/21749/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21749", "date": "2022-02-20T00:51:33", "name": "fix more unnecessary null checks", "version": 2, "mbox": "http://patches.dpdk.org/series/21749/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107854/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/107854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB3D0A00C2;\n\tSun, 20 Feb 2022 01:52:12 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 207234115A;\n\tSun, 20 Feb 2022 01:51:54 +0100 (CET)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id DA95441150\n for <dev@dpdk.org>; Sun, 20 Feb 2022 01:51:50 +0100 (CET)", "by mail-pl1-f172.google.com with SMTP id m11so6495276pls.5\n for <dev@dpdk.org>; Sat, 19 Feb 2022 16:51:50 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n f7sm8129695pfc.0.2022.02.19.16.51.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 19 Feb 2022 16:51:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=4GNWOCeECk4W5dvSei/2YWeZW1DAhQYhmlSYIkWYJgY=;\n b=FqDZH4COVdZ1Vta2yZ8LXV/1plXfxYwC+L41vm916btPiuHhmFvJgXxjoBMBFCufai\n Y2kdffxB38YkdU5G61qZVGR45XJVj670VGDwhdovRmeuYQtFD95241Dz5jj6cwfHvpGU\n z5tYa5B/QOKFlEVwojWy6URVSyj+Sq4Tk6ZwPyTGWVQbKywmL6QSVyB5ajK2c7SJdmsE\n x+TySPB2Rg3Mfv8H1ARrzqtVoQKU1T2ExPd38DmV6arUvYOSSvF+4pPLYzU/XkSWSIJw\n iuED3fUca1mbj2P5bAB/U36Bx8EUF+SkyMgNk2uETJ7P3x3JhDamPEnO11GFcyjEpLV+\n asIQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=4GNWOCeECk4W5dvSei/2YWeZW1DAhQYhmlSYIkWYJgY=;\n b=nNttPiocrXcmApZNP8ZkakVkAo6qYUITgw7TK7QiYSyi1g2No2gg+lV4CWKGE7SxTJ\n s85IXZ84HyTT0pCr5dWiJKjVjmekE2+X/ZQ/t+GobeBWtEKC+H/ViJ99LGzfjcdjwX/5\n Dp1KLKxWTu1gCZ87gniZOYJSjOSLVrZ/VmpyaFAGhIlh/duVrve+OW6BFlPeMGCHzC1P\n HynklDdkukSrkBd9b/oxc2Kxw2YlpqWUqldBWTBTdHbePtBlg9SDluak8o42VaF95BCW\n wZabvMOWtj4xDC5nhHTW/5M0hW1Ee21gVpEuHLJxK9h+8Ejo/zl3hbeNFR3zJALCeMKN\n q38Q==", "X-Gm-Message-State": "AOAM531/EUjqQGCyde8NWwEqHwLC4Dsm9KhF0iGKud29C65Cqzs9B9H4\n eUa5n2Hpr1WBRJv2AD9Hd5TPL3sNtGfSBbq+", "X-Google-Smtp-Source": "\n ABdhPJz9J8LhE4yMy9sh3xAEiSFeVGaysgsFx9+KDKkyN4CZtlPnitSauSLgObmpBqjc4UUnSKZCWw==", "X-Received": "by 2002:a17:902:e74d:b0:14f:206d:1860 with SMTP id\n p13-20020a170902e74d00b0014f206d1860mr13664166plf.59.1645318309720;\n Sat, 19 Feb 2022 16:51:49 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Olivier Matz <olivier.matz@6wind.com>, Akhil Goyal <gakhil@marvell.com>,\n Fan Zhang <roy.fan.zhang@intel.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Subject": "[PATCH v2 5/7] test: remove unecessary NULL checks before free", "Date": "Sat, 19 Feb 2022 16:51:38 -0800", "Message-Id": "<20220220005140.78713-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220220005140.78713-1-stephen@networkplumber.org>", "References": "<20220219234322.61309-1-stephen@networkplumber.org>\n <20220220005140.78713-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "These are all cases in test code where there is unnecessary\nNULL check before free caught by coccinelle nullfree script.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_cmdline_lib.c | 3 +--\n app/test/test_cryptodev.c | 9 +++-----\n app/test/test_cryptodev_asym.c | 30 +++++++++------------------\n app/test/test_cryptodev_blockcipher.c | 3 +--\n app/test/test_func_reentrancy.c | 3 +--\n app/test/test_hash.c | 3 +--\n 6 files changed, 17 insertions(+), 34 deletions(-)", "diff": "diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c\nindex fcd58cb76af1..87c105936650 100644\n--- a/app/test/test_cmdline_lib.c\n+++ b/app/test/test_cmdline_lib.c\n@@ -229,8 +229,7 @@ test_cmdline_fns(void)\n \n error:\n \tprintf(\"Error: function accepted null parameter!\\n\");\n-\tif (cl != NULL)\n-\t\tcmdline_free(cl);\n+\tcmdline_free(cl);\n \treturn -1;\n }\n \ndiff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex a63c199964d4..1d9f615255c4 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -1451,8 +1451,7 @@ ut_teardown(void)\n \t}\n \n \t/* free crypto operation structure */\n-\tif (ut_params->op)\n-\t\trte_crypto_op_free(ut_params->op);\n+\trte_crypto_op_free(ut_params->op);\n \n \t/*\n \t * free mbuf - both obuf and ibuf are usually the same,\n@@ -11653,8 +11652,7 @@ test_multi_session(void)\n \t\t\taes_cbc_iv),\n \t\t\t\"Failed to perform decrypt on request number %u.\", i);\n \t\t/* free crypto operation structure */\n-\t\tif (ut_params->op)\n-\t\t\trte_crypto_op_free(ut_params->op);\n+\t\trte_crypto_op_free(ut_params->op);\n \n \t\t/*\n \t\t * free mbuf - both obuf and ibuf are usually the same,\n@@ -11797,8 +11795,7 @@ test_multi_session_random_usage(void)\n \t\t\t\t\tut_paramz[j].iv),\n \t\t\t\"Failed to perform decrypt on request number %u.\", i);\n \n-\t\tif (ut_paramz[j].ut_params.op)\n-\t\t\trte_crypto_op_free(ut_paramz[j].ut_params.op);\n+\t\trte_crypto_op_free(ut_paramz[j].ut_params.op);\n \n \t\t/*\n \t\t * free mbuf - both obuf and ibuf are usually the same,\ndiff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 7cda8bb081f0..9b4d9db59297 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -507,8 +507,7 @@ test_cryptodev_asym_op(struct crypto_testsuite_params_asym *ts_params,\n \t\tif (sess != NULL)\n \t\t\trte_cryptodev_asym_session_free(dev_id, sess);\n \n-\t\tif (op != NULL)\n-\t\t\trte_crypto_op_free(op);\n+\t\trte_crypto_op_free(op);\n \n \t\trte_free(result);\n \n@@ -1114,8 +1113,7 @@ test_dh_gen_shared_sec(struct rte_crypto_asym_xform *xfrm)\n error_exit:\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \treturn status;\n }\n \n@@ -1193,8 +1191,7 @@ test_dh_gen_priv_key(struct rte_crypto_asym_xform *xfrm)\n error_exit:\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \n \treturn status;\n }\n@@ -1283,8 +1280,7 @@ test_dh_gen_pub_key(struct rte_crypto_asym_xform *xfrm)\n error_exit:\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \n \treturn status;\n }\n@@ -1370,8 +1366,7 @@ test_dh_gen_kp(struct rte_crypto_asym_xform *xfrm)\n error_exit:\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \n \treturn status;\n }\n@@ -1481,8 +1476,7 @@ test_mod_inv(void)\n \tif (sess)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n \n-\tif (op)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \n \tTEST_ASSERT_EQUAL(status, 0, \"Test failed\");\n \n@@ -1593,8 +1587,7 @@ test_mod_exp(void)\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n \n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \n \tTEST_ASSERT_EQUAL(status, 0, \"Test failed\");\n \n@@ -1758,8 +1751,7 @@ test_dsa_sign(void)\n error_exit:\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \treturn status;\n }\n \n@@ -1947,8 +1939,7 @@ test_ecdsa_sign_verify(enum curve curve_id)\n exit:\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \treturn status;\n };\n \n@@ -2109,8 +2100,7 @@ test_ecpm(enum curve curve_id)\n exit:\n \tif (sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, sess);\n-\tif (op != NULL)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \treturn status;\n }\n \ndiff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c\nindex 494459195c49..954587ea5b18 100644\n--- a/app/test/test_cryptodev_blockcipher.c\n+++ b/app/test/test_cryptodev_blockcipher.c\n@@ -811,8 +811,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,\n \t\trte_free(auth_xform);\n \t}\n \n-\tif (op)\n-\t\trte_crypto_op_free(op);\n+\trte_crypto_op_free(op);\n \n \trte_pktmbuf_free(obuf);\n \ndiff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c\nindex 67e69ad53588..d1ed5d4abcfc 100644\n--- a/app/test/test_func_reentrancy.c\n+++ b/app/test/test_func_reentrancy.c\n@@ -278,8 +278,7 @@ fbk_clean(unsigned lcore_id)\n \tint i;\n \n \thandle = rte_fbk_hash_find_existing(\"fr_test_once\");\n-\tif (handle != NULL)\n-\t\trte_fbk_hash_free(handle);\n+\trte_fbk_hash_free(handle);\n \n \tfor (i = 0; i < MAX_ITER_MULTI; i++) {\n \t\tsnprintf(fbk_name, sizeof(fbk_name), \"fr_test_%d_%d\", lcore_id, i);\ndiff --git a/app/test/test_hash.c b/app/test/test_hash.c\nindex d522cb7f8cbf..3e45afaa67fc 100644\n--- a/app/test/test_hash.c\n+++ b/app/test/test_hash.c\n@@ -1159,8 +1159,7 @@ fbk_hash_unit_test(void)\n \tRETURN_IF_ERROR_FBK(handle == NULL, \"fbk hash creation should have succeeded\");\n \n \ttmp = rte_fbk_hash_create(&invalid_params_same_name_2);\n-\tif (tmp != NULL)\n-\t\trte_fbk_hash_free(tmp);\n+\trte_fbk_hash_free(tmp);\n \tRETURN_IF_ERROR_FBK(tmp != NULL, \"fbk hash creation should have failed\");\n \n \t/* we are not freeing handle here because we need a hash list\n", "prefixes": [ "v2", "5/7" ] }{ "id": 107854, "url": "