Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 107844,
    "url": "http://patches.dpdk.org/api/patches/107844/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220219121338.2438-1-pbhagavatula@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220219121338.2438-1-pbhagavatula@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220219121338.2438-1-pbhagavatula@marvell.com",
    "date": "2022-02-19T12:13:37",
    "name": "[1/2] event/cnxk: remove deschedule usage in CN9K",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "675ccd2d2b60e1b2c0e5224c1b220e5e2ed3a520",
    "submitter": {
        "id": 1183,
        "url": "http://patches.dpdk.org/api/people/1183/?format=api",
        "name": "Pavan Nikhilesh Bhagavatula",
        "email": "pbhagavatula@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220219121338.2438-1-pbhagavatula@marvell.com/mbox/",
    "series": [
        {
            "id": 21747,
            "url": "http://patches.dpdk.org/api/series/21747/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21747",
            "date": "2022-02-19T12:13:38",
            "name": "[1/2] event/cnxk: remove deschedule usage in CN9K",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/21747/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/107844/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/107844/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A308EA034E;\n\tSat, 19 Feb 2022 13:35:32 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5DBF7410E3;\n\tSat, 19 Feb 2022 13:35:29 +0100 (CET)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6CB56410E0\n for <dev@dpdk.org>; Sat, 19 Feb 2022 13:35:27 +0100 (CET)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 21JAkxti001914\n for <dev@dpdk.org>; Sat, 19 Feb 2022 04:35:26 -0800",
            "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3eaxssg7vh-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Sat, 19 Feb 2022 04:35:26 -0800",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Sat, 19 Feb 2022 04:35:47 -0800",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Sat, 19 Feb 2022 04:35:47 -0800",
            "from BG-LT7430.marvell.com (BG-LT7430.marvell.com [10.28.177.176])\n by maili.marvell.com (Postfix) with ESMTP id 9C7C85C6A04;\n Sat, 19 Feb 2022 04:13:43 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=reLH3FpYMvQ7PfAcOR3IxcYB4jxfe7ErQgp0DUv4tsY=;\n b=UXWM5PewzoAgxRWZXOS86PwLuzt0X8GSzkHCn5UtM1Cy1vGGktj7qk5JTIzxkeM36sN6\n hd5QeRDSYglXauOWNEiBKihaTqAtMdeArjjsGxsHfddDbjab5Gy1jDf+2H3xtinwR5HR\n QRVcnNcNrBzSNL1rd2oTIAl2LmwZg4y01d71P0qGY5dQK39uyxI/FEu20kD8hjeDGc2e\n hSzpxTPYSY0OBKb7/ckvkRc56xKXiTMicTb6MsinDXEOOWuh+DRsvionNbEGFeOHUBbs\n GSVmTT7kuAyjGEaZSlYGUidQItVbDXm7p8Q9ka6OvEJMuLIZKphAwxZVDXFgmuBpWg9y xA==",
        "From": "<pbhagavatula@marvell.com>",
        "To": "<jerinj@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \"Shijith\n Thotton\" <sthotton@marvell.com>",
        "CC": "<dev@dpdk.org>",
        "Subject": "[PATCH 1/2] event/cnxk: remove deschedule usage in CN9K",
        "Date": "Sat, 19 Feb 2022 17:43:37 +0530",
        "Message-ID": "<20220219121338.2438-1-pbhagavatula@marvell.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "1x3UUYXFvqFrzKpxdU3FosBcgeVSd3xt",
        "X-Proofpoint-ORIG-GUID": "1x3UUYXFvqFrzKpxdU3FosBcgeVSd3xt",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2022-02-19_04,2022-02-18_01,2021-12-02_01",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nUsing deschedule cmd might incorrectly ignore updates to WQE, GGRP\non CN9K.\nUse addwork to pipeline work instead.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n drivers/event/cnxk/cn9k_worker.h | 41 +++++++++++++++++++++++++-------\n 1 file changed, 32 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h\nindex 79374b8d95..0905d744cc 100644\n--- a/drivers/event/cnxk/cn9k_worker.h\n+++ b/drivers/event/cnxk/cn9k_worker.h\n@@ -63,15 +63,18 @@ cn9k_sso_hws_fwd_swtag(uint64_t base, const struct rte_event *ev)\n }\n \n static __rte_always_inline void\n-cn9k_sso_hws_fwd_group(uint64_t base, const struct rte_event *ev,\n-\t\t       const uint16_t grp)\n+cn9k_sso_hws_new_event_wait(struct cn9k_sso_hws *ws, const struct rte_event *ev)\n {\n \tconst uint32_t tag = (uint32_t)ev->event;\n \tconst uint8_t new_tt = ev->sched_type;\n+\tconst uint64_t event_ptr = ev->u64;\n+\tconst uint16_t grp = ev->queue_id;\n \n-\tplt_write64(ev->u64, base + SSOW_LF_GWS_OP_UPD_WQP_GRP1);\n-\tcnxk_sso_hws_swtag_desched(tag, new_tt, grp,\n-\t\t\t\t   base + SSOW_LF_GWS_OP_SWTAG_DESCHED);\n+\twhile (ws->xaq_lmt <= __atomic_load_n(ws->fc_mem, __ATOMIC_RELAXED))\n+\t\t;\n+\n+\tcnxk_sso_hws_add_work(event_ptr, tag, new_tt,\n+\t\t\t      ws->grp_base + (grp << 12));\n }\n \n static __rte_always_inline void\n@@ -86,10 +89,12 @@ cn9k_sso_hws_forward_event(struct cn9k_sso_hws *ws, const struct rte_event *ev)\n \t} else {\n \t\t/*\n \t\t * Group has been changed for group based work pipelining,\n-\t\t * Use deschedule/add_work operation to transfer the event to\n+\t\t * Use add_work operation to transfer the event to\n \t\t * new group/core\n \t\t */\n-\t\tcn9k_sso_hws_fwd_group(ws->base, ev, grp);\n+\t\trte_atomic_thread_fence(__ATOMIC_RELEASE);\n+\t\troc_sso_hws_head_wait(ws->base);\n+\t\tcn9k_sso_hws_new_event_wait(ws, ev);\n \t}\n }\n \n@@ -113,6 +118,22 @@ cn9k_sso_hws_dual_new_event(struct cn9k_sso_hws_dual *dws,\n \treturn 1;\n }\n \n+static __rte_always_inline void\n+cn9k_sso_hws_dual_new_event_wait(struct cn9k_sso_hws_dual *dws,\n+\t\t\t\t const struct rte_event *ev)\n+{\n+\tconst uint32_t tag = (uint32_t)ev->event;\n+\tconst uint8_t new_tt = ev->sched_type;\n+\tconst uint64_t event_ptr = ev->u64;\n+\tconst uint16_t grp = ev->queue_id;\n+\n+\twhile (dws->xaq_lmt <= __atomic_load_n(dws->fc_mem, __ATOMIC_RELAXED))\n+\t\t;\n+\n+\tcnxk_sso_hws_add_work(event_ptr, tag, new_tt,\n+\t\t\t      dws->grp_base + (grp << 12));\n+}\n+\n static __rte_always_inline void\n cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base,\n \t\t\t\tconst struct rte_event *ev)\n@@ -126,10 +147,12 @@ cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base,\n \t} else {\n \t\t/*\n \t\t * Group has been changed for group based work pipelining,\n-\t\t * Use deschedule/add_work operation to transfer the event to\n+\t\t * Use add_work operation to transfer the event to\n \t\t * new group/core\n \t\t */\n-\t\tcn9k_sso_hws_fwd_group(base, ev, grp);\n+\t\trte_atomic_thread_fence(__ATOMIC_RELEASE);\n+\t\troc_sso_hws_head_wait(base);\n+\t\tcn9k_sso_hws_dual_new_event_wait(dws, ev);\n \t}\n }\n \n",
    "prefixes": [
        "1/2"
    ]
}