Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107400/?format=api
{ "id": 107400, "url": "http://patches.dpdk.org/api/patches/107400/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220212123820.3394341-3-gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220212123820.3394341-3-gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220212123820.3394341-3-gmuthukrishn@marvell.com", "date": "2022-02-12T12:38:20", "name": "[3/3] common/cnxk: fix uninitialized pointer read", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7afd70b62d6eaf1da7a07542f729ce30de4a61dc", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220212123820.3394341-3-gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 21643, "url": "http://patches.dpdk.org/api/series/21643/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21643", "date": "2022-02-12T12:38:18", "name": "[1/3] common/cnxk: check return value for error", "version": 1, "mbox": "http://patches.dpdk.org/series/21643/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107400/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 248A0A034E;\n\tSat, 12 Feb 2022 13:38:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 127294117D;\n\tSat, 12 Feb 2022 13:38:40 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 09CC44118F\n for <dev@dpdk.org>; Sat, 12 Feb 2022 13:38:37 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 21CBs89r000545\n for <dev@dpdk.org>; Sat, 12 Feb 2022 04:38:37 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3e6b4rr8jk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Sat, 12 Feb 2022 04:38:37 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Sat, 12 Feb 2022 04:38:35 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sat, 12 Feb 2022 04:38:35 -0800", "from localhost.localdomain (unknown [10.28.34.38])\n by maili.marvell.com (Postfix) with ESMTP id 78B625B6941;\n Sat, 12 Feb 2022 04:38:33 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=tv/E1QmIKfqJsX1bgMK267vb+dxGEy3RJok1oTQiOKo=;\n b=PWMY1YbCVKxcdyo2RzpJdShsRSaEGowLf622UhFeWwxa8Qa+CPw0Eh8h5x+jQlGQ2Rbx\n x2qA5utzCfNWDL29FcOauMGRhJ7apDd/vbbZpHUakS5cziHBGasTeKz1Ba2gIxm50XNe\n /7qHAvm46IKS5STCcdv3Pu4xRmJNPvV9+hdKda5LC28MNeKaU8ywWUneLjB1PvHYgFmu\n vHw7rm/4xkshs5pCDSZsjSGIUttvyPjVOTegA3Mii9dr6DmYwd/XGlrexCbkn9sXv2FA\n A9KmouVMdjIv0+Yxa0TLgzJEUrxmY3w8HgZnOoJKIPdmJbuuT3I2vDCww3xNLAz5v4vo JQ==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>, <jerinj@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>", "Subject": "[PATCH 3/3] common/cnxk: fix uninitialized pointer read", "Date": "Sat, 12 Feb 2022 18:08:20 +0530", "Message-ID": "<20220212123820.3394341-3-gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220212123820.3394341-1-gmuthukrishn@marvell.com>", "References": "<20220212123820.3394341-1-gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "dSRZMdimqehxesvW9Dwo5b09Z7FPPPnk", "X-Proofpoint-GUID": "dSRZMdimqehxesvW9Dwo5b09Z7FPPPnk", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2022-02-12_04,2022-02-11_01,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix uninitialized pointer read reported in coverity scan.\n\nFixes: c34ea71b878 (\"common/cnxk: add NPC parsing API\")\nCoverity issue: 370214, 370217, 370219, 370220, 370221, 370223,\n 370224, 370225, 372065\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\n drivers/common/cnxk/roc_npc_parse.c | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c\nindex 1f21693369..41ff0fcc6b 100644\n--- a/drivers/common/cnxk/roc_npc_parse.c\n+++ b/drivers/common/cnxk/roc_npc_parse.c\n@@ -112,6 +112,7 @@ npc_parse_cpt_hdr(struct npc_parse_state *pst)\n \tinfo.hw_hdr_len = 0;\n \n \t/* Prepare for parsing the item */\n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = &hw_mask;\n \tinfo.len = pst->pattern->size;\n \tnpc_get_hw_supp_mask(pst, &info, lid, lt);\n@@ -149,6 +150,7 @@ npc_parse_higig2_hdr(struct npc_parse_state *pst)\n \t}\n \n \t/* Prepare for parsing the item */\n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = &hw_mask;\n \tinfo.len = pst->pattern->size;\n \tnpc_get_hw_supp_mask(pst, &info, lid, lt);\n@@ -198,6 +200,7 @@ npc_parse_la(struct npc_parse_state *pst)\n \t}\n \n \t/* Prepare for parsing the item */\n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = &hw_mask;\n \tinfo.len = sizeof(eth_item->hdr);\n \tnpc_get_hw_supp_mask(pst, &info, lid, lt);\n@@ -236,6 +239,7 @@ npc_parse_lb(struct npc_parse_state *pst)\n \tint nr_vlans = 0;\n \tint rc;\n \n+\tinfo.def_mask = NULL;\n \tinfo.spec = NULL;\n \tinfo.mask = NULL;\n \tinfo.def_mask = NULL;\n@@ -396,12 +400,12 @@ npc_parse_mpls_label_stack(struct npc_parse_state *pst, int *flag)\n \t * pst->pattern points to first MPLS label. We only check\n \t * that subsequent labels do not have anything to match.\n \t */\n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = NULL;\n \tinfo.len = pattern->size;\n \tinfo.spec = NULL;\n \tinfo.mask = NULL;\n \tinfo.hw_hdr_len = 0;\n-\tinfo.def_mask = NULL;\n \n \twhile (pattern->type == ROC_NPC_ITEM_TYPE_MPLS) {\n \t\tnr_labels++;\n@@ -447,6 +451,7 @@ npc_parse_mpls(struct npc_parse_state *pst, int lid)\n \tinfo.len = pst->pattern->size;\n \tinfo.spec = NULL;\n \tinfo.mask = NULL;\n+\tinfo.def_mask = NULL;\n \tinfo.hw_hdr_len = 0;\n \n \tnpc_get_hw_supp_mask(pst, &info, lid, lt);\n@@ -547,6 +552,7 @@ npc_parse_lc(struct npc_parse_state *pst)\n \tif (pst->pattern->type == ROC_NPC_ITEM_TYPE_MPLS)\n \t\treturn npc_parse_mpls(pst, NPC_LID_LC);\n \n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = &hw_mask;\n \tinfo.spec = NULL;\n \tinfo.mask = NULL;\n@@ -638,10 +644,10 @@ npc_parse_ld(struct npc_parse_state *pst)\n \t\t\treturn npc_parse_mpls(pst, NPC_LID_LD);\n \t\treturn 0;\n \t}\n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = &hw_mask;\n \tinfo.spec = NULL;\n \tinfo.mask = NULL;\n-\tinfo.def_mask = NULL;\n \tinfo.len = 0;\n \tinfo.hw_hdr_len = 0;\n \n@@ -797,6 +803,7 @@ npc_parse_lf(struct npc_parse_state *pst)\n \tlflags = 0;\n \n \t/* No match support for vlan tags */\n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = NULL;\n \tinfo.len = pst->pattern->size;\n \tinfo.spec = NULL;\n@@ -855,6 +862,7 @@ npc_parse_lg(struct npc_parse_state *pst)\n \tif (!pst->tunnel)\n \t\treturn 0;\n \n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = &hw_mask;\n \tinfo.spec = NULL;\n \tinfo.mask = NULL;\n@@ -891,6 +899,7 @@ npc_parse_lh(struct npc_parse_state *pst)\n \tif (!pst->tunnel)\n \t\treturn 0;\n \n+\tinfo.def_mask = NULL;\n \tinfo.hw_mask = &hw_mask;\n \tinfo.spec = NULL;\n \tinfo.mask = NULL;\n", "prefixes": [ "3/3" ] }