Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107307/?format=api
{ "id": 107307, "url": "http://patches.dpdk.org/api/patches/107307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220210230906.833163-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220210230906.833163-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220210230906.833163-3-stephen@networkplumber.org", "date": "2022-02-10T23:09:05", "name": "[2/3] app/test_bpf: don't print eBPF program if NULL", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cdc60a3cddafcd255a420ca677997c905748de3d", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220210230906.833163-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 21615, "url": "http://patches.dpdk.org/api/series/21615/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21615", "date": "2022-02-10T23:09:03", "name": "small fixes suggested by Coverity scan", "version": 1, "mbox": "http://patches.dpdk.org/series/21615/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107307/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1689A00BE;\n\tFri, 11 Feb 2022 00:09:22 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D82B34118A;\n\tFri, 11 Feb 2022 00:09:15 +0100 (CET)", "from mail-pj1-f47.google.com (mail-pj1-f47.google.com\n [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 60A964113C\n for <dev@dpdk.org>; Fri, 11 Feb 2022 00:09:13 +0100 (CET)", "by mail-pj1-f47.google.com with SMTP id\n r64-20020a17090a43c600b001b8854e682eso7143828pjg.0\n for <dev@dpdk.org>; Thu, 10 Feb 2022 15:09:13 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n y191sm24924970pfb.114.2022.02.10.15.09.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 10 Feb 2022 15:09:11 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=GcKo7iGchep3EO6+jh8CsUbjdcNAUCIxZmtJcexeGs0=;\n b=gU9cq0qWFHMqEInRDP4lb0CPo44k/Fgd1L+GssnFvt0pvbEgkE4wD+bB3W5wn/ZJzK\n DI+dOQ16XFICKlAi7u+9SieK/XyWATAhUofWQCzWUxk6lMOMvOyJ3nspz9f0D4gMtJeB\n BtWOlNvhSt2g2Ck/M0wn95cewDFenp50JtOLuVegau7UMFqOG2kXMR2f0OVEFEeA/2US\n jiIH5yN2BvdVm/4p6qnFpTt7BAO9RgbJ21xZK393bCNNOe5YCSQyasqIKopbB4mcbxqM\n EbnlaQf7VkzW3hKwaXkzYp0tvBm1a65k3XP17+RqEQjeY3nFcuJgiePozFODL+lW6oti\n eXWg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=GcKo7iGchep3EO6+jh8CsUbjdcNAUCIxZmtJcexeGs0=;\n b=7ybYjyNDPEMYcQss5tqXii6rDZXZlI8CjwIoXBzqgRPhZk2UR/SJGqWxelBQEZtYBO\n NkwgLqAgBBWYNK4ytYtbawl0YagOgo085SEesxjh46q4vdj5Kq5eFNi5Ulrm2egDUGfr\n EhexTCQ2hxUadmJYVb18ywRw1ViDEynyN1fJ6+jB995eQprD95b15scC7lFrbbe0xRlU\n XqYDGdEneTx3WGh7y2W5GIVfB94+wkiAkRT0Yt2lKeFk30A7bfcjQLApVe72/28BWPdz\n qYICFinjEIKJfVcN1zf6Qm0FtMlfR9LztxiFQty3R0K+UnAHsGW7jyNlov5NlJQEOx0R\n mfXw==", "X-Gm-Message-State": "AOAM533+qDF8Qr2gfimOXSpWFa0ozkuL9ETaDPy3jucpuuE7wwGlbsLI\n C2QTzPk+DNz06si8MxAsbhKAohUPK8j9fv2x", "X-Google-Smtp-Source": "\n ABdhPJyNt6+tZ0hWi0lI5UwY+bdu/x3YGZYt2/FEx8AZIfrNRNRpap8rzPXgKFN6bwA7YGVakpsGMQ==", "X-Received": "by 2002:a17:902:758c:: with SMTP id\n j12mr9554220pll.79.1644534552001;\n Thu, 10 Feb 2022 15:09:12 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH 2/3] app/test_bpf: don't print eBPF program if NULL", "Date": "Thu, 10 Feb 2022 15:09:05 -0800", "Message-Id": "<20220210230906.833163-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220210230906.833163-1-stephen@networkplumber.org>", "References": "<20220210230906.833163-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If conversion of cBPF to eBPF fails (in rte_bpf_convert)\nthen the test should not try and print the result.\n\nCoverity issue: 373661\nFixes: 2eccf6afbea9 (\"bpf: add function to convert classic BPF to DPDK BPF\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_bpf.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c\nindex d1e10adab545..805cce640667 100644\n--- a/app/test/test_bpf.c\n+++ b/app/test/test_bpf.c\n@@ -3273,8 +3273,10 @@ test_bpf_dump(struct bpf_program *cbf, const struct rte_bpf_prm *prm)\n \tprintf(\"cBPF program (%u insns)\\n\", cbf->bf_len);\n \tbpf_dump(cbf, 1);\n \n-\tprintf(\"\\neBPF program (%u insns)\\n\", prm->nb_ins);\n-\trte_bpf_dump(stdout, prm->ins, prm->nb_ins);\n+\tif (prm != NULL) {\n+\t\tprintf(\"\\neBPF program (%u insns)\\n\", prm->nb_ins);\n+\t\trte_bpf_dump(stdout, prm->ins, prm->nb_ins);\n+\t}\n }\n \n static int\n", "prefixes": [ "2/3" ] }