Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107276/?format=api
{ "id": 107276, "url": "http://patches.dpdk.org/api/patches/107276/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220210154239.587185-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220210154239.587185-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220210154239.587185-6-bruce.richardson@intel.com", "date": "2022-02-10T15:42:37", "name": "[v4,5/7] table: fix missing explicit casts for C++ build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d219cc7ad0485bea304cff52637f6bba7e0c34ad", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220210154239.587185-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21607, "url": "http://patches.dpdk.org/api/series/21607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21607", "date": "2022-02-10T15:42:32", "name": "Verify C++ compatibility of public headers", "version": 4, "mbox": "http://patches.dpdk.org/series/21607/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107276/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107276/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4AF61A00BE;\n\tThu, 10 Feb 2022 16:43:29 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9D61742769;\n\tThu, 10 Feb 2022 16:43:14 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 1CA0B426F7;\n Thu, 10 Feb 2022 16:43:07 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Feb 2022 07:43:03 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.162])\n by orsmga006.jf.intel.com with ESMTP; 10 Feb 2022 07:43:01 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1644507788; x=1676043788;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Pw8h7l85GTUAWLoIdKJY/D6EzLxrtOlOWNXgp0QmUVE=;\n b=fmgffaW3W710WjxKhG53SYdGFlQIy/ExWXGzkFsrHG0FAlnVZ8n9acU6\n U1pqOKhbo9OHQn73d214IGrF7muxXgpL5IKQ7Q1GgE6kBJCRu7Icxm1D+\n bdgktpySOw0byryV29ieMld37YrpXDTkXbgdPXomk23uGkAp5z6RhrahA\n 8W2O4TMRdrlMjzLDyhmYifyItgcfyq2/lzUl3mbDEE+mtUUt1xL0sSel1\n dTma33FVLYhYkJTqr5gr+Fb5KF1rvmeqfzpxYRFwMdcJMi73oQ9c3PNpU\n e/yEMGg3PsEB8gEkAo5Rudf2NKnybWpS7ozxn8b0hJiJnfcD50fTw7BqM g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10254\"; a=\"247101183\"", "E=Sophos;i=\"5.88,359,1635231600\"; d=\"scan'208\";a=\"247101183\"", "E=Sophos;i=\"5.88,359,1635231600\"; d=\"scan'208\";a=\"485723465\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, kevin.laatz@intel.com,\n cristian.dumitrescu@intel.com, stable@dpdk.org,\n Gavin Hu <gavin.hu@arm.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>", "Subject": "[PATCH v4 5/7] table: fix missing explicit casts for C++ build", "Date": "Thu, 10 Feb 2022 15:42:37 +0000", "Message-Id": "<20220210154239.587185-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220210154239.587185-1-bruce.richardson@intel.com>", "References": "<20220204174209.440207-1-bruce.richardson@intel.com>\n <20220210154239.587185-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Since C++ doesn't support automatic casting from void * to other types,\nwe need to explicitly add the casts to any header files in DPDK.\n\nFixes: ea7be0a0386e (\"lib/librte_table: add hash function headers\")\nCc: kevin.laatz@intel.com\nCc: cristian.dumitrescu@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/table/rte_table_hash_func.h | 32 ++++++++++++++++----------------\n 1 file changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/table/rte_table_hash_func.h b/lib/table/rte_table_hash_func.h\nindex c4c35cc06a..a962ec2f68 100644\n--- a/lib/table/rte_table_hash_func.h\n+++ b/lib/table/rte_table_hash_func.h\n@@ -58,8 +58,8 @@ static inline uint64_t\n rte_table_hash_crc_key8(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t crc0;\n \n \tcrc0 = rte_crc32_u64(seed, k[0] & m[0]);\n@@ -72,8 +72,8 @@ static inline uint64_t\n rte_table_hash_crc_key16(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t k0, crc0, crc1;\n \n \tk0 = k[0] & m[0];\n@@ -91,8 +91,8 @@ static inline uint64_t\n rte_table_hash_crc_key24(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t k0, k2, crc0, crc1;\n \n \tk0 = k[0] & m[0];\n@@ -113,8 +113,8 @@ static inline uint64_t\n rte_table_hash_crc_key32(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t k0, k2, crc0, crc1, crc2, crc3;\n \n \tk0 = k[0] & m[0];\n@@ -139,8 +139,8 @@ static inline uint64_t\n rte_table_hash_crc_key40(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t k0, k2, crc0, crc1, crc2, crc3;\n \n \tk0 = k[0] & m[0];\n@@ -165,8 +165,8 @@ static inline uint64_t\n rte_table_hash_crc_key48(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t k0, k2, k5, crc0, crc1, crc2, crc3;\n \n \tk0 = k[0] & m[0];\n@@ -192,8 +192,8 @@ static inline uint64_t\n rte_table_hash_crc_key56(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t k0, k2, k5, crc0, crc1, crc2, crc3, crc4, crc5;\n \n \tk0 = k[0] & m[0];\n@@ -222,8 +222,8 @@ static inline uint64_t\n rte_table_hash_crc_key64(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n {\n-\tuint64_t *k = key;\n-\tuint64_t *m = mask;\n+\tuint64_t *k = (uint64_t *)key;\n+\tuint64_t *m = (uint64_t *)mask;\n \tuint64_t k0, k2, k5, crc0, crc1, crc2, crc3, crc4, crc5;\n \n \tk0 = k[0] & m[0];\n", "prefixes": [ "v4", "5/7" ] }