Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107265/?format=api
{ "id": 107265, "url": "http://patches.dpdk.org/api/patches/107265/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220210140355.586399-8-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220210140355.586399-8-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220210140355.586399-8-bruce.richardson@intel.com", "date": "2022-02-10T14:03:55", "name": "[v3,7/7] buildtools/chkincs: test headers for C++ compatibility", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a9474a587e7fd2a7b1ef28c9aa6e996f44ff6d4e", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220210140355.586399-8-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21603, "url": "http://patches.dpdk.org/api/series/21603/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21603", "date": "2022-02-10T14:03:48", "name": "Verify C++ compatibility of public headers", "version": 3, "mbox": "http://patches.dpdk.org/series/21603/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107265/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/107265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C5D5CA00C2;\n\tThu, 10 Feb 2022 15:05:11 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E757742745;\n\tThu, 10 Feb 2022 15:04:40 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 1D9E94271E\n for <dev@dpdk.org>; Thu, 10 Feb 2022 15:04:35 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Feb 2022 06:04:35 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.162])\n by fmsmga008.fm.intel.com with ESMTP; 10 Feb 2022 06:04:34 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1644501876; x=1676037876;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=4Ibb21kATi9rzqe3WyPjCC7aDfmyQy2U45C/Ium/Krk=;\n b=DnGIW28zlWbBAjdcZrov6w5thHRdCeNB6mtHlXapfZlq95EQf2WpIuJF\n BvUhV2X/K4OcTCY1W7QcpBIiWTyOR+8Gx4MuZaKCe+QDiJ0rHNkKMT/Of\n 68MHnnWA2KvDl/M46dqXWJPOhbDZIdSZ2CeHY6tlpE4Ii5hgK+FF8niFo\n +1rJ6wtEHst9Tv7Rma8Ry0VsXfN2cB5bgiPDMgVIR/m1KU5on/d+o+kDq\n 2BGCkMpyZsDsgTXVmmfvJ51IgTWiK7+BIBk74Vg8oUlez+jmsGjJIREMy\n y5TRTzvLM9fA42CSfenokIar9K4ScSPIiB4k/E4yOvKM84uOmR6oE7Jws A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10253\"; a=\"312781119\"", "E=Sophos;i=\"5.88,358,1635231600\"; d=\"scan'208\";a=\"312781119\"", "E=Sophos;i=\"5.88,358,1635231600\"; d=\"scan'208\";a=\"585964294\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Aaron Conole <aconole@redhat.com>,\n Michael Santana <maicolgabriel@hotmail.com>", "Subject": "[PATCH v3 7/7] buildtools/chkincs: test headers for C++ compatibility", "Date": "Thu, 10 Feb 2022 14:03:55 +0000", "Message-Id": "<20220210140355.586399-8-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220210140355.586399-1-bruce.richardson@intel.com>", "References": "<20220204174209.440207-1-bruce.richardson@intel.com>\n <20220210140355.586399-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support for checking each of our headers for issues when included in\na C++ file.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n .ci/linux-build.sh | 1 +\n buildtools/chkincs/main.cpp | 4 ++++\n buildtools/chkincs/meson.build | 20 ++++++++++++++++++++\n 3 files changed, 25 insertions(+)\n create mode 100644 buildtools/chkincs/main.cpp", "diff": "diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh\nindex c10c1a8ab5..67d68535e0 100755\n--- a/.ci/linux-build.sh\n+++ b/.ci/linux-build.sh\n@@ -74,6 +74,7 @@ fi\n \n if [ \"$BUILD_32BIT\" = \"true\" ]; then\n OPTS=\"$OPTS -Dc_args=-m32 -Dc_link_args=-m32\"\n+ OPTS=\"$OPTS -Dcpp_args=-m32 -Dcpp_link_args=-m32\"\n export PKG_CONFIG_LIBDIR=\"/usr/lib32/pkgconfig\"\n fi\n \ndiff --git a/buildtools/chkincs/main.cpp b/buildtools/chkincs/main.cpp\nnew file mode 100644\nindex 0000000000..d25bb8852a\n--- /dev/null\n+++ b/buildtools/chkincs/main.cpp\n@@ -0,0 +1,4 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2021 Intel Corporation\n+ */\n+int main(void) { return 0; }\ndiff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build\nindex 5ffca89761..beabcd55d8 100644\n--- a/buildtools/chkincs/meson.build\n+++ b/buildtools/chkincs/meson.build\n@@ -28,3 +28,23 @@ executable('chkincs', sources,\n dependencies: deps,\n link_whole: dpdk_static_libraries + dpdk_drivers,\n install: false)\n+\n+# run tests for c++ builds also\n+if not add_languages('cpp', required: false)\n+ subdir_done()\n+endif\n+\n+gen_cpp_files = generator(gen_c_file_for_header,\n+ output: '@BASENAME@.cpp',\n+ arguments: ['@INPUT@', '@OUTPUT@'])\n+\n+cpp_sources = files('main.cpp')\n+cpp_sources += gen_cpp_files.process(dpdk_chkinc_headers)\n+\n+executable('chkincs-cpp', cpp_sources,\n+ cpp_args: ['-include', 'rte_config.h', cflags],\n+ link_args: dpdk_extra_ldflags,\n+ include_directories: includes,\n+ dependencies: deps,\n+ link_whole: dpdk_static_libraries + dpdk_drivers,\n+ install: false)\n", "prefixes": [ "v3", "7/7" ] }