Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107264/?format=api
{ "id": 107264, "url": "http://patches.dpdk.org/api/patches/107264/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220210140355.586399-7-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220210140355.586399-7-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220210140355.586399-7-bruce.richardson@intel.com", "date": "2022-02-10T14:03:54", "name": "[v3,6/7] vhost: fix incompatible header includes for C++", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ff575a6bad3f3326c15f1b229cda988ccf0f6b40", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220210140355.586399-7-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21603, "url": "http://patches.dpdk.org/api/series/21603/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21603", "date": "2022-02-10T14:03:48", "name": "Verify C++ compatibility of public headers", "version": 3, "mbox": "http://patches.dpdk.org/series/21603/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107264/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107264/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 168CAA00BE;\n\tThu, 10 Feb 2022 15:05:05 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1529A42743;\n\tThu, 10 Feb 2022 15:04:40 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id EB7B442732;\n Thu, 10 Feb 2022 15:04:34 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Feb 2022 06:04:34 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.162])\n by fmsmga008.fm.intel.com with ESMTP; 10 Feb 2022 06:04:33 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1644501875; x=1676037875;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=veIxnvD4HcP71geTR9XiNe9UbAQ5n7+OKC29V7i55zI=;\n b=ViGwBfVolDc0j5GXIQ8cC6cDzItWyDoHDz6qDpvPVWM8clX6jMgchYtC\n lpj2hAvaE0yy8jU7aN0nGLv1uxTbvkm5DVC19a6SmQ+pdnZJ034o9q7E4\n Hr393UYovb1uTB7A6jR1dcuIKPQO3OlWLBtzIT6LEL1GIYA+FAKucjJUo\n hYPwePL7nefYIIkKIk9SWYp31YNjwr3iGWhJkdz3HayIDxDbhsfZ2pvgA\n VijkgiIYYbKR1LptfUVCRy+sUuk7aNdDNJ0CNJ14H6cy0+oDAKkiXpWXT\n fiXbZaAuzUZ3/RZ8Tfc8BAjRJZ3uL/j/hFgb08B75HNeI8EWVgw9QIvbW g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10253\"; a=\"312781116\"", "E=Sophos;i=\"5.88,358,1635231600\"; d=\"scan'208\";a=\"312781116\"", "E=Sophos;i=\"5.88,358,1635231600\"; d=\"scan'208\";a=\"585964285\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, adrien.mazarguil@6wind.com,\n stable@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v3 6/7] vhost: fix incompatible header includes for C++", "Date": "Thu, 10 Feb 2022 14:03:54 +0000", "Message-Id": "<20220210140355.586399-7-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220210140355.586399-1-bruce.richardson@intel.com>", "References": "<20220204174209.440207-1-bruce.richardson@intel.com>\n <20220210140355.586399-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The virtio kernel header includes are already noted as being\nincompatible with C++. We can ensure that the header is safe for\ninclusion in C++ code by not including those headers during C++ builds.\nWhile not ideal, this does ensure that all DPDK headers can be included\nin C++ code without errors.\n\nFixes: f8904d563691 (\"vhost: fix header for strict compilation flags\")\nCc: adrien.mazarguil@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/vhost/rte_vhost.h | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h\nindex b454c05868..2acb31df2d 100644\n--- a/lib/vhost/rte_vhost.h\n+++ b/lib/vhost/rte_vhost.h\n@@ -21,10 +21,12 @@\n extern \"C\" {\n #endif\n \n+#ifndef __cplusplus\n /* These are not C++-aware. */\n #include <linux/vhost.h>\n #include <linux/virtio_ring.h>\n #include <linux/virtio_net.h>\n+#endif\n \n #define RTE_VHOST_USER_CLIENT\t\t(1ULL << 0)\n #define RTE_VHOST_USER_NO_RECONNECT\t(1ULL << 1)\n", "prefixes": [ "v3", "6/7" ] }