Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106949/?format=api
{ "id": 106949, "url": "http://patches.dpdk.org/api/patches/106949/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220207072932.22409-18-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220207072932.22409-18-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220207072932.22409-18-ndabilpuram@marvell.com", "date": "2022-02-07T07:29:30", "name": "[18/20] net/cnxk: enable flow control by default on device configure", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5ef1aace7a3ff77466726a53921148a9f512ebfb", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220207072932.22409-18-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 21483, "url": "http://patches.dpdk.org/api/series/21483/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21483", "date": "2022-02-07T07:29:13", "name": "[01/20] common/cnxk: increase resource count for bitmap alloc", "version": 1, "mbox": "http://patches.dpdk.org/series/21483/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106949/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106949/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7B5EA034F;\n\tMon, 7 Feb 2022 08:32:05 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1F64A4122E;\n\tMon, 7 Feb 2022 08:30:41 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id B7B5D4122E\n for <dev@dpdk.org>; Mon, 7 Feb 2022 08:30:39 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 216NOarY004938\n for <dev@dpdk.org>; Sun, 6 Feb 2022 23:30:39 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e1smr4p6f-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Sun, 06 Feb 2022 23:30:38 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 6 Feb 2022 23:30:36 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sun, 6 Feb 2022 23:30:36 -0800", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id E91113F7063;\n Sun, 6 Feb 2022 23:30:34 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=E0Y80ZP1kj7SKhl6dMHcaOkR4257hh64ZBw8tKWQS50=;\n b=J9YiX95E88x9ps0PuMdx7jbdRDmqFP7Ra8FBWLeDkT5RuacNYVmLfueiREzpCMmf5NzO\n IuAybB3RKD8AYMR2BB7UFsbvZmgU26F1yuzQM1sOYZMPIu/OXeivK6V9BXUukx+ChzOI\n SSkY755v969SVbK0X3gjs/xkLK/8vSAJ8lm6WFVSREtsDHGWciQGPES49Iuji0IpjuvC\n 9PwMavm9Tv0/04RnG63pnLKB0dcbbIAaLiCiytEoj8aGramqAg1GZ6qcu16Yr/9YCktW\n BLv/ez6SWmQWyd9ZUQLy12BO2wes5TBvw3wvUTbkO8kTlJH43N5seHoTXI2syi/AN3on gg==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 18/20] net/cnxk: enable flow control by default on device\n configure", "Date": "Mon, 7 Feb 2022 12:59:30 +0530", "Message-ID": "<20220207072932.22409-18-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20220207072932.22409-1-ndabilpuram@marvell.com>", "References": "<20220207072932.22409-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "PYafvVjB7KZFAicyY9NpyaVDN2GQWcnN", "X-Proofpoint-ORIG-GUID": "PYafvVjB7KZFAicyY9NpyaVDN2GQWcnN", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2022-02-07_02,2022-02-03_01,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enable flow control by default on device configuration\ninstead of basing it on Kernel behaviour.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/net/cnxk/cnxk_ethdev.c | 24 +++++++-----------------\n 1 file changed, 7 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex aa76d87..e4fbb09 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -306,25 +306,15 @@ static int\n nix_init_flow_ctrl_config(struct rte_eth_dev *eth_dev)\n {\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n-\tstruct cnxk_fc_cfg *fc = &dev->fc_cfg;\n-\tstruct rte_eth_fc_conf fc_conf = {0};\n-\tint rc;\n+\tenum roc_nix_fc_mode fc_mode = ROC_NIX_FC_FULL;\n \n-\t/* Both Rx & Tx flow ctrl get enabled(RTE_ETH_FC_FULL) in HW\n-\t * by AF driver, update those info in PMD structure.\n-\t */\n-\trc = cnxk_nix_flow_ctrl_get(eth_dev, &fc_conf);\n-\tif (rc)\n-\t\tgoto exit;\n+\t/* To avoid Link credit deadlock on Ax, disable Tx FC if it's enabled */\n+\tif (roc_model_is_cn96_ax() &&\n+\t dev->npc.switch_header_type != ROC_PRIV_FLAGS_HIGIG)\n+\t\tfc_mode = ROC_NIX_FC_TX;\n \n-\tfc->mode = fc_conf.mode;\n-\tfc->rx_pause = (fc_conf.mode == RTE_ETH_FC_FULL) ||\n-\t\t\t(fc_conf.mode == RTE_ETH_FC_RX_PAUSE);\n-\tfc->tx_pause = (fc_conf.mode == RTE_ETH_FC_FULL) ||\n-\t\t\t(fc_conf.mode == RTE_ETH_FC_TX_PAUSE);\n-\n-exit:\n-\treturn rc;\n+\t/* By default enable flow control */\n+\treturn roc_nix_fc_mode_set(&dev->nix, fc_mode);\n }\n \n static int\n", "prefixes": [ "18/20" ] }