Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106941/?format=api
{ "id": 106941, "url": "http://patches.dpdk.org/api/patches/106941/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220207072932.22409-10-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220207072932.22409-10-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220207072932.22409-10-ndabilpuram@marvell.com", "date": "2022-02-07T07:29:22", "name": "[10/20] net/cnxk: added Rx metadata negotiate operation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "74e74e38dd680b9b1d5c12bd4ef02e79d5bcd3be", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220207072932.22409-10-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 21483, "url": "http://patches.dpdk.org/api/series/21483/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21483", "date": "2022-02-07T07:29:13", "name": "[01/20] common/cnxk: increase resource count for bitmap alloc", "version": 1, "mbox": "http://patches.dpdk.org/series/21483/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106941/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/106941/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3C11A034F;\n\tMon, 7 Feb 2022 08:31:15 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 471514118A;\n\tMon, 7 Feb 2022 08:30:23 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 25C294115F\n for <dev@dpdk.org>; Mon, 7 Feb 2022 08:30:20 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 216LsOhK030467\n for <dev@dpdk.org>; Sun, 6 Feb 2022 23:30:19 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e1smr4p4b-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Sun, 06 Feb 2022 23:30:19 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 6 Feb 2022 23:30:14 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Sun, 6 Feb 2022 23:30:14 -0800", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id CCBF93F7068;\n Sun, 6 Feb 2022 23:30:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=YjmvKLBYCF2iPDRI+O+uE699mRBKS4ePnudkDlpTWeg=;\n b=hALbjS6Av7cKghg/ps4Ch595GsAyEKCKMqb1jA8NfTkuUi/23mHA8LqC4EiEgaqkJAe8\n UEUGUlqmoAVNLrn6IXCN2FGFI55KMo63O5Xsr4bNcR+xHLrsLB6qyCSq3+RDnzRECIIf\n +Kpp7ZIDl8tFHHNdyQz8XXVczM0wuMjAIC5aTPK8tatmtqN01EuO2Ap7yldGc0jBr+lA\n WodUdhUHTcfeFxCC/OGuN/p73lT6ApsqGs5dGHSmoW4Dl59Zy9ip8CD/0O0lKpqvocvE\n PVfzJGA/5LPW0jJu/kemmAuwPoIp2l5EB2GqITzcNdGMW9bWG4iqyPWIhuob85UkUPdR TQ==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 10/20] net/cnxk: added Rx metadata negotiate operation", "Date": "Mon, 7 Feb 2022 12:59:22 +0530", "Message-ID": "<20220207072932.22409-10-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20220207072932.22409-1-ndabilpuram@marvell.com>", "References": "<20220207072932.22409-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "xDCLpEc7jh71V5BALCA8dd4Dvv0-Q-wn", "X-Proofpoint-ORIG-GUID": "xDCLpEc7jh71V5BALCA8dd4Dvv0-Q-wn", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2022-02-07_02,2022-02-03_01,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Satha Rao <skoteshwar@marvell.com>\n\nAdded rx_metadata_negotiate api to enable mark update RX offload.\nRemoved software logic to enable/disable mark update inside flow\ncreate/destroy apis.\n\nSigned-off-by: Satha Rao <skoteshwar@marvell.com>\n---\n drivers/net/cnxk/cn10k_ethdev.c | 26 ++++++++++++++++++++++++++\n drivers/net/cnxk/cn10k_rte_flow.c | 20 ++------------------\n drivers/net/cnxk/cn9k_ethdev.c | 25 +++++++++++++++++++++++++\n drivers/net/cnxk/cn9k_rte_flow.c | 20 ++------------------\n drivers/net/cnxk/cnxk_ethdev.h | 1 +\n 5 files changed, 56 insertions(+), 36 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c\nindex 8378cbf..169e70e 100644\n--- a/drivers/net/cnxk/cn10k_ethdev.c\n+++ b/drivers/net/cnxk/cn10k_ethdev.c\n@@ -39,6 +39,9 @@ nix_rx_offload_flags(struct rte_eth_dev *eth_dev)\n \tif (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY)\n \t\tflags |= NIX_RX_OFFLOAD_SECURITY_F;\n \n+\tif (dev->rx_mark_update)\n+\t\tflags |= NIX_RX_OFFLOAD_MARK_UPDATE_F;\n+\n \treturn flags;\n }\n \n@@ -470,6 +473,27 @@ cn10k_nix_dev_start(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n+static int\n+cn10k_nix_rx_metadata_negotiate(struct rte_eth_dev *eth_dev, uint64_t *features)\n+{\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\n+\t*features &=\n+\t\t(RTE_ETH_RX_METADATA_USER_FLAG | RTE_ETH_RX_METADATA_USER_MARK);\n+\n+\tif (*features) {\n+\t\tdev->rx_offload_flags |= NIX_RX_OFFLOAD_MARK_UPDATE_F;\n+\t\tdev->rx_mark_update = true;\n+\t} else {\n+\t\tdev->rx_offload_flags &= ~NIX_RX_OFFLOAD_MARK_UPDATE_F;\n+\t\tdev->rx_mark_update = false;\n+\t}\n+\n+\tcn10k_eth_set_rx_function(eth_dev);\n+\n+\treturn 0;\n+}\n+\n /* Update platform specific eth dev ops */\n static void\n nix_eth_dev_ops_override(void)\n@@ -489,6 +513,8 @@ nix_eth_dev_ops_override(void)\n \tcnxk_eth_dev_ops.dev_ptypes_set = cn10k_nix_ptypes_set;\n \tcnxk_eth_dev_ops.timesync_enable = cn10k_nix_timesync_enable;\n \tcnxk_eth_dev_ops.timesync_disable = cn10k_nix_timesync_disable;\n+\tcnxk_eth_dev_ops.rx_metadata_negotiate =\n+\t\tcn10k_nix_rx_metadata_negotiate;\n }\n \n static void\ndiff --git a/drivers/net/cnxk/cn10k_rte_flow.c b/drivers/net/cnxk/cn10k_rte_flow.c\nindex 529fb0e..ea71efa 100644\n--- a/drivers/net/cnxk/cn10k_rte_flow.c\n+++ b/drivers/net/cnxk/cn10k_rte_flow.c\n@@ -131,9 +131,9 @@ cn10k_flow_create(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,\n \tconst struct rte_flow_action *action_rss = NULL;\n \tconst struct rte_flow_action_meter *mtr = NULL;\n \tconst struct rte_flow_action *act_q = NULL;\n-\tint mark_actions = 0, vtag_actions = 0;\n \tstruct roc_npc *npc = &dev->npc;\n \tstruct roc_npc_flow *flow;\n+\tint vtag_actions = 0;\n \tuint32_t req_act = 0;\n \tint i, rc;\n \n@@ -197,13 +197,6 @@ cn10k_flow_create(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,\n \t\t\tcn10k_mtr_connect(eth_dev, mtr->mtr_id);\n \t}\n \n-\tmark_actions = roc_npc_mark_actions_get(npc);\n-\n-\tif (mark_actions) {\n-\t\tdev->rx_offload_flags |= NIX_RX_OFFLOAD_MARK_UPDATE_F;\n-\t\tcn10k_eth_set_rx_function(eth_dev);\n-\t}\n-\n \tvtag_actions = roc_npc_vtag_actions_get(npc);\n \n \tif (vtag_actions) {\n@@ -220,20 +213,11 @@ cn10k_flow_destroy(struct rte_eth_dev *eth_dev, struct rte_flow *rte_flow,\n {\n \tstruct roc_npc_flow *flow = (struct roc_npc_flow *)rte_flow;\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n-\tint mark_actions = 0, vtag_actions = 0;\n \tstruct roc_npc *npc = &dev->npc;\n+\tint vtag_actions = 0;\n \tuint32_t mtr_id;\n \tint rc;\n \n-\tmark_actions = roc_npc_mark_actions_get(npc);\n-\tif (mark_actions) {\n-\t\tmark_actions = roc_npc_mark_actions_sub_return(npc, 1);\n-\t\tif (mark_actions == 0) {\n-\t\t\tdev->rx_offload_flags &= ~NIX_RX_OFFLOAD_MARK_UPDATE_F;\n-\t\t\tcn10k_eth_set_rx_function(eth_dev);\n-\t\t}\n-\t}\n-\n \tvtag_actions = roc_npc_vtag_actions_get(npc);\n \tif (vtag_actions) {\n \t\tif (flow->nix_intf == ROC_NPC_INTF_RX) {\ndiff --git a/drivers/net/cnxk/cn9k_ethdev.c b/drivers/net/cnxk/cn9k_ethdev.c\nindex d34bc68..c44b5b4 100644\n--- a/drivers/net/cnxk/cn9k_ethdev.c\n+++ b/drivers/net/cnxk/cn9k_ethdev.c\n@@ -39,6 +39,9 @@ nix_rx_offload_flags(struct rte_eth_dev *eth_dev)\n \tif (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY)\n \t\tflags |= NIX_RX_OFFLOAD_SECURITY_F;\n \n+\tif (dev->rx_mark_update)\n+\t\tflags |= NIX_RX_OFFLOAD_MARK_UPDATE_F;\n+\n \treturn flags;\n }\n \n@@ -467,6 +470,27 @@ cn9k_nix_dev_start(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n+static int\n+cn9k_nix_rx_metadata_negotiate(struct rte_eth_dev *eth_dev, uint64_t *features)\n+{\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\n+\t*features &=\n+\t\t(RTE_ETH_RX_METADATA_USER_FLAG | RTE_ETH_RX_METADATA_USER_MARK);\n+\n+\tif (*features) {\n+\t\tdev->rx_offload_flags |= NIX_RX_OFFLOAD_MARK_UPDATE_F;\n+\t\tdev->rx_mark_update = true;\n+\t} else {\n+\t\tdev->rx_offload_flags &= ~NIX_RX_OFFLOAD_MARK_UPDATE_F;\n+\t\tdev->rx_mark_update = false;\n+\t}\n+\n+\tcn9k_eth_set_rx_function(eth_dev);\n+\n+\treturn 0;\n+}\n+\n /* Update platform specific eth dev ops */\n static void\n nix_eth_dev_ops_override(void)\n@@ -487,6 +511,7 @@ nix_eth_dev_ops_override(void)\n \tcnxk_eth_dev_ops.timesync_enable = cn9k_nix_timesync_enable;\n \tcnxk_eth_dev_ops.timesync_disable = cn9k_nix_timesync_disable;\n \tcnxk_eth_dev_ops.mtr_ops_get = NULL;\n+\tcnxk_eth_dev_ops.rx_metadata_negotiate = cn9k_nix_rx_metadata_negotiate;\n }\n \n static void\ndiff --git a/drivers/net/cnxk/cn9k_rte_flow.c b/drivers/net/cnxk/cn9k_rte_flow.c\nindex b94d29e..7b98eb0 100644\n--- a/drivers/net/cnxk/cn9k_rte_flow.c\n+++ b/drivers/net/cnxk/cn9k_rte_flow.c\n@@ -13,21 +13,14 @@ cn9k_flow_create(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,\n \t\t struct rte_flow_error *error)\n {\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n-\tint mark_actions = 0, vtag_actions = 0;\n \tstruct roc_npc *npc = &dev->npc;\n \tstruct roc_npc_flow *flow;\n+\tint vtag_actions = 0;\n \n \tflow = cnxk_flow_create(eth_dev, attr, pattern, actions, error);\n \tif (!flow)\n \t\treturn NULL;\n \n-\tmark_actions = roc_npc_mark_actions_get(npc);\n-\n-\tif (mark_actions) {\n-\t\tdev->rx_offload_flags |= NIX_RX_OFFLOAD_MARK_UPDATE_F;\n-\t\tcn9k_eth_set_rx_function(eth_dev);\n-\t}\n-\n \tvtag_actions = roc_npc_vtag_actions_get(npc);\n \n \tif (vtag_actions) {\n@@ -44,17 +37,8 @@ cn9k_flow_destroy(struct rte_eth_dev *eth_dev, struct rte_flow *rte_flow,\n {\n \tstruct roc_npc_flow *flow = (struct roc_npc_flow *)rte_flow;\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n-\tint mark_actions = 0, vtag_actions = 0;\n \tstruct roc_npc *npc = &dev->npc;\n-\n-\tmark_actions = roc_npc_mark_actions_get(npc);\n-\tif (mark_actions) {\n-\t\tmark_actions = roc_npc_mark_actions_sub_return(npc, 1);\n-\t\tif (mark_actions == 0) {\n-\t\t\tdev->rx_offload_flags &= ~NIX_RX_OFFLOAD_MARK_UPDATE_F;\n-\t\t\tcn9k_eth_set_rx_function(eth_dev);\n-\t\t}\n-\t}\n+\tint vtag_actions = 0;\n \n \tvtag_actions = roc_npc_vtag_actions_get(npc);\n \tif (vtag_actions) {\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.h\nindex fadc8aa..f1363af 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.h\n+++ b/drivers/net/cnxk/cnxk_ethdev.h\n@@ -339,6 +339,7 @@ struct cnxk_eth_dev {\n \tuint8_t ptype_disable;\n \tbool scalar_ena;\n \tbool ptp_en;\n+\tbool rx_mark_update; /* Enable/Disable mark update to mbuf */\n \n \t/* Pointer back to rte */\n \tstruct rte_eth_dev *eth_dev;\n", "prefixes": [ "10/20" ] }