Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106854/?format=api
{ "id": 106854, "url": "http://patches.dpdk.org/api/patches/106854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220204174209.440207-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220204174209.440207-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220204174209.440207-2-bruce.richardson@intel.com", "date": "2022-02-04T17:42:03", "name": "[1/7] eal: fix header build with C++", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "75edc81f5f82923183067638161e15c054e5ccb0", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220204174209.440207-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21466, "url": "http://patches.dpdk.org/api/series/21466/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21466", "date": "2022-02-04T17:42:02", "name": "Verify C++ compatibility of public headers", "version": 1, "mbox": "http://patches.dpdk.org/series/21466/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106854/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/106854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 874A8A0350;\n\tFri, 4 Feb 2022 18:42:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6D82640143;\n\tFri, 4 Feb 2022 18:42:30 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id DE22140041\n for <dev@dpdk.org>; Fri, 4 Feb 2022 18:42:27 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Feb 2022 09:42:27 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.162])\n by FMSMGA003.fm.intel.com with ESMTP; 04 Feb 2022 09:42:25 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1643996548; x=1675532548;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=wxXoraHC/PYMOgAHtbEi1hhTgG70FYfiXZ9yxOydCIQ=;\n b=laTZCqpRMJ9lmvttJYhHxYVcC2ZOHEQONqM+/ulKarutEtKh6OghEzAW\n M2S+0uD67U0NOAFwLRSla3yQgB591F2QIntMwM4gVdjfZ9mV3PbzCKCkv\n hobXYVmWeUCwFWXy3Vd52AkGrIHnyx3zVipxG2bjOTWue18y5dhFo0XSe\n 3QRJeplEi+azgoHD/p5xjPcm2Xr8VetxXMaT+P4iHxbC3ZzHsSHdNIptR\n BF1lXfarsq/dOwlRbA2k4btlrdlGL3c0A+xqKxTEYn0mF4hkPA6z+5pKQ\n aAu28fExBImvklF3+LF2KIKPaK078duIXzgdOTVnvGCtM35KWLrgNqOkv w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10248\"; a=\"247241572\"", "E=Sophos;i=\"5.88,343,1635231600\"; d=\"scan'208\";a=\"247241572\"", "E=Sophos;i=\"5.88,343,1635231600\"; d=\"scan'208\";a=\"620890260\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Joyce Kong <joyce.kong@arm.com>, Jerin Jacob <jerinj@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>", "Subject": "[PATCH 1/7] eal: fix header build with C++", "Date": "Fri, 4 Feb 2022 17:42:03 +0000", "Message-Id": "<20220204174209.440207-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220204174209.440207-1-bruce.richardson@intel.com>", "References": "<20220204174209.440207-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "C++ files could not include some headers because:\n\n* \"new\" is a keyword in C++, so can't be a variable name\n* there is no automatic casting to/from void *\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eal/include/generic/rte_ticketlock.h | 14 +++++++-------\n lib/eal/include/rte_trace_point.h | 2 +-\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/eal/include/generic/rte_ticketlock.h b/lib/eal/include/generic/rte_ticketlock.h\nindex c1b8808f51..693c67b517 100644\n--- a/lib/eal/include/generic/rte_ticketlock.h\n+++ b/lib/eal/include/generic/rte_ticketlock.h\n@@ -91,13 +91,13 @@ rte_ticketlock_unlock(rte_ticketlock_t *tl)\n static inline int\n rte_ticketlock_trylock(rte_ticketlock_t *tl)\n {\n-\trte_ticketlock_t old, new;\n-\told.tickets = __atomic_load_n(&tl->tickets, __ATOMIC_RELAXED);\n-\tnew.tickets = old.tickets;\n-\tnew.s.next++;\n-\tif (old.s.next == old.s.current) {\n-\t\tif (__atomic_compare_exchange_n(&tl->tickets, &old.tickets,\n-\t\t new.tickets, 0, __ATOMIC_ACQUIRE, __ATOMIC_RELAXED))\n+\trte_ticketlock_t oldl, newl;\n+\toldl.tickets = __atomic_load_n(&tl->tickets, __ATOMIC_RELAXED);\n+\tnewl.tickets = oldl.tickets;\n+\tnewl.s.next++;\n+\tif (oldl.s.next == oldl.s.current) {\n+\t\tif (__atomic_compare_exchange_n(&tl->tickets, &oldl.tickets,\n+\t\t newl.tickets, 0, __ATOMIC_ACQUIRE, __ATOMIC_RELAXED))\n \t\t\treturn 1;\n \t}\n \ndiff --git a/lib/eal/include/rte_trace_point.h b/lib/eal/include/rte_trace_point.h\nindex e226f073f7..0f8700974f 100644\n--- a/lib/eal/include/rte_trace_point.h\n+++ b/lib/eal/include/rte_trace_point.h\n@@ -370,7 +370,7 @@ do { \\\n do { \\\n \tif (unlikely(in == NULL)) \\\n \t\treturn; \\\n-\trte_strscpy(mem, in, __RTE_TRACE_EMIT_STRING_LEN_MAX); \\\n+\trte_strscpy((char *)mem, in, __RTE_TRACE_EMIT_STRING_LEN_MAX); \\\n \tmem = RTE_PTR_ADD(mem, __RTE_TRACE_EMIT_STRING_LEN_MAX); \\\n } while (0)\n \n", "prefixes": [ "1/7" ] }