Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106696/?format=api
{ "id": 106696, "url": "http://patches.dpdk.org/api/patches/106696/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1643425417-215270-15-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1643425417-215270-15-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1643425417-215270-15-git-send-email-andy.pei@intel.com", "date": "2022-01-29T03:03:36", "name": "[v3,14/15] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx are the same when blk device pause", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3a67ca403f42fcb43d5b1a92a5fb7d846b36f76e", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1643425417-215270-15-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 21420, "url": "http://patches.dpdk.org/api/series/21420/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21420", "date": "2022-01-29T03:03:22", "name": "add virtio_blk device support to vdpa/ifc", "version": 3, "mbox": "http://patches.dpdk.org/series/21420/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106696/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106696/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DD0FEA00C4;\n\tSat, 29 Jan 2022 04:10:50 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 657374289D;\n\tSat, 29 Jan 2022 04:10:12 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id A406D40143\n for <dev@dpdk.org>; Sat, 29 Jan 2022 04:10:10 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Jan 2022 19:10:10 -0800", "from dpdk-dipei.sh.intel.com ([10.67.111.91])\n by fmsmga008.fm.intel.com with ESMTP; 28 Jan 2022 19:10:08 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1643425810; x=1674961810;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=5087tad1YGUkw8YHGaOPminXBtE8KkMaP2tTS2ecQgQ=;\n b=danAoAhTH4Jx3NTUmafAWL/AX+5MACHrHnVL8Tos/pL4tBPsHmyy42b7\n DeCm0z7VNdGZcphsv/GaJp62ixkET8Jl6F/1frTWnotQwIRWwhHjuaqQz\n KctCizeP+8BkTE6oVCol2IwPtjPA4H4948x+ueMXzE4wUOeOQ+183O7RT\n im6kb8GfU6WwAlqFOJkXUjXDl/uKyvPgDJWyTsUG9mm36STs9FOZomfgJ\n TWtf+ii/k3c0lgE9f7ccxN9GKGcogu9gtwlvm4pzo05Q8OPJE+eVs03ed\n 6nQ2VblHU+MkHLJiHRj4ZQF3yZ1UnitQfNQX4eFRrePJiud4UuTkC0jDO w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10241\"; a=\"246076652\"", "E=Sophos;i=\"5.88,325,1635231600\"; d=\"scan'208\";a=\"246076652\"", "E=Sophos;i=\"5.88,325,1635231600\"; d=\"scan'208\";a=\"582047980\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,\n changpeng.liu@intel.com", "Subject": "[PATCH v3 14/15] vdpa/ifc: make sure hardware last_avail_idx and\n last_used_idx are the same when blk device pause", "Date": "Sat, 29 Jan 2022 11:03:36 +0800", "Message-Id": "<1643425417-215270-15-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1643425417-215270-1-git-send-email-andy.pei@intel.com>", "References": "<1643093258-47258-2-git-send-email-andy.pei@intel.com>\n <1643425417-215270-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When virtio blk device is pause, make sure hardware last_avail_idx\nand last_used_idx are the same.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.c | 2 +-\n drivers/vdpa/ifc/base/ifcvf.h | 3 +++\n drivers/vdpa/ifc/ifcvf_vdpa.c | 32 +++++++++++++++++++++++---------\n 3 files changed, 27 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c\nindex a8a4728..7018048 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.c\n+++ b/drivers/vdpa/ifc/base/ifcvf.c\n@@ -116,7 +116,7 @@\n \tIFCVF_WRITE_REG8(status, &hw->common_cfg->device_status);\n }\n \n-STATIC void\n+void\n ifcvf_reset(struct ifcvf_hw *hw)\n {\n \tifcvf_set_status(hw, 0);\ndiff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h\nindex 7367094..f22d18b 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.h\n+++ b/drivers/vdpa/ifc/base/ifcvf.h\n@@ -157,6 +157,9 @@ struct ifcvf_hw {\n int\n ifcvf_init_hw(struct ifcvf_hw *hw, PCI_DEV *dev);\n \n+void\n+ifcvf_reset(struct ifcvf_hw *hw);\n+\n u64\n ifcvf_get_features(struct ifcvf_hw *hw);\n \ndiff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex b65e3a3..75dbe63 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -356,23 +356,32 @@ struct rte_vdpa_dev_info {\n vdpa_ifcvf_blk_pause(struct ifcvf_internal *internal)\n {\n \tstruct ifcvf_hw *hw = &internal->hw;\n-\tstruct rte_vhost_vring vq;\n \tint i, vid;\n \tuint64_t features = 0;\n \tuint64_t log_base = 0, log_size = 0;\n \tuint64_t len;\n+\tu32 ring_state = 0;\n \n \tvid = internal->vid;\n \n \tif (internal->device_type == IFCVF_BLK) {\n \t\tfor (i = 0; i < hw->nr_vring; i++) {\n-\t\t\trte_vhost_get_vhost_vring(internal->vid, i, &vq);\n-\t\t\twhile (vq.avail->idx != vq.used->idx) {\n-\t\t\t\tifcvf_notify_queue(hw, i);\n-\t\t\t\tusleep(10);\n-\t\t\t}\n-\t\t\thw->vring[i].last_avail_idx = vq.avail->idx;\n-\t\t\thw->vring[i].last_used_idx = vq.used->idx;\n+\t\t\tdo {\n+\t\t\t\tif (hw->lm_cfg != NULL)\n+\t\t\t\t\tring_state = *(u32 *)(hw->lm_cfg +\n+\t\t\t\t\t\tIFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t\t\ti * IFCVF_LM_CFG_SIZE);\n+\t\t\t\thw->vring[i].last_avail_idx =\n+\t\t\t\t\t(u16)(ring_state & IFCVF_16_BIT_MASK);\n+\t\t\t\thw->vring[i].last_used_idx =\n+\t\t\t\t\t(u16)(ring_state >> 16);\n+\t\t\t\tif (hw->vring[i].last_avail_idx !=\n+\t\t\t\t\thw->vring[i].last_used_idx) {\n+\t\t\t\t\tifcvf_notify_queue(hw, i);\n+\t\t\t\t\tusleep(10);\n+\t\t\t\t}\n+\t\t\t} while (hw->vring[i].last_avail_idx !=\n+\t\t\t\thw->vring[i].last_used_idx);\n \t\t}\n \t}\n \n@@ -759,7 +768,12 @@ struct rte_vdpa_dev_info {\n \t\tif (ret)\n \t\t\tgoto err;\n \n-\t\tvdpa_ifcvf_stop(internal);\n+\t\tif (internal->device_type == IFCVF_BLK) {\n+\t\t\tvdpa_ifcvf_blk_pause(internal);\n+\t\t\tifcvf_reset(&internal->hw);\n+\t\t} else {\n+\t\t\tvdpa_ifcvf_stop(internal);\n+\t\t}\n \n \t\tret = vdpa_disable_vfio_intr(internal);\n \t\tif (ret)\n", "prefixes": [ "v3", "14/15" ] }