Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106695/?format=api
{ "id": 106695, "url": "http://patches.dpdk.org/api/patches/106695/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1643425417-215270-14-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1643425417-215270-14-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1643425417-215270-14-git-send-email-andy.pei@intel.com", "date": "2022-01-29T03:03:35", "name": "[v3,13/15] vdpa/ifc/base: for blk device, live migration register is different from net device", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "42898e5182fde71fc358599aea37386d462df8e9", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1643425417-215270-14-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 21420, "url": "http://patches.dpdk.org/api/series/21420/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21420", "date": "2022-01-29T03:03:22", "name": "add virtio_blk device support to vdpa/ifc", "version": 3, "mbox": "http://patches.dpdk.org/series/21420/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106695/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 708AFA00C4;\n\tSat, 29 Jan 2022 04:10:46 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 458694288A;\n\tSat, 29 Jan 2022 04:10:10 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 1D9F44288A\n for <dev@dpdk.org>; Sat, 29 Jan 2022 04:10:07 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Jan 2022 19:10:07 -0800", "from dpdk-dipei.sh.intel.com ([10.67.111.91])\n by fmsmga008.fm.intel.com with ESMTP; 28 Jan 2022 19:10:06 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1643425808; x=1674961808;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=OfMQKUusCbeZdl+8sJdrAlffNHrBeBS10u16yx50v50=;\n b=kIrQzHH5yO+4EsKOkzjaJZGxE9F1hVulKPXiuIvfRp4RK1RFpPiyeZna\n Te6cqdhTyK0xp8qo2AGDxgaWYDnrhJPmL+ww7Gm9NdjyOBVEIr5JNzprk\n fj7aCD00m2PjR76TaMoC/Mc5MvoP4IvQPf9touyFThGCLC5mC5vqdsAgv\n w5T+rz55WcEaCjO+8kd2OPbKKLWzw7OBLrgEtS8p38kbRI3xd76uKOlvz\n zy0pjPdwR5H1Dsde9nL/AEeZarRJ26PRjPSnJkIEyADJ5cMv1+at2n+Og\n l6BFCACGvcNIpz0x+tIypPR1T7bMdeg+bKB6hXJv+cl8jOit+QaETujlJ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10241\"; a=\"246076650\"", "E=Sophos;i=\"5.88,325,1635231600\"; d=\"scan'208\";a=\"246076650\"", "E=Sophos;i=\"5.88,325,1635231600\"; d=\"scan'208\";a=\"582047964\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,\n changpeng.liu@intel.com", "Subject": "[PATCH v3 13/15] vdpa/ifc/base: for blk device,\n live migration register is different from net device", "Date": "Sat, 29 Jan 2022 11:03:35 +0800", "Message-Id": "<1643425417-215270-14-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1643425417-215270-1-git-send-email-andy.pei@intel.com>", "References": "<1643093258-47258-2-git-send-email-andy.pei@intel.com>\n <1643425417-215270-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "1.last_avail_idx is lower 16 bit of the register.\n2.address of ring_state register is different between net and blk device.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.c | 36 +++++++++++++++++++++++++++++-------\n drivers/vdpa/ifc/base/ifcvf.h | 1 +\n 2 files changed, 30 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c\nindex 3a69e53..a8a4728 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.c\n+++ b/drivers/vdpa/ifc/base/ifcvf.c\n@@ -216,10 +216,18 @@\n \t\t\t\t&cfg->queue_used_hi);\n \t\tIFCVF_WRITE_REG16(hw->vring[i].size, &cfg->queue_size);\n \n-\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n-\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE + (i % 2) * 4) =\n-\t\t\t(u32)hw->vring[i].last_avail_idx |\n-\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n+\t\tif (hw->is_blk == IFCVF_BLK) {\n+\t\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\ti * IFCVF_LM_CFG_SIZE) =\n+\t\t\t\t(u32)hw->vring[i].last_avail_idx |\n+\t\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n+\t\t} else if (hw->is_blk == IFCVF_NET) {\n+\t\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE +\n+\t\t\t\t(i % 2) * 4) =\n+\t\t\t\t(u32)hw->vring[i].last_avail_idx |\n+\t\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n+\t\t}\n \n \t\tIFCVF_WRITE_REG16(i + 1, &cfg->queue_msix_vector);\n \t\tif (IFCVF_READ_REG16(&cfg->queue_msix_vector) ==\n@@ -252,9 +260,23 @@\n \t\tIFCVF_WRITE_REG16(i, &cfg->queue_select);\n \t\tIFCVF_WRITE_REG16(0, &cfg->queue_enable);\n \t\tIFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg->queue_msix_vector);\n-\t\tring_state = *(u32 *)(hw->lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n-\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE + (i % 2) * 4);\n-\t\thw->vring[i].last_avail_idx = (u16)(ring_state >> 16);\n+\n+\t\tif (hw->is_blk) {\n+\t\t\tring_state = *(u32 *)(hw->lm_cfg +\n+\t\t\t\t\tIFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t\ti * IFCVF_LM_CFG_SIZE);\n+\t\t} else if (hw->is_blk == IFCVF_NET) {\n+\t\t\tring_state = *(u32 *)(hw->lm_cfg +\n+\t\t\t\t\tIFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE +\n+\t\t\t\t\t(i % 2) * 4);\n+\t\t}\n+\n+\t\tif (hw->is_blk == IFCVF_BLK)\n+\t\t\thw->vring[i].last_avail_idx =\n+\t\t\t\t(u16)(ring_state & IFCVF_16_BIT_MASK);\n+\t\telse if (hw->is_blk == IFCVF_NET)\n+\t\t\thw->vring[i].last_avail_idx = (u16)(ring_state >> 16);\n \t\thw->vring[i].last_used_idx = (u16)(ring_state >> 16);\n \t}\n }\ndiff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h\nindex 8e602af..7367094 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.h\n+++ b/drivers/vdpa/ifc/base/ifcvf.h\n@@ -65,6 +65,7 @@\n #define IFCVF_MEDIATED_VRING\t\t0x200000000000\n \n #define IFCVF_32_BIT_MASK\t\t0xffffffff\n+#define IFCVF_16_BIT_MASK\t\t0xffff\n \n #ifndef VHOST_USER_PROTOCOL_F_CONFIG\n #define VHOST_USER_PROTOCOL_F_CONFIG\t9\n", "prefixes": [ "v3", "13/15" ] }