Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106686/?format=api
http://patches.dpdk.org/api/patches/106686/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1643425417-215270-5-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1643425417-215270-5-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1643425417-215270-5-git-send-email-andy.pei@intel.com", "date": "2022-01-29T03:03:26", "name": "[v3,04/15] vdpa/ifc: add vdpa interrupt for blk device", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "afc5c27cf97719a16928608bb8c1875d725f8845", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1643425417-215270-5-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 21420, "url": "http://patches.dpdk.org/api/series/21420/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21420", "date": "2022-01-29T03:03:22", "name": "add virtio_blk device support to vdpa/ifc", "version": 3, "mbox": "http://patches.dpdk.org/series/21420/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106686/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106686/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D32C6A00C4;\n\tSat, 29 Jan 2022 04:09:52 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C3DF4427AB;\n\tSat, 29 Jan 2022 04:09:43 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 0348F427E2\n for <dev@dpdk.org>; Sat, 29 Jan 2022 04:09:41 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Jan 2022 19:09:41 -0800", "from dpdk-dipei.sh.intel.com ([10.67.111.91])\n by fmsmga008.fm.intel.com with ESMTP; 28 Jan 2022 19:09:40 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1643425782; x=1674961782;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=t4X6tW0rhGpYcgtGZzxyo0yrIsxpuFKGI9cxthcm0Ng=;\n b=JHPi1p8mLnsQKZid37AKRYkNLAK+cO0uayWH2Jn+rjzc3vWdLuYvVFgN\n A0WZ5xTSURmHJOB1NG7j6g47lLJO4gcvd5HcnEp3MZOsGvT40XYmm3OZ4\n DjoXdRo8CJlVZlGD5nMZXEQ5TsyLJUZnKGYwmlr56D4MWal+371OkJQmn\n BgSnhNPWD+PS+F2RTMLhBYdmIQXSCR/2lgk1/lBRrYq1CS3kxx3+58SeV\n HDRMMTNOvG8/BgrYfx7L1EGjFYSSYY6pEFJ+mM2RfSNB7GegiMcWerIlh\n p7z7fWh0NmXu+57HGVHnvhTpDQ7/qPmxor/hoVRdqtEYfxsf9K67KolCc g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10241\"; a=\"271699055\"", "E=Sophos;i=\"5.88,325,1635231600\"; d=\"scan'208\";a=\"271699055\"", "E=Sophos;i=\"5.88,325,1635231600\"; d=\"scan'208\";a=\"582047785\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,\n changpeng.liu@intel.com", "Subject": "[PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device", "Date": "Sat, 29 Jan 2022 11:03:26 +0800", "Message-Id": "<1643425417-215270-5-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1643425417-215270-1-git-send-email-andy.pei@intel.com>", "References": "<1643093258-47258-2-git-send-email-andy.pei@intel.com>\n <1643425417-215270-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For the blk we need to relay all the cmd of each queue.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 46 ++++++++++++++++++++++++++++++++-----------\n 1 file changed, 35 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 778e1fd..4f99bb3 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -372,24 +372,48 @@ struct rte_vdpa_dev_info {\n \tirq_set->index = VFIO_PCI_MSIX_IRQ_INDEX;\n \tirq_set->start = 0;\n \tfd_ptr = (int *)&irq_set->data;\n+\t/* The first interrupt is for the configure space change notification */\n \tfd_ptr[RTE_INTR_VEC_ZERO_OFFSET] =\n \t\trte_intr_fd_get(internal->pdev->intr_handle);\n \n \tfor (i = 0; i < nr_vring; i++)\n \t\tinternal->intr_fd[i] = -1;\n \n-\tfor (i = 0; i < nr_vring; i++) {\n-\t\trte_vhost_get_vhost_vring(internal->vid, i, &vring);\n-\t\tfd_ptr[RTE_INTR_VEC_RXTX_OFFSET + i] = vring.callfd;\n-\t\tif ((i & 1) == 0 && m_rx == true) {\n-\t\t\tfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n-\t\t\tif (fd < 0) {\n-\t\t\t\tDRV_LOG(ERR, \"can't setup eventfd: %s\",\n-\t\t\t\t\tstrerror(errno));\n-\t\t\t\treturn -1;\n+\tif (internal->device_type == IFCVF_NET) {\n+\t\tfor (i = 0; i < nr_vring; i++) {\n+\t\t\trte_vhost_get_vhost_vring(internal->vid, i, &vring);\n+\t\t\tfd_ptr[RTE_INTR_VEC_RXTX_OFFSET + i] = vring.callfd;\n+\t\t\tif ((i & 1) == 0 && m_rx == true) {\n+\t\t\t\t/* For the net we only need to relay rx queue,\n+\t\t\t\t * which will change the mem of VM.\n+\t\t\t\t */\n+\t\t\t\tfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n+\t\t\t\tif (fd < 0) {\n+\t\t\t\t\tDRV_LOG(ERR, \"can't setup eventfd: %s\",\n+\t\t\t\t\t\tstrerror(errno));\n+\t\t\t\t\treturn -1;\n+\t\t\t\t}\n+\t\t\t\tinternal->intr_fd[i] = fd;\n+\t\t\t\tfd_ptr[RTE_INTR_VEC_RXTX_OFFSET + i] = fd;\n+\t\t\t}\n+\t\t}\n+\t} else if (internal->device_type == IFCVF_BLK) {\n+\t\tfor (i = 0; i < nr_vring; i++) {\n+\t\t\trte_vhost_get_vhost_vring(internal->vid, i, &vring);\n+\t\t\tfd_ptr[RTE_INTR_VEC_RXTX_OFFSET + i] = vring.callfd;\n+\t\t\tif (m_rx == true) {\n+\t\t\t\t/* For the blk we need to relay all the read cmd\n+\t\t\t\t * of each queue\n+\t\t\t\t */\n+\t\t\t\tfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n+\t\t\t\tif (fd < 0) {\n+\t\t\t\t\tDRV_LOG(ERR, \"can't setup eventfd: %s\",\n+\t\t\t\t\t\tstrerror(errno));\n+\t\t\t\t\treturn -1;\n+\t\t\t\t}\n+\t\t\t\tinternal->intr_fd[i] = fd;\n+\t\t\t\tfd_ptr[RTE_INTR_VEC_RXTX_OFFSET + i] = fd;\n \t\t\t}\n-\t\t\tinternal->intr_fd[i] = fd;\n-\t\t\tfd_ptr[RTE_INTR_VEC_RXTX_OFFSET + i] = fd;\n \t\t}\n \t}\n \n", "prefixes": [ "v3", "04/15" ] }{ "id": 106686, "url": "