Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 10661,
    "url": "http://patches.dpdk.org/api/patches/10661/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1455806076-18497-22-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1455806076-18497-22-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1455806076-18497-22-git-send-email-helin.zhang@intel.com",
    "date": "2016-02-18T14:34:27",
    "name": "[dpdk-dev,v3,21/30] i40e/base: coding style fixes",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0f6a5b87c3a064db7b8509afda1931d8f659810e",
    "submitter": {
        "id": 14,
        "url": "http://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": {
        "id": 10,
        "url": "http://patches.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1455806076-18497-22-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/10661/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/10661/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0BE37C508;\n\tThu, 18 Feb 2016 15:35:45 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 6D74FC4EE\n\tfor <dev@dpdk.org>; Thu, 18 Feb 2016 15:35:42 +0100 (CET)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP; 18 Feb 2016 06:35:28 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga004.fm.intel.com with ESMTP; 18 Feb 2016 06:35:28 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u1IEZQls019293;\n\tThu, 18 Feb 2016 22:35:26 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u1IEZNK7018686; Thu, 18 Feb 2016 22:35:25 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u1IEZNtt018682; \n\tThu, 18 Feb 2016 22:35:23 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.22,465,1449561600\"; d=\"scan'208\";a=\"50200082\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 18 Feb 2016 22:34:27 +0800",
        "Message-Id": "<1455806076-18497-22-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1455806076-18497-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1455776683-11790-1-git-send-email-helin.zhang@intel.com>\n\t<1455806076-18497-1-git-send-email-helin.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 21/30] i40e/base: coding style fixes",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "It adds coding style fixes.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 19 ++++++++++++-------\n 1 file changed, 12 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 9a0b787..e94f726 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -1540,9 +1540,11 @@ u32 i40e_led_get(struct i40e_hw *hw)\n \t\tif (!gpio_val)\n \t\t\tcontinue;\n \n-\t\t/* ignore gpio LED src mode entries related to the activity LEDs */\n-\t\tcurrent_mode = ((gpio_val & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK) >>\n-\t\t\tI40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT);\n+\t\t/* ignore gpio LED src mode entries related to the activity\n+\t\t *  LEDs\n+\t\t */\n+\t\tcurrent_mode = ((gpio_val & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK)\n+\t\t\t\t>> I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT);\n \t\tswitch (current_mode) {\n \t\tcase I40E_COMBINED_ACTIVITY:\n \t\tcase I40E_FILTER_ACTIVITY:\n@@ -1586,9 +1588,11 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)\n \t\tif (!gpio_val)\n \t\t\tcontinue;\n \n-\t\t/* ignore gpio LED src mode entries related to the activity LEDs */\n-\t\tcurrent_mode = ((gpio_val & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK) >>\n-\t\t\tI40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT);\n+\t\t/* ignore gpio LED src mode entries related to the activity\n+\t\t * LEDs\n+\t\t */\n+\t\tcurrent_mode = ((gpio_val & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK)\n+\t\t\t\t>> I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT);\n \t\tswitch (current_mode) {\n \t\tcase I40E_COMBINED_ACTIVITY:\n \t\tcase I40E_FILTER_ACTIVITY:\n@@ -2821,6 +2825,7 @@ enum i40e_status_code i40e_aq_get_veb_parameters(struct i40e_hw *hw,\n \t\t*vebs_free = LE16_TO_CPU(cmd_resp->vebs_free);\n \tif (floating) {\n \t\tu16 flags = LE16_TO_CPU(cmd_resp->veb_flags);\n+\n \t\tif (flags & I40E_AQC_ADD_VEB_FLOATING)\n \t\t\t*floating = true;\n \t\telse\n@@ -5471,7 +5476,7 @@ void i40e_add_filter_to_drop_tx_flow_control_frames(struct i40e_hw *hw,\n \tu16 ethtype = I40E_FLOW_CONTROL_ETHTYPE;\n \tenum i40e_status_code status;\n \n-\tstatus = i40e_aq_add_rem_control_packet_filter(hw, 0, ethtype, flag,\n+\tstatus = i40e_aq_add_rem_control_packet_filter(hw, NULL, ethtype, flag,\n \t\t\t\t\t\t       seid, 0, true, NULL,\n \t\t\t\t\t\t       NULL);\n \tif (status)\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "21/30"
    ]
}