Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106470/?format=api
{ "id": 106470, "url": "http://patches.dpdk.org/api/patches/106470/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1643093258-47258-16-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1643093258-47258-16-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1643093258-47258-16-git-send-email-andy.pei@intel.com", "date": "2022-01-25T06:47:38", "name": "[15/15] vhost: make sure each queue callfd is configured", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "69d311aa717f894523d468f52ab9dbc234373cf1", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1643093258-47258-16-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 21347, "url": "http://patches.dpdk.org/api/series/21347/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21347", "date": "2022-01-25T06:47:23", "name": "add virtio_blk device support to vdpa/ifc", "version": 1, "mbox": "http://patches.dpdk.org/series/21347/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106470/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/106470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D916AA04A9;\n\tTue, 25 Jan 2022 07:54:34 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7C60642837;\n\tTue, 25 Jan 2022 07:54:04 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id E82F94282D\n for <dev@dpdk.org>; Tue, 25 Jan 2022 07:54:02 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jan 2022 22:53:47 -0800", "from dpdk-dipei.sh.intel.com ([10.67.111.91])\n by orsmga005.jf.intel.com with ESMTP; 24 Jan 2022 22:53:46 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1643093643; x=1674629643;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=iiC9zjPCRWSFSUr3n/L661D8aNJGk/y8rMEVaa6naFk=;\n b=SurbhJvXfTc6Me3731VZ5XA34asgpzqkvQyVsaAAYxTdIA4pgSvJMmnR\n QMNbUKRsZ579L0Mn7YLD5eXCaMtipF2snvzPwG1Gn87L+7C5CuBgBE10q\n r92W/m0tPr4qmjoYyZRfxjKppgt20gOBL4HyCR9CksI4pXsVn3ib7Wd12\n Is29LcQDxpEi+xDqjsSvoO0yiqJpKUduNHFCSzx2GxCq5G54hzorgfu2t\n B6XoKuCp7trb24Ds0jOOz1KDeammV11SrpRWHX5jM1n1BOEnQFulXbRsZ\n zy/7rMqfsOK7fyNOmJwgRRbiiI9DpZRmnfwJlUfPWbuvl3yd2XSuK6QSd A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10237\"; a=\"246181375\"", "E=Sophos;i=\"5.88,314,1635231600\"; d=\"scan'208\";a=\"246181375\"", "E=Sophos;i=\"5.88,314,1635231600\"; d=\"scan'208\";a=\"695724385\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,\n changpeng.liu@intel.com", "Subject": "[PATCH 15/15] vhost: make sure each queue callfd is configured", "Date": "Tue, 25 Jan 2022 14:47:38 +0800", "Message-Id": "<1643093258-47258-16-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1643093258-47258-1-git-send-email-andy.pei@intel.com>", "References": "<1643093258-47258-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "During the vhost data path building process, qemu will create a call fd at first,\nand create another call fd in the end. The final call fd will be used to relay notify.\nIn the original code, after kick fd is set, dev_conf will set the first\ncall fd. Even though the actual call fd will set, the data path will not work correctly.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n lib/vhost/vhost_user.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 5eb1dd6..0be879a 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -3137,12 +3137,27 @@ typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,\n \tif (!vdpa_dev)\n \t\tgoto out;\n \n+\tif (request != VHOST_USER_SET_VRING_CALL)\n+\t\tgoto out;\n+\n \tif (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {\n \t\tif (vdpa_dev->ops->dev_conf(dev->vid))\n \t\t\tVHOST_LOG_CONFIG(ERR,\n \t\t\t\t\t \"Failed to configure vDPA device\\n\");\n \t\telse\n \t\t\tdev->flags |= VIRTIO_DEV_VDPA_CONFIGURED;\n+\t} else {\n+\t\t/**\n+\t\t** when VIRTIO_DEV_VDPA_CONFIGURED already configured\n+\t\t** close the device and config the device again,\n+\t\t** make sure the call fd of each queue is configed correctly.\n+\t\t**/\n+\t\tif (vdpa_dev->ops->dev_close(dev->vid))\n+\t\t\tVHOST_LOG_CONFIG(ERR,\n+\t\t\t\t\t \"Failed to close vDPA device\\n\");\n+\t\tif (vdpa_dev->ops->dev_conf(dev->vid))\n+\t\t\tVHOST_LOG_CONFIG(ERR,\n+\t\t\t\t\t \"Failed to re-config vDPA device\\n\");\n \t}\n \n out:\n", "prefixes": [ "15/15" ] }