Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106323/?format=api
{ "id": 106323, "url": "http://patches.dpdk.org/api/patches/106323/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220124035005.18955-1-wei.huang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124035005.18955-1-wei.huang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124035005.18955-1-wei.huang@intel.com", "date": "2022-01-24T03:50:05", "name": "[v8] raw/ifpga: fix pthread cannot join", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2029be87be171c159401cf3e47ecd711b9dc3b68", "submitter": { "id": 2033, "url": "http://patches.dpdk.org/api/people/2033/?format=api", "name": "Wei Huang", "email": "wei.huang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220124035005.18955-1-wei.huang@intel.com/mbox/", "series": [ { "id": 21317, "url": "http://patches.dpdk.org/api/series/21317/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21317", "date": "2022-01-24T03:50:05", "name": "[v8] raw/ifpga: fix pthread cannot join", "version": 8, "mbox": "http://patches.dpdk.org/series/21317/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106323/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106323/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CC998A04A6;\n\tMon, 24 Jan 2022 04:53:17 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4436C4014F;\n\tMon, 24 Jan 2022 04:53:17 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 57FBB40040;\n Mon, 24 Jan 2022 04:53:15 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jan 2022 19:53:14 -0800", "from unknown (HELO localhost.localdomain.sh.intel.com)\n ([10.238.175.107])\n by orsmga005.jf.intel.com with ESMTP; 23 Jan 2022 19:53:11 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1642996395; x=1674532395;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=G2c/H5TC+OdEylQq+LzAEe7ICtJfm7uTdMVxRfLot7A=;\n b=QXHYbwTY9Tp+B+ejhhXvQgO2UD8nLmeLS9CAADk+rIKsihtKHECtq6Vo\n 609EgyDnXY/FRHeDKPLl7Jxqft9uOBpQH7clbrpH8/MdaAoBAS0BmI26P\n CxZkTw6y+/vT8te7ZOEIiY3Wgco02/T9KiJPAPn7djT3hBDr2vnPOUhW+\n lPYMLFAMf2PPqEgpKTG1I/jmv5RczGGMcVgqdY0nk31JgJmzCBhBWr7oq\n FuRJUZxG6FdVcGjr02foZg47lpQoQjqHzm7qP1PMdmU3jmdjlUe0TIgIW\n D/ok0RM+GzwAk+hIKMHxpFl9gAApnM+t6fl583AOGxnCrCsU9IT5qkRdV A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10236\"; a=\"245739205\"", "E=Sophos;i=\"5.88,311,1635231600\"; d=\"scan'208\";a=\"245739205\"", "E=Sophos;i=\"5.88,311,1635231600\"; d=\"scan'208\";a=\"695280256\"" ], "X-ExtLoop1": "1", "From": "Wei Huang <wei.huang@intel.com>", "To": "dev@dpdk.org,\n\trosen.xu@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "stable@dpdk.org, tianfei.zhang@intel.com, ferruh.yigit@intel.com,\n stephen@networkplumber.org, david.marchand@redhat.com", "Subject": "[PATCH v8] raw/ifpga: fix pthread cannot join", "Date": "Sun, 23 Jan 2022 22:50:05 -0500", "Message-Id": "<20220124035005.18955-1-wei.huang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20220124023912.18650-1-wei.huang@intel.com>", "References": "<20220124023912.18650-1-wei.huang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Tianfei Zhang <tianfei.zhang@intel.com>\n\nWhen we want to close a thread, we should set a flag to notify\nthread handler function.\n\nFixes: 9c006c45 (\"raw/ifpga: scan PCIe BDF device tree\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tianfei Zhang <tianfei.zhang@intel.com>\n---\nv2: update commit log\n---\nv3: set thread id to 0 after pthread_join\n---\nv4: do not evaluate and set pthread_t variable\n---\nv5: use builtin atomic function to access ifpga_monitor_start flag\n---\nv6: use __atomic_xxx_n to replace rte_atomicNN_xxx\n---\nv7: fix typo\n---\nv8: solve patch applying issue\n---\n drivers/raw/ifpga/ifpga_rawdev.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex 8d9db58..19c2357 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -497,7 +497,7 @@ static int set_surprise_link_check_aer(\n \tint gsd_enable, ret;\n #define MS 1000\n \n-\twhile (1) {\n+\twhile (__atomic_load_n(&ifpga_monitor_start, __ATOMIC_RELAXED)) {\n \t\tgsd_enable = 0;\n \t\tfor (i = 0; i < IFPGA_RAWDEV_NUM; i++) {\n \t\t\tifpga_rdev = &ifpga_rawdevices[i];\n@@ -525,7 +525,7 @@ static int set_surprise_link_check_aer(\n {\n \tint ret;\n \n-\tif (ifpga_monitor_start == 0) {\n+\tif (!__atomic_load_n(&ifpga_monitor_start, __ATOMIC_RELAXED)) {\n \t\tret = rte_ctrl_thread_create(&ifpga_monitor_start_thread,\n \t\t\t\t\t \"ifpga-monitor\", NULL,\n \t\t\t\t\t ifpga_rawdev_gsd_handle, NULL);\n@@ -534,7 +534,7 @@ static int set_surprise_link_check_aer(\n \t\t\t\t\"Fail to create ifpga monitor thread\");\n \t\t\treturn -1;\n \t\t}\n-\t\tifpga_monitor_start = 1;\n+\t\t__atomic_store_n(&ifpga_monitor_start, 1, __ATOMIC_RELAXED);\n \t}\n \n \treturn 0;\n@@ -544,7 +544,9 @@ static int set_surprise_link_check_aer(\n {\n \tint ret;\n \n-\tif (ifpga_monitor_start == 1) {\n+\tif (__atomic_load_n(&ifpga_monitor_start, __ATOMIC_RELAXED)) {\n+\t\t__atomic_store_n(&ifpga_monitor_start, 0, __ATOMIC_RELAXED);\n+\n \t\tret = pthread_cancel(ifpga_monitor_start_thread);\n \t\tif (ret)\n \t\t\tIFPGA_RAWDEV_PMD_ERR(\"Can't cancel the thread\");\n@@ -553,8 +555,6 @@ static int set_surprise_link_check_aer(\n \t\tif (ret)\n \t\t\tIFPGA_RAWDEV_PMD_ERR(\"Can't join the thread\");\n \n-\t\tifpga_monitor_start = 0;\n-\n \t\treturn ret;\n \t}\n \n", "prefixes": [ "v8" ] }