Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106319/?format=api
{ "id": 106319, "url": "http://patches.dpdk.org/api/patches/106319/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-81-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-81-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-81-stephen@networkplumber.org", "date": "2022-01-24T00:05:16", "name": "[80/82] port: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e768d797adff94547d0e2a979137623879d6a264", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-81-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "http://patches.dpdk.org/api/series/21315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/21315/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106319/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106319/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BDB66A04A6;\n\tMon, 24 Jan 2022 01:12:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D971D42968;\n\tMon, 24 Jan 2022 01:06:49 +0100 (CET)", "from mail-pl1-f175.google.com (mail-pl1-f175.google.com\n [209.85.214.175])\n by mails.dpdk.org (Postfix) with ESMTP id 3B80942953\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:06:46 +0100 (CET)", "by mail-pl1-f175.google.com with SMTP id d7so13905149plr.12\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:06:46 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.06.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:06:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=su+2iWKTkbFtsNLGM+VLfZiV8t8YMaoSIC5oWYs3dcg=;\n b=s0ticvjFqYCwnXaVJWO/fT0bx2W4Cci40EBZJmll8paB1rPOoC7HfJkinbD6Dt9KAx\n xwTClQTLINCKiiVhIlEgV6tmjceZ0BoeYV7IwCHmrMZGKc+jVTp7nQ1psH/EtF47e1HU\n jvezDYO3k0SOcleWvDqvtNhBKdPoLvbeSsuYLs++HW3VenFV5P2EsSOVt+WtEVcX3i+x\n 6RcJ17lc1zEpdf2/169Nysy/vxM9kkQO8OpHVmI63Wn5LeQsPmBpfaDD/GAT+Vx1BJd4\n U3nqf+2F800OGNjpZOPzKErpeAb2JAwCcH9mlTk6mxpxF4BkiwumBzX7AFlK3bRlC6D/\n lCQQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=su+2iWKTkbFtsNLGM+VLfZiV8t8YMaoSIC5oWYs3dcg=;\n b=vtAHeJVLV6x/39eOFO5cUigpI2qv5883RBYS2GQ/B3Gwxj2elZEh/4jiWF57MbcnmP\n 4YL8lv+6RJJTduhYlVq4oBa4OH5NuaKwglsg+ynkgqQtmmBpxkFkVuYVT5eaLzSXYA8Q\n WZ/UZ1HmVqwq2zNl6zn8JLJMHo9JspHp7KhcJOg2OLs7opw0/kyVZRnzu49vfcjnaPe5\n s+laNI6XGsA9M7dYUPlKIidiPIbqrmsbI6IXQV6LjfMSBo5xCTOkHODavkLBYb6tLvWs\n WcuHTf8LvxtXTCkNgPn25XAk49ur2PKY+DeAYWY2lxu50iZ0cP187eFYaNVidtw2lHVW\n P3eg==", "X-Gm-Message-State": "AOAM533krn3LGvriLRh3giEYgUZoYaMNg9WNRpP/IJMjsmOP8Yn2a4EP\n roKXldCjUH6e8dtgLJbEQdhx0NJslEPByQ==", "X-Google-Smtp-Source": "\n ABdhPJxGpdvt6Ef6pj216pz2V3JYF+IRegylYMSNbBfb1aQq/nctayLQ6pnCl9L+qSbSqN9vcRNjQQ==", "X-Received": "by 2002:a17:90a:5e0d:: with SMTP id\n w13mr10523007pjf.235.1642982804965;\n Sun, 23 Jan 2022 16:06:44 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH 80/82] port: remove unnecessary NULL checks", "Date": "Sun, 23 Jan 2022 16:05:16 -0800", "Message-Id": "<20220124000518.319850-81-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove redundant NULL pointer checks before free functions\nfound by nullfree.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/port/rte_port_source_sink.c | 21 +++++++--------------\n 1 file changed, 7 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/port/rte_port_source_sink.c b/lib/port/rte_port_source_sink.c\nindex 68575c98338d..79042d13ff66 100644\n--- a/lib/port/rte_port_source_sink.c\n+++ b/lib/port/rte_port_source_sink.c\n@@ -163,14 +163,10 @@ pcap_source_load(struct rte_port_source *port,\n \treturn 0;\n \n error_exit:\n-\tif (pkt_len_aligns)\n-\t\trte_free(pkt_len_aligns);\n-\tif (port->pkt_len)\n-\t\trte_free(port->pkt_len);\n-\tif (port->pkts)\n-\t\trte_free(port->pkts);\n-\tif (port->pkt_buff)\n-\t\trte_free(port->pkt_buff);\n+\trte_free(pkt_len_aligns);\n+\trte_free(port->pkt_len);\n+\trte_free(port->pkts);\n+\trte_free(port->pkt_buff);\n \n \treturn -1;\n }\n@@ -242,12 +238,9 @@ rte_port_source_free(void *port)\n \tif (p == NULL)\n \t\treturn 0;\n \n-\tif (p->pkt_len)\n-\t\trte_free(p->pkt_len);\n-\tif (p->pkts)\n-\t\trte_free(p->pkts);\n-\tif (p->pkt_buff)\n-\t\trte_free(p->pkt_buff);\n+\trte_free(p->pkt_len);\n+\trte_free(p->pkts);\n+\trte_free(p->pkt_buff);\n \n \trte_free(p);\n \n", "prefixes": [ "80/82" ] }