Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106314/?format=api
http://patches.dpdk.org/api/patches/106314/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-76-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-76-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-76-stephen@networkplumber.org", "date": "2022-01-24T00:05:11", "name": "[75/82] vdpa/mlx5: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ee801f3a9d6a44671cc3858fe9b7f9dc23a522d4", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-76-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "http://patches.dpdk.org/api/series/21315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/21315/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106314/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106314/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 44CBBA04A6;\n\tMon, 24 Jan 2022 01:11:59 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E97F24294C;\n\tMon, 24 Jan 2022 01:06:44 +0100 (CET)", "from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n by mails.dpdk.org (Postfix) with ESMTP id D29704289F\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:06:40 +0100 (CET)", "by mail-pf1-f169.google.com with SMTP id u10so9694917pfg.10\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:06:40 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.06.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:06:39 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=GRDAuxuSBVGu0f5cksd8Yr7OU7H6KcL7WM0YksWYbK0=;\n b=6uzNHq9fVRQ0e3duWn711jKJV14QHyZmjgKL2zvQlh6pyOtl/W5Q7XLPDxhYK0F//1\n UaU3RItJLkEWNdJKcMG1l7Jgva2IH7e86v6zuJR8YJ3iINkt3VQjsLMoWXtQQJMz6cXC\n Dj+lC74/kp8bgdta8kuSd2odz3oi9Vr8tdfOajr/JP+fg7KAwIbFMIKhzuJfkrEuHzjK\n nGCDJ6dyxv9+OtObW56HXDBAA7SzXSXq5SHxta2XZ6dtwWJIrgjC0Jy/bbiG2p9zOHlm\n BGYoYAVWLBKa0KwIsam4DsrbMAxHL93CjTOvxNq5Z4WeSYOQlS30ZbzCn3pwC2jgOZAU\n eUVg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=GRDAuxuSBVGu0f5cksd8Yr7OU7H6KcL7WM0YksWYbK0=;\n b=IUhLzqclug/KNT5kVt6Sroejc+XqklcT5rPsp2MN9VAcg1ulXqaXx7fU+JzLFN0uGs\n JqrLHgOlwEDnbxKBgdAopECP/1GHq3XvWc798CX1ZZ576xH7LMfHCanSVP/eVocifP/Z\n NS3Sa7jIgkgtBhSPAg8h7a2Bcu8z8UlQ+sS87i2emjTgX5Tcy4DXf0qQ9Gtl8R3O4DDD\n wLyX/wDiaUauLnEkOym1ab4jQ5srUmaHdMyNeuElL1pWaAGajWjp+6YfBKJ6XMQOcvAV\n g6j3lCG3yFLSE8KMnX/uBz5iOa8nl5dXvS+ijFwZNdfiOjV8B4bshd85OjnMox7EBsHd\n OpqA==", "X-Gm-Message-State": "AOAM531mDm00/LtvMVrWiKfmRAeZ+8F2x+OXBE/m6XhHp4T/J0VzQ5bV\n Touwj4v5e3BtAoRhPzIw6IrobjgmPJq8/Q==", "X-Google-Smtp-Source": "\n ABdhPJyLB0y5FuPFihDDGCROwJPa4o73BKFexsaSBI82O8SHo3uoKOYWjr7uijDuS8D8q0nIfFTqBQ==", "X-Received": "by 2002:aa7:928e:0:b0:4ba:fa67:d87 with SMTP id\n j14-20020aa7928e000000b004bafa670d87mr11826208pfa.41.1642982799799;\n Sun, 23 Jan 2022 16:06:39 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Subject": "[PATCH 75/82] vdpa/mlx5: remove unnecessary NULL checks", "Date": "Sun, 23 Jan 2022 16:05:11 -0800", "Message-Id": "<20220124000518.319850-76-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove redundant NULL pointer checks before free functions\nfound by nullfree.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 3 +--\n drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +--\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c\nindex 130d201a85f5..599079500b03 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c\n@@ -283,8 +283,7 @@ mlx5_vdpa_mem_register(struct mlx5_vdpa_priv *priv)\n \tpriv->gpa_mkey_index = entry->mkey->id;\n \treturn 0;\n error:\n-\tif (entry)\n-\t\trte_free(entry);\n+\trte_free(entry);\n \tmlx5_vdpa_mem_dereg(priv);\n \trte_errno = -ret;\n \treturn ret;\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\nindex 2f32aef67fbc..3416797d289c 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n@@ -91,8 +91,7 @@ mlx5_vdpa_virtq_unset(struct mlx5_vdpa_virtq *virtq)\n \t\tif (virtq->umems[i].obj)\n \t\t\tclaim_zero(mlx5_glue->devx_umem_dereg\n \t\t\t\t\t\t\t (virtq->umems[i].obj));\n-\t\tif (virtq->umems[i].buf)\n-\t\t\trte_free(virtq->umems[i].buf);\n+\t\trte_free(virtq->umems[i].buf);\n \t}\n \tmemset(&virtq->umems, 0, sizeof(virtq->umems));\n \tif (virtq->eqp.fw_qp)\n", "prefixes": [ "75/82" ] }{ "id": 106314, "url": "