Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106304/?format=api
{ "id": 106304, "url": "http://patches.dpdk.org/api/patches/106304/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-66-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-66-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-66-stephen@networkplumber.org", "date": "2022-01-24T00:05:01", "name": "[65/82] net/txgbe: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bae4e0ac5a272fa5954c0387e1cfe208670804fa", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-66-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "http://patches.dpdk.org/api/series/21315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/21315/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106304/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106304/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2ED3CA04A6;\n\tMon, 24 Jan 2022 01:11:11 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6B6B642917;\n\tMon, 24 Jan 2022 01:06:35 +0100 (CET)", "from mail-pg1-f178.google.com (mail-pg1-f178.google.com\n [209.85.215.178])\n by mails.dpdk.org (Postfix) with ESMTP id 94777428FC\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:06:30 +0100 (CET)", "by mail-pg1-f178.google.com with SMTP id j10so1503804pgc.6\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:06:30 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.06.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:06:29 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=E96ft4qyO/eqoKsfrx/yiUbkbGpU8voQmEFSYUalvxw=;\n b=0qzc6tYBUDvGbX0d7IjTXJGUbbrHfxajx+iwVi9yQbB/v8geG0rRDNT/WpSaIqekMT\n Z6LUgbNWOhEHGHYzu5NUtc5Eglbj+NETyFVqQT7LVyGwb81F41ZdotczgPu4B5HgGKzM\n QZDyKGn5brpQlO6PWJkEQcG8nsbbC1tCA5F3y7Lm/rkaLr/fZb0tRzN7mh126/1WmrTA\n x6JFPvnwhbSktUfM5zA7LHdyJn5+CBHrEqQfIR8xEZMEy97g8kALlVpUiWkhjaXqMkSt\n Yy3RAj20obqm1J9KT2TW35GnlEN5XnajWwq7PqAOZFu5BV13waLze1h1F3hpyJ3Gv/3A\n NQBQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=E96ft4qyO/eqoKsfrx/yiUbkbGpU8voQmEFSYUalvxw=;\n b=mgRDuxfOmMM+sMbUDTSW21fQZImH+kuHvfsm/z7sEGZPtMIW2rhYFAo6llMmC5vewP\n ifW3kLT/NYsV7POxMWCzspcPueWjAR2q/EznkMMqBCPfu3E5Vu4tM64HAigjUfbhHLb9\n u3ybdLSl2xdJmTcXdwv/8eYEbuuZ6n513YrnfQMrIW0AyTh6WyrayHmmmgLsRi7+8Se6\n j0Jrfk9Q37BtD/Don2gUcq8fUgzAF9O72k/sMIR/q+EaSBexJgyV5CkouWgRY9Rmikrg\n j7iu1ZL4b05vR0/MZA0quqYkFtj+bBBaMEuGdwh2n04ptgXmkgEXBOtCH7U2I6MwqnrP\n sdgw==", "X-Gm-Message-State": "AOAM5327M7RqbJ1T7x+BLbsKtUbpjDDCSpJ4OzDhbIo4FFeHOO5rLJKR\n CDPBwnIo2ZdgtIBoGiwgfNsu1ro+hq1d2A==", "X-Google-Smtp-Source": "\n ABdhPJwqMUo1+jf3uu6NQzZGM+MXuDKnXJfp6e1R6utju7P6XB4UsGxrIbJ3N54azYsMxGIiVUvoYw==", "X-Received": "by 2002:a63:6ac1:: with SMTP id\n f184mr5717409pgc.455.1642982789574;\n Sun, 23 Jan 2022 16:06:29 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jian Wang <jianwang@trustnetic.com>", "Subject": "[PATCH 65/82] net/txgbe: remove unnecessary NULL checks", "Date": "Sun, 23 Jan 2022 16:05:01 -0800", "Message-Id": "<20220124000518.319850-66-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove redundant NULL pointer checks before free functions\nfound by nullfree.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex ac4d4e08f407..6024397072c8 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -821,10 +821,8 @@ static int txgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev)\n \tstruct txgbe_hw_fdir_info *fdir_info = TXGBE_DEV_FDIR(eth_dev);\n \tstruct txgbe_fdir_filter *fdir_filter;\n \n-\tif (fdir_info->hash_map)\n-\t\trte_free(fdir_info->hash_map);\n-\tif (fdir_info->hash_handle)\n-\t\trte_hash_free(fdir_info->hash_handle);\n+\trte_free(fdir_info->hash_map);\n+\trte_hash_free(fdir_info->hash_handle);\n \n \twhile ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) {\n \t\tTAILQ_REMOVE(&fdir_info->fdir_list,\n@@ -841,10 +839,8 @@ static int txgbe_l2_tn_filter_uninit(struct rte_eth_dev *eth_dev)\n \tstruct txgbe_l2_tn_info *l2_tn_info = TXGBE_DEV_L2_TN(eth_dev);\n \tstruct txgbe_l2_tn_filter *l2_tn_filter;\n \n-\tif (l2_tn_info->hash_map)\n-\t\trte_free(l2_tn_info->hash_map);\n-\tif (l2_tn_info->hash_handle)\n-\t\trte_hash_free(l2_tn_info->hash_handle);\n+\trte_free(l2_tn_info->hash_map);\n+\trte_hash_free(l2_tn_info->hash_handle);\n \n \twhile ((l2_tn_filter = TAILQ_FIRST(&l2_tn_info->l2_tn_list))) {\n \t\tTAILQ_REMOVE(&l2_tn_info->l2_tn_list,\n", "prefixes": [ "65/82" ] }